From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB75EA04B1; Wed, 4 Nov 2020 22:03:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDD7B2BFF; Wed, 4 Nov 2020 22:03:00 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7C0A92BF7 for ; Wed, 4 Nov 2020 22:02:59 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id EEBBD5C011B; Wed, 4 Nov 2020 16:02:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 04 Nov 2020 16:02:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= UihISCUh3ZkDQQoLOlLEmC9UGjLcYNZOHjk9/bpP3No=; b=RpEz6uriJIh3kbFi sA5jjV07sgFt6o1e5hiumoUZbKveXng3MqEz+fojlgXmmM+hGOol3KbL8nHF6xDN bXpFq5WoBi9M0h9AsllHKmRkR/S/ALveokDkrgtD2JZvrGlWp2g/05KuPAcGH8bo Egg64gF6caFFBI+3empAYUqiry/WvkcAr5QldU+bNG5OC68zRNDBIboI2sgDpcBa 8RiSZs6j+EPBnTBxPiQZfmjQGKJPKzy+fBaXNBBShq5L9aAFEB+OXAU8eA8uO5mV Vaeiqac89jX1/vDLQm2nf+AO8TriHnQ/YSo5HkdxnRSXNQ4GCkQLLokejC6UyTu+ +N8PPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UihISCUh3ZkDQQoLOlLEmC9UGjLcYNZOHjk9/bpP3 No=; b=gbgYj2dn/NGELhyL0UkvrOANTITedgFYQakQ2Q0SkKKOxcLNJWAwJLZ0c 8LIblWcit9RSsO8JLNgRLETRaBrGDlZPoe87B7aGIohUMLZVeqLeDw+gg7uHjOv3 SHxLoCgsDowur7F8EG36crUgq3VvlFQf01ovG1MOZZiVXn2xHSWnVtTOm9fMeyO+ azXx1n4ZYNmXqEalmwWkqlb14JWC7lC4bFUqBEgK38yiu1lBpMglV2TDtkQckXYh EIx3S37qDFz8hDWnf+zw/WkdRouu+ltiblrko2xKDpgODEj/9etSPaQ5KDwNA9Wt oU/o7PRT7V0aDtXspA6AWR/yFkLsA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddthedgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtqh ertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdfhuefgtefhteeftd fgudekgffghfefveeiffeghfehleetieevleegteeitedvnecuffhomhgrihhnpehtrhgr vhhishdqtghirdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhho nhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF2A2306467E; Wed, 4 Nov 2020 16:02:56 -0500 (EST) From: Thomas Monjalon To: David Christensen Cc: dev@dpdk.org, anatoly.burakov@intel.com, david.marchand@redhat.com Date: Wed, 04 Nov 2020 22:02:55 +0100 Message-ID: <1866859.44BVCP9YqW@thomas> In-Reply-To: <45613e0e-7824-d976-9dd0-ffc74513dc88@linux.vnet.ibm.com> References: <20201015172305.105717-1-drc@linux.vnet.ibm.com> <4042743.04XgZqB5lT@thomas> <45613e0e-7824-d976-9dd0-ffc74513dc88@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/1] vfio: modify spapr iommu support to use static window sizing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/11/2020 22:00, David Christensen: >=20 > On 11/4/20 11:43 AM, Thomas Monjalon wrote: > >> Signed-off-by: David Christensen > >> Acked-by: Anatoly Burakov > >> --- > >> -#ifdef VFIO_IOMMU_SPAPR_INFO_DDW > >> - /* try possible page_shift and levels for workaround */ > >> + /* if at first we don't succeed, try more levels */ > >> uint32_t levels; > >> =20 > >> - for (levels =3D create->levels + 1; > >> + for (levels =3D create.levels + 1; > >> ret && levels <=3D info.ddw.levels; levels++) { > >=20 > > There is a compilation failure with ppc64le-power8-linux-gcc: > > error: =E2=80=98struct vfio_iommu_spapr_tce_info=E2=80=99 has no member= named =E2=80=98ddw=E2=80=99 >=20 > How did you find that error? It builds locally for me on a POWER system= =20 > with Meson/gcc and there were no build failures on Travis=20 > (https://travis-ci.com/github/drchristensen/dpdk/builds/198047029) when=20 > I checked it against AMD64/ARM systems. The code is PPC specific but it= =20 > will build on all architectures (there are no IFDEFs around it). Remember, I cross-build with test-meson-builds.sh Is it an issue of my toolchain?