From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F0540271; Tue, 4 Jul 2017 17:53:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6A85D209AF; Tue, 4 Jul 2017 11:53:55 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 04 Jul 2017 11:53:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=C197qDjbepGR4hI fgqSUKbe0zboRpRgpHgrwGX6vEDg=; b=iNkwmLVNARRnGQ0uuBIpte9VHHv76Co uC5HRRvSJMu3pw1kjOkCe/giiAMnUK4PoRQkyUAXoT4gAGnlaLVfb5ppd/ATt2aC aR0n14JCJnPeIe3SfDvLcvsewGwOEN7tx0a5yAEvwg76gYvkYiXZ6KXaDDNZ01Ti 18hQWr0Me3Mk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=C197qDjbepGR4hIfgqSUKbe0zboRpRgpHgrwGX6vEDg=; b=KmVjU2Hj Zj1TU2Wl8DSW+bp6qBumZhNw+GNAmiEdb1mGX9NgqS8uOo7rX7XEtAdEHtiHCuDE Bn0RSUlnqGe+SqeteP1rf+Cg8sIaqS88dhWzbvSNvJomJpFu07qDcQl6duZ9Bv6m UB09z6d9MM5beuNmrj3YVIiIdAgYQ4IyMmxYpml0qVg/Gs8vI5l+6+8KBhIj/77O a56IqWbtA+2M31ZlfIqB5ECi+eziX5Nl0DzABzkAJt0gdpVbqmO6XSL2zO5/MMCW 3woeblW6zaj/5wwpVd61r9Na+YvVQ99usbbpuXO01aYA6c6cgkcqPyRFZ/yNRDQS xLGB50XeVRie3Q== X-ME-Sender: X-Sasl-enc: VX5XXW22MVjs4io/FuqefOjt016m7jYZv3oAj81QRWb6 1499183635 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E5257E881; Tue, 4 Jul 2017 11:53:55 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: stable@dpdk.org, Jan Blunck , dev@dpdk.org, Ilya Matveychikov , Adrien Mazarguil , sergio.gonzalez.monroy@intel.com, santosh.shukla@caviumnetworks.com Date: Tue, 04 Jul 2017 17:53:54 +0200 Message-ID: <1867099.27613Eycdk@xps> In-Reply-To: References: <20170609082937.21294-1-olivier.matz@6wind.com> <20170703100407.21790-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: don't advertise a physical address when no hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 15:53:56 -0000 03/07/2017 12:17, Jan Blunck: > On Mon, Jul 3, 2017 at 12:04 PM, Olivier Matz wrote: > > When populating a mempool with a virtual memory area, the mempool > > library expects to be able to get the physical address of each page. > > > > When started with --no-huge, the physical addresses may not be available > > because the pages are not locked in memory. It sometimes returns > > RTE_BAD_PHYS_ADDR, which makes the mempool_populate() function to fail. > > > > This was working before the commit cdc242f260e7 ("eal/linux: support > > running as unprivileged user"), because rte_mem_virt2phy() was returning > > 0 instead of RTE_BAD_PHYS_ADDR, which was seen as a valid physical > > address. > > > > Since --no-huge is a debug function that breaks the support of physical > > drivers, always set physical addresses to RTE_BAD_PHYS_ADDR in memzones > > or in rte_mem_virt2phy(), and ensure that mempool won't complain in that > > case. > > > > Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user") > > > > CC: stable@dpdk.org > > Signed-off-by: Olivier Matz > > Reviewed-by: Jan Blunck Applied, thanks