From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E85E4A0032; Thu, 12 May 2022 12:00:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C806240E64; Thu, 12 May 2022 12:00:30 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id BA66B4014F for ; Thu, 12 May 2022 12:00:28 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E432782; Thu, 12 May 2022 13:00:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E432782 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1652349628; bh=M9rJa8fxVUfah2vjdJt7S3oE/m9uoRheRzNhD2DGUKk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hcc5SsWGs76WSm1revb+9+3o/XWiHMn8PSniH2qmBT0skBwa/nLcrfan715GabGmb vyuB5OFssoFvCDR51ltqgU95OCGQxUlHjmh6uT/hfQYmDsNk8LvUWjSU/LR065vxt/ CO9OS/c64jNCTd12Q9qFtjZGacBAZ9q0boREYu2g= Message-ID: <1867f143-2726-66ec-5015-933136d5f72a@oktetlabs.ru> Date: Thu, 12 May 2022 13:00:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 06/10] net/axgbe: adjust retval when xstats is null of get xstats Content-Language: en-US To: Chengwen Feng , thomas@monjalon.net, ferruh.yigit@xilinx.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com Cc: mb@smartsharesystems.com, stephen@networkplumber.org, dev@dpdk.org References: <20220416010747.40714-1-fengchengwen@huawei.com> <20220505080233.12737-1-fengchengwen@huawei.com> <20220505080233.12737-7-fengchengwen@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220505080233.12737-7-fengchengwen@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/5/22 11:02, Chengwen Feng wrote: > Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0) > to retrieve the required number of elements, but currently axgbe PMD > returns zero when xstats is NULL. > > This patch adjusts that the return value was the required number of > elements when stats is NULL. > > Fixes: 9d1ef6b2e731 ("net/axgbe: add xstats") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- > drivers/net/axgbe/axgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c > index 951da5cc26..f6a3a52430 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.c > +++ b/drivers/net/axgbe/axgbe_ethdev.c > @@ -1014,7 +1014,7 @@ axgbe_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats, > unsigned int i; > > if (!stats) I think the right condition is: n < AXGBE_XSTATS_COUNT Otherwise the function break contract to return required number of xstats if space is insufficient. > - return 0; > + return AXGBE_XSTATS_COUNT; > > axgbe_read_mmc_stats(pdata); >