From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 521C958C8 for <dev@dpdk.org>; Mon, 3 Oct 2016 16:21:31 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id p138so154175538wmb.1 for <dev@dpdk.org>; Mon, 03 Oct 2016 07:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=t3uNdRUtB7yVCmtI+yAhqwbYDmvA3RMH+Uq6KYeLKmM=; b=swjwtzVjwsi/C7Vw0KlYkUu/74eXSAZSEreSyIEb4hyGgDWN4kgUkTOVWr/XKWVkMJ 5tPgKu8IpfrfFJsE5RZ/a/F5NERRnBt40OSTjnHnw+3zDaJQm5okIXhZ+nvjXiIzW30O jQMLqmewJZ15LhhiSpbP+DpTwevUv4csg1PVSEYqHg++YovhbrrVj49N+tj/wl0N/Axm GTsKWSg9tF5haPDTnjOJKQtvmlzLDVGzuVurkh0lvEIXpGsHI/Eo9uLltih4mZRsIuL4 U7A9LnoJxhoXhb2GeERKhOO8Y+CylxZFl5+4Rf6QHzxPHJhYxPdL5fBIpGMoaHznuFh9 Elkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=t3uNdRUtB7yVCmtI+yAhqwbYDmvA3RMH+Uq6KYeLKmM=; b=R33Dvbf9ZYNYzP2GLGbRmEiGud0ebXmqOy4mDIQ+zonhz+LWUYAX4/4lpxKF4LFNqP FDT7jHRgJ/bkvDoxonJNjGbgJZ+NnKH10Rlda2bIbGUeRYL/7S69YlDAZ4r6FlWDs71m jkZUxjdqdCN/mH6txHyem/rsQmrT1zUOXZERKlDqRfxIaLmGC7od/4ziNKs2l3fC38Wb vdRIEA8kjH7jYhL6nF172ss5DYrOfjlNXKxaVgfCMEewxC9868tfaU33kB14q6AdYpAR lkU4Yb/qf1SJwgKSydi4DiI1cTSAt9ZLIU+4Bn2X+FiaQ8QDFF4OHEO5rDnWLEZCe2Df 0Z1w== X-Gm-Message-State: AA6/9Rl3/XvHwr4cZywzlqfra4D3mJfWXOhiU6YM9TrFxdRoRK5K613Pr0GMtLg1rwPjkDRI X-Received: by 10.28.87.16 with SMTP id l16mr9321958wmb.75.1475504490376; Mon, 03 Oct 2016 07:21:30 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i78sm19176538wmc.13.2016.10.03.07.21.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 07:21:29 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Shreyansh Jain <shreyansh.jain@nxp.com> Cc: dev@dpdk.org, viktorin@rehivetech.com, David Marchand <david.marchand@6wind.com>, hemant.agrawal@nxp.com Date: Mon, 03 Oct 2016 16:21:28 +0200 Message-ID: <1868462.9szsyjFR7X@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1474375296-26078-8-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-8-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 07/24] driver: probe/remove common wrappers for PCI drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 03 Oct 2016 14:21:31 -0000 2016-09-20 18:11, Shreyansh Jain: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -4372,6 +4372,19 @@ rte_eth_dev_get_port_by_name(const char *name, uint8_t *port_id); > int > rte_eth_dev_get_name_by_port(uint8_t port_id, char *name); > > +/** > + * Wrapper for use by pci drivers as a .probe function to attach to a ethdev > + * interface. > + */ > +int rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev); > + > +/** > + * Wrapper for use by pci drivers as a .remove function to detach a ethdev > + * interface. > + */ > +int rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev); These functions are used by the drivers only (as helpers). So they should be marked @internal (added after applying the patch).