From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, "Stojaczyk,
DariuszX" <dariuszx.stojaczyk@intel.com>,
"Yao, Lei A" <lei.a.yao@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mem: fix alignment of requested virtual areas
Date: Wed, 18 Jul 2018 23:23:22 +0200 [thread overview]
Message-ID: <1869059.f4TMTciHnY@xps> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A84619E9B7@HASMSX106.ger.corp.intel.com>
17/07/2018 11:48, Stojaczyk, DariuszX:
> From: Burakov, Anatoly
> >
> > The original code did not align any addresses that were requested as
> > page-aligned, but were different because addr_is_hint was set.
> >
> > Below fix by Dariusz has introduced an issue where all unaligned addresses
> > were left as unaligned.
> >
> > This patch is a partial revert of
> > commit 7fa7216ed48d ("mem: fix alignment of requested virtual areas")
> >
> > and implements a proper fix for this issue, by asking for alignment in all
> > but the following two cases:
> >
> > 1) page size is equal to system page size, or
> > 2) we got an aligned requested address, and will not accept a different one
> >
> > This ensures that alignment is performed in all cases, except for those we
> > can guarantee that the address will not need alignment.
> >
> > Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
> > Fixes: 7fa7216ed48d ("mem: fix alignment of requested virtual areas")
> > Cc: dariuszx.stojaczyk@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Acked-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-07-18 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 14:57 Anatoly Burakov
2018-07-16 15:20 ` Yao, Lei A
2018-07-17 9:48 ` Stojaczyk, DariuszX
2018-07-18 21:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1869059.f4TMTciHnY@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).