From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D585323C;
Wed, 18 Jul 2018 23:23:45 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 52D8321C7A;
Wed, 18 Jul 2018 17:23:45 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 18 Jul 2018 17:23:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=kldZFK5NFNn3Enc96bjHUW1PNj
eUUj3fDbyluLfFo24=; b=kAiedSPwBT07KfScmYeIdijVmEAYop1G8moy1vSset
Eoo7iASZgBkLYnnmuE0ZImZ4des6RTPR9KaHyjdYMzLOWw03dQ8KU2hyWSV7q7ZZ
cun1Np0s2A58/BjUBj3Lw1A5oB405P7WaCg1rzmUhv69sv6Ko7IsCx3tzklEX0sW
k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kldZFK
5NFNn3Enc96bjHUW1PNjeUUj3fDbyluLfFo24=; b=ABGERNG9Qz+zQQD9DvFWn7
Ow/s/NTAZbvasYJHWBrMSNiHskEHuq5wra4thCHiAJ1V2ymOD3nA2dCBZ9n8b98e
7OshxK1SvpYknrOFjv+T8FCoYfUg/sNs+F8HXLU3aIqx8C6iVLvmTrP0xTXVb1jn
7vkTkYoq7jw9K9yMVhJLI/NjVFQbz74dm8W4zwkeTbAqbL4kpb52C1D7EoH7p0wJ
Yp8VK+tF2DCoqw8FbQrG67f9aTK7RCm7SNGM9TSNhWyeB8sjftsGqPXRNvqEp0Pz
KqN+lpZRJPmgO3pD1tTVhwEbw/+hFpX0d7JAenkoFUjzDIZrD7go2DfxyeZSWKWQ
==
X-ME-Proxy: <xmx:4a9PWyaF6fAwIj-sKoXbxRDH6vOQRU-VJahP8GjBZR-3-4bfJAzG4w>
<xmx:4a9PW6N5yUZjsUMRbNIw0wB8QTmpBzPLXmOAN0wTjH2Z8nerx57eWA>
<xmx:4a9PW--NPSJphafdz-jdmTEmLVwTIuqWRV5TlVyQ7Xq7JdgFpQeuKQ>
<xmx:4a9PW9sRC69y3AOglWgz35q4hSn42eIvNKkvfTNO73ky-uZvZEi0Lw>
<xmx:4a9PWwR9Ek6o4V2eBwdUKVbRoxUdpG714dlo8z_cMQAuk4wj2WmbDw>
<xmx:4a9PW1Ve-jPWoVQB--ajFUOm8VTmVEKDfPzAcsUivrXmvCgZBMAODA>
X-ME-Sender: <xms:4a9PW9Mr0nGlzg_HXW_AKk1DaVkBJOh0bgPFAxoB0Qq3tEfVUVhZig>
Received: from xps.localnet (unknown [37.168.67.16])
by mail.messagingengine.com (Postfix) with ESMTPA id E146710261;
Wed, 18 Jul 2018 17:23:42 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, "Stojaczyk, DariuszX" <dariuszx.stojaczyk@intel.com>, "Yao,
Lei A" <lei.a.yao@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Date: Wed, 18 Jul 2018 23:23:22 +0200
Message-ID: <1869059.f4TMTciHnY@xps>
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A84619E9B7@HASMSX106.ger.corp.intel.com>
References: <1e4e38f022da0d791b454b8d9cddce61b479b7ad.1531752592.git.anatoly.burakov@intel.com>
<FBE7E039FA50BF47A673AD0BD3CD56A84619E9B7@HASMSX106.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] mem: fix alignment of requested virtual areas
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jul 2018 21:23:46 -0000
17/07/2018 11:48, Stojaczyk, DariuszX:
> From: Burakov, Anatoly
> >
> > The original code did not align any addresses that were requested as
> > page-aligned, but were different because addr_is_hint was set.
> >
> > Below fix by Dariusz has introduced an issue where all unaligned addresses
> > were left as unaligned.
> >
> > This patch is a partial revert of
> > commit 7fa7216ed48d ("mem: fix alignment of requested virtual areas")
> >
> > and implements a proper fix for this issue, by asking for alignment in all
> > but the following two cases:
> >
> > 1) page size is equal to system page size, or
> > 2) we got an aligned requested address, and will not accept a different one
> >
> > This ensures that alignment is performed in all cases, except for those we
> > can guarantee that the address will not need alignment.
> >
> > Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
> > Fixes: 7fa7216ed48d ("mem: fix alignment of requested virtual areas")
> > Cc: dariuszx.stojaczyk@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Acked-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Applied, thanks