[dpdk-dev] [PATCH] net/mlx5: fix Windows port spawn

[dpdk-dev] [PATCH] net/mlx5: fix Windows port spawn

[Gregory Etelson]

mlx5_dev_check_sibling_config() API was updated to allow newly spawned
port locate existing sibling devices.
PMD port initialization for Windows OS was not updated for the new
API prototype.
The patch fixes mlx5_dev_check_sibling_config call for Windows OS.

Fixes: e9d420dfc2d0 ("net/mlx5: fix find sibling devices")

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/windows/mlx5_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c
index 5518bc3e76..7e1df1c751 100644
--- a/drivers/net/mlx5/windows/mlx5_os.c
+++ b/drivers/net/mlx5/windows/mlx5_os.c
@@ -454,7 +454,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
 	}
 	/* Override some values set by hardware configuration. */
 	mlx5_args(config, dpdk_dev->devargs);
-	err = mlx5_dev_check_sibling_config(priv, config);
+	err = mlx5_dev_check_sibling_config(priv, config, dpdk_dev);
 	if (err)
 		goto error;
 	DRV_LOG(DEBUG, "counters are not supported");
-- 
2.32.0

Re: [dpdk-dev] [PATCH] net/mlx5: fix Windows port spawn

[Thomas Monjalon]

05/08/2021 11:55, Gregory Etelson:
> mlx5_dev_check_sibling_config() API was updated to allow newly spawned
> port locate existing sibling devices.
> PMD port initialization for Windows OS was not updated for the new
> API prototype.
> The patch fixes mlx5_dev_check_sibling_config call for Windows OS.
> 
> Fixes: e9d420dfc2d0 ("net/mlx5: fix find sibling devices")
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Adding the compilation log:
drivers/net/mlx5/windows/mlx5_os.c:457:50: error:
too few arguments to function call, expected 3, have 2
	err = mlx5_dev_check_sibling_config(priv, config);

Changing title to "net/mlx5: fix build on Windows"

I missed the original CI failure in patchwork, sorry.

Applied, thanks.