From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA783A0524; Mon, 19 Apr 2021 19:14:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DBB4413B0; Mon, 19 Apr 2021 19:14:14 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 898EB41390 for ; Mon, 19 Apr 2021 19:14:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 258E65C01E7; Mon, 19 Apr 2021 13:14:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 13:14:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= C6rS1iTPs145SkJILF9L5CmvWM87IOSPVsGgQvETuy8=; b=0VBTsRbQH6J8jJ8R P+oCIBGnIGEc0niee5HX/as2z5kDPoUx74MAkZTVX4aS2DtnYe3dDwRXPBIR87Vn L4JzN/T+hOphw51S6yM/+IY5dznVLcIFI9dzxnLoFFaDvN7ZGsfMvVgTMTBf1TZv CECTLQpvY6eGFWN7LJfZjhl0vFLWvmBFM73hGEeNNmUCKDC+mQ9OCPAu+UZskx4s T3499Jz+aj5nzgDaJsNAd2rh6sJ8lBrtCiDkZVU6ai0gGVaPhHRD3wO983iyrYtO a/QjfAQr896k9Yvqm53YczGjBvBEsVEaKEUTHeoBuPZi0Mtbza4P8yfVBMwOMXfM pXBKJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=C6rS1iTPs145SkJILF9L5CmvWM87IOSPVsGgQvETu y8=; b=jjtLSzeoMYneKCbvRaXQx+nNKb1vLb3WmvSOPruEdY4FGJUoaKOzQ0yOo QGAAH7MJLXHU5jjlMcacKPlMwYCJJEFxdijZO5F/TPYifnCqUbyN/wOWffaq/aT5 pCPFwO7RQC8nA1nlqcXd5vVhhXl8pz+QDbDPkfTkJgdQSJBSyURA+lTn9eZjni0l 4yL8k8nrtQa0g9l9m9HoI23Hqfn5o6cBYoVdh9BzA0jgY6Tmz9BCIrppXuq6nqnq ZtOJS3IVlkpJ0nRlqnZ1/YkNIr5WIgNiw118DYXkvhHt8OuqsRwo21SYWt5PngWh mANgOPFxcwgrsYWlzLqeHVzZLvGBA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 23BC1108005B; Mon, 19 Apr 2021 13:14:11 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, suanmingm@nvidia.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Date: Mon, 19 Apr 2021 19:14:08 +0200 Message-ID: <1869905.GZgYhOu6rl@thomas> In-Reply-To: <20210315192722.35490-2-stephen@networkplumber.org> References: <20210315192722.35490-1-stephen@networkplumber.org> <20210315192722.35490-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" About the title, better to say "multi-process" and do not commit on being completely safe for the whole API. It is just fixing the mutex for multi-process, and this mutex is for driver not being natively multi-thread. The compilation fails on MinGW: error: implicit declaration of function =E2=80=98pthread_mutexattr_init=E2= =80=99 15/03/2021 20:27, Stephen Hemminger: > Posix mutex are not by default safe for protecting for usage > from multiple processes. The flow ops mutex could be used by > both primary and secondary processes. >=20 > Bugzilla ID: 662 > Signed-off-by: Stephen Hemminger > Fixes: 80d1a9aff7f6 ("ethdev: make flow API thread safe") > Cc: suanmingm@nvidia.com These lines must be sorted. Please use --cc-cmd devtools/get-maintainer.sh so that maintainers are Cc'ed. Adding Ferruh and Andrew.