* [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist
@ 2016-05-31 2:40 xu,huilong
2016-05-31 6:34 ` Thomas Monjalon
2016-06-07 1:47 ` Lu, Wenzhuo
0 siblings, 2 replies; 4+ messages in thread
From: xu,huilong @ 2016-05-31 2:40 UTC (permalink / raw)
To: dev; +Cc: thomas.monjalon, xu,huilong
maybe we should change log level, when add port in blacklist,for check it easy.
and it not influence performance and function
Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
lib/librte_eal/common/eal_common_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 3cae4cb..154bac5 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -172,7 +172,7 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
/* no initialization when blacklisted, return without error */
if (dev->devargs != NULL &&
dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
- RTE_LOG(DEBUG, EAL, " Device is blacklisted, not initializing\n");
+ RTE_LOG(INFO, EAL, " Device is blacklisted, not initializing\n");
return 1;
}
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist
2016-05-31 2:40 [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist xu,huilong
@ 2016-05-31 6:34 ` Thomas Monjalon
2016-06-07 1:47 ` Lu, Wenzhuo
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-05-31 6:34 UTC (permalink / raw)
To: xu,huilong; +Cc: dev
2016-05-31 10:40, xu, huilong:
> maybe we should change log level, when add port in blacklist,for check it easy.
> and it not influence performance and function
Please, could you show an example of the device init logs at INFO level
before and after this patch?
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist
2016-05-31 2:40 [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist xu,huilong
2016-05-31 6:34 ` Thomas Monjalon
@ 2016-06-07 1:47 ` Lu, Wenzhuo
2016-06-30 12:02 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Lu, Wenzhuo @ 2016-06-07 1:47 UTC (permalink / raw)
To: Xu, HuilongX, dev; +Cc: thomas.monjalon, Xu, HuilongX
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Tuesday, May 31, 2016 10:40 AM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Xu, HuilongX
> Subject: [dpdk-dev] [PATCH v1] change log level for check when add port in
> blacklist
>
> maybe we should change log level, when add port in blacklist,for check it easy.
> and it not influence performance and function
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Considering the usability, prefer to show the log to users.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist
2016-06-07 1:47 ` Lu, Wenzhuo
@ 2016-06-30 12:02 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-06-30 12:02 UTC (permalink / raw)
To: Xu, HuilongX; +Cc: dev, Lu, Wenzhuo
2016-06-07 01:47, Lu, Wenzhuo:
> > maybe we should change log level, when add port in blacklist,for check it easy.
> > and it not influence performance and function
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Considering the usability, prefer to show the log to users.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-30 12:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-31 2:40 [dpdk-dev] [PATCH v1] change log level for check when add port in blacklist xu,huilong
2016-05-31 6:34 ` Thomas Monjalon
2016-06-07 1:47 ` Lu, Wenzhuo
2016-06-30 12:02 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).