From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 04D8F5946 for ; Thu, 30 Jun 2016 18:25:28 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id r201so126438597wme.1 for ; Thu, 30 Jun 2016 09:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=iKiS7lgSpcjT65Qz9uFfvAR9j4U2vsvxM2xZ2FlmnEg=; b=n3Tqr1vWSmleXwUInoY1GojZDrTG72p9ApxBZzJfO1/eXRyzfoQlIvGA/F/EbKrv8F IJEAyKvkL4ljqKDeCzCDy4e8iObJIFxBtxQQ7tNDunRqYoWvwuVkXfSaEKgZoKqe3lzB 0CtXhZeihpG5NGQ9xxxprt2TqrbAgLqhNcneA8J5YNRAdxYrlFqMKTn7pSfV1sHMATvb vFgl+ScWEuGAPHOoyYBCpr+02FB5rTY5o4zsH9zUymngW17wxuO3iUww2NGaDSjSJhOW aBgRwWHe7b+8WqEgCfyjOVLq5XxDddXPSOuHGUzR0jqKyoRXI3rCmjpdDP9225Klg+Qx as1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=iKiS7lgSpcjT65Qz9uFfvAR9j4U2vsvxM2xZ2FlmnEg=; b=PGD2GUJS1wScPtqe0Sak9XupZbY8e6apfrvXTvWS2b9mAhsfRo0Rz0iEHYs7CHmrEC hjpYyFBR2h/KyG3HHtNOSiaMCzXANIJA/I6rr9QQdp7ewMNuOJg72uS15b8VEZr6KWy4 j6nfRGTn5t/rszmVSoOhQhQRMzeUCIsneLXutAspSZSJPVBNKyrDBcyzP1yp4uLPuBpK 8LqeuLKjDYLGzUZkTvBhx4Gy4xPF/DxQcCu4MkoXRSpcBK9N1j3D+sI88dgTiqAaYyZw e4C5kOIDzoDosQ2CRqtQ2hQfs+dCVbPC+kDlfHLnM7gPVmYa9PcIxVP8MoM0CA7OVtWo morw== X-Gm-Message-State: ALyK8tInfuzmGSScB1oUrkmk0Y9gaM7BUy7UXpTmPMHGBxhdXZck9dPk9Nm3yjkVl0qabfjt X-Received: by 10.28.143.212 with SMTP id r203mr27191458wmd.35.1467303927793; Thu, 30 Jun 2016 09:25:27 -0700 (PDT) Received: from xps13.localnet (188.20.90.92.rev.sfr.net. [92.90.20.188]) by smtp.gmail.com with ESMTPSA id w76sm4450808wmd.11.2016.06.30.09.25.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 09:25:26 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Thu, 30 Jun 2016 18:22:31 +0200 Message-ID: <1872534.DI0OsGElcv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com> <2826363.SrA66T9uvx@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 16:25:28 -0000 2016-06-30 17:14, Sergio Gonzalez Monroy: > On 30/06/2016 17:10, Thomas Monjalon wrote: > > 2016-06-30 17:01, Sergio Gonzalez Monroy: > >> --- a/mk/rte.app.mk > >> +++ b/mk/rte.app.mk > >> @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM) += -lrte_lpm > >> -_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += -lrte_jobstats > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) += -lrte_power > >> > >> _LDLIBS-y += --whole-archive > >> > >> +# librte_acl needs --whole-archive because of weak functions > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH) += -lrte_hash > >> _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lrte_vhost > > I was suggesting to keep -lrte_acl at the same place in the group of > > algorithms libraries, in order to keep an order satisfying this comment: > > # Order is important: from higher level to lower level > > > > But I have not tested if --whole-archive -lrte_acl --no-whole-archive works. > > > > Sorry, I missed that. > > Why is important being before jobstats and power? It is not. But I think we need to have some groups. And ACL is probably at the same layer level as lpm, sched, etc.