From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 6D4E64A65 for ; Thu, 23 Feb 2017 09:45:29 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id v77so5247132wmv.0 for ; Thu, 23 Feb 2017 00:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=sF836lgQWpIW8FqcTv2mzBiuEtSEqaT0T8ZfbJCI9F4=; b=1IaHj3fx3jh3rXQ/94kUm07k4g5dg1GV/f8GDTHghTJaYO3Tl47Z9WNjNx44paSdlf U99qCRy4JqO8eSKQOMlZ2bpPPO+F4XpfTFbxyiPF/Xsgc2EjOKd2kaTBjpy8fu2Soi9B Bl0cKJXfopZNvAvIkH2ur8XB5WWG8FWX9IxHo9nL4nnmrQlBJamI4Wqf4R00EUPvMvnM nGtkygktbB5hY06CoGDXdgeY4kY5r6y4sOECldMN8Rep0m7Uebdk1kylwk923Dc0l79B 1RFVRpe465uKivbojvHdPbXhBWx2ANWU5A3P5ZpPux+QoCcMEDc9phIqq5deNvGOf2lL hzpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=sF836lgQWpIW8FqcTv2mzBiuEtSEqaT0T8ZfbJCI9F4=; b=Z8m9L9vcZOPWI52VPRlqbwUrZM5yFopwZ4sgar6SDOXgy1ELp/RbxRQ39KgAANMwcw H6rQq6R8n3EHxAl0IPfbvPxamDOD6LAbpOwfuL+jKMo7fDKjHmAw19YG4jjnomP0CBEC 1+oDPPd4Soo7y1wc0+f5082slzJZGi2vtsYbxRL7EsE7bcRaZn80x3FP0FGe4KB/NKLD pmygezn8aG1cANts6RBX3TuIcnGu5YaTLwaXtnotmuDsMm/OglYRawHyL9N6orM5Q+bx FjBVW+fhYlm8DES7NGscbeGAL1GqKox4F2vOgh0AaPZFDlBnhxM6KCHvucxhlvdP4Zyg 46oA== X-Gm-Message-State: AMke39lYEYzgRe+G1jl9HN6ohd+sLXQwKm9iPQFNmpo5KalsbUjwqjL/bvoQSvRZn61i/XWa X-Received: by 10.28.37.195 with SMTP id l186mr2894582wml.73.1487839529174; Thu, 23 Feb 2017 00:45:29 -0800 (PST) Received: from xps13.localnet (112.204.154.77.rev.sfr.net. [77.154.204.112]) by smtp.gmail.com with ESMTPSA id u198sm5872488wmf.9.2017.02.23.00.45.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Feb 2017 00:45:28 -0800 (PST) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Thu, 23 Feb 2017 09:45:27 +0100 Message-ID: <1873092.o3R52VP9cS@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1486118019-2280-1-git-send-email-remy.horton@intel.com> <2924793.QDCoddA1K3@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 0/7] Expanded statistics reporting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 08:45:29 -0000 2017-02-23 07:09, Remy Horton: > > On 16/02/2017 10:53, Thomas Monjalon wrote: > > 2017-02-03 10:33, Remy Horton: > [..] > > I think there are three remaining questions: > > - When the metrics computation are done? (in which thread?) > > Actual calculation is not done by libmetrics itself - it only handles > distribution. Calculation is done prior to the calculated values being > passed to rte_metrics_update_value*(), so the thread that does the > calculation is a decision for the application. Of course computation is not done in libmetrics. The question was about its integration in the application and the perfromance impact. Should it be in the dataplane threads or in separate threads? > > - May the few lines of computation code be done differently when tightly > > integrated in an application logic? > > Yes, since it is the application itself (or in the case of bit-rate, a > separate library) that does the calculation. The question was more about the cache misses with this library. > > - Could it be hosted in a separate repository on dpdk.org? > > That's part of a broader discussion on how DPDK is packaged. And specifically for these metrics libraries, do you agree it could be packaged separately?