From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4B7151B04D for ; Wed, 1 Aug 2018 17:52:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D587521ADE; Wed, 1 Aug 2018 11:52:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 01 Aug 2018 11:52:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lRXik7sgV4EWcihCUSRvd1uulQ TXTxF6FiaIXYPPPWc=; b=jjsLovOC7FjUh8WhGgLFnz1WC6UIuXLtUNOCwuDzY0 H0YSRaYBc46t9bvBJwchuP9nyqEwkEm8v+xbVJzMn99h96StjWYD/T+vYLUzKilS EqZoCmupDas1Gyt39bIQxgr1KmjgipoZyPtPr6slG1TfqPJMWL3vH+CplTDlvX+W 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lRXik7 sgV4EWcihCUSRvd1uulQTXTxF6FiaIXYPPPWc=; b=EmhOCWcYqHyam8b+FZyOa0 AXmYxQqCYnFQOUmdDlR8vDL/+g9mUfuGq9PXqtK2KtvvtmvpfCnzhQt4a/yfZ0zf JNHdMsr5SQshofCT8y5V0hSBtSkNjcL0GA9cMb9QtbaePfWB81BDex+HFioj4zRk YBvPIm+2lgulEMBhg8rTAG3FVeDSt4UK/v31r6quvPEXiIUP/+9LqG8qmWMGroBT DkUnAlbSyRI8P11zbhYmwzhrXDjMMA1JPJQnt6mWMFOj8mWFApGO5QpZTUeI2sCo 3zQHfxlcroIrNxOC8+Qtvu3+TUe6EGYBq7W/aCX8vRHn9LRSuu7aymmV/iKaQy/g == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2B1141025D; Wed, 1 Aug 2018 11:52:41 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Jerin Jacob , t.yoshimura8869@gmail.com Date: Wed, 01 Aug 2018 17:52:36 +0200 Message-ID: <1874201.M8Nbpmf09E@xps> In-Reply-To: <20180731034740.GA3371@jerin> References: <4107730371de4ac30367258cb3419df184d1ec16.1532947452.git.anatoly.burakov@intel.com> <20180731034740.GA3371@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: revert retry logic for MSI-X BAR mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 15:52:43 -0000 > > This reverts commit d4774a568ba0a5923229974a002972c83eb04570. > > > > The patch is incomplete because kernel 4.16+, while being capable > > of mapping MSI-X BARs, will also report if such a capability is > > available. Without checking this capability, gratuitous errors > > are displayed on kernels <4.16 while VFIO is attempting to mmap > > MSI-X BAR and fails, which can be confusing to the user. > > > > Signed-off-by: Anatoly Burakov > > Acked-by: Jerin Jacob Applied, thanks