From: Thomas Monjalon <thomas@monjalon.net>
To: Ray Kinsella <mdr@ashroe.eu>
Cc: dev@dpdk.org, arkadiuszx.kusztal@intel.com,
bruce.richardson@intel.com, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] doc: fix references to bind_default_symbol
Date: Mon, 18 May 2020 18:54:02 +0200 [thread overview]
Message-ID: <1875925.ZhSLo9btvA@thomas> (raw)
In-Reply-To: <1588779668-1522-1-git-send-email-mdr@ashroe.eu>
06/05/2020 17:41, Ray Kinsella:
> The document abi_versioning.rst incorrectly instructs the developer to
> add BIND_DEFAULT_SYMBOL to the public header, not the source file. This
> commit fixes the issue and adds some clarifications.
>
> The commit also clarifies the use of use_function_versioning in the
> meson/ninja build system, and does some minor re-organization of the
> document.
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> ---
> v3:
> * added a note to ask contributors to ensure they review the meson/ninja
> section when adding "rte_function_versioning.h".
Fixes: f1ef9794f9bd ("doc: add ABI guidelines")
Cc: stable@dpdk.org
Applied with few typos fixed, thanks.
prev parent reply other threads:[~2020-05-18 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 17:49 [dpdk-dev] [PATCH v1] " Ray Kinsella
2020-05-06 8:26 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
2020-05-06 15:41 ` [dpdk-dev] [PATCH v3] " Ray Kinsella
2020-05-18 16:54 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1875925.ZhSLo9btvA@thomas \
--to=thomas@monjalon.net \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).