[dpdk-dev] [PATCH] net/e1000: fix vf received problem

[dpdk-dev] [PATCH] net/e1000: fix vf received problem

[Qiming Yang]

VF default MAC address be added in PF Mac address list
instead of VF MAC address list, makes VF can't recieve
packets. This patch fixes this issue.

Fixes: be2d648a2dd3 ("igb: add PF support")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/e1000/igb_pf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c
index 67da3c2..1a70ad5 100644
--- a/drivers/net/e1000/igb_pf.c
+++ b/drivers/net/e1000/igb_pf.c
@@ -338,6 +338,9 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
 			rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,
 				sizeof(vfinfo[vf].vf_mac_addresses));
 		hw->mac.ops.rar_set(hw, new_mac, rar_entry);
+		int rah = E1000_READ_REG(hw, E1000_RAH(rar_entry));
+		rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));
+		E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah);
 		return 0;
 	}
 	return -1;
-- 
2.7.4

Re: [dpdk-dev] [PATCH] net/e1000: fix vf received problem

[Lu, Wenzhuo]

Hi Qiming,


> -----Original Message-----
> From: Yang, Qiming
> Sent: Thursday, April 27, 2017 1:07 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org; Yang, Qiming
> Subject: [PATCH] net/e1000: fix vf received problem
> 
> VF default MAC address be added in PF Mac address list instead of VF MAC
> address list, makes VF can't recieve packets. This patch fixes this issue.
> 
> Fixes: be2d648a2dd3 ("igb: add PF support")
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  drivers/net/e1000/igb_pf.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index
> 67da3c2..1a70ad5 100644
> --- a/drivers/net/e1000/igb_pf.c
> +++ b/drivers/net/e1000/igb_pf.c
> @@ -338,6 +338,9 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev,
> uint32_t vf, uint32_t *msgbuf)
>  			rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,
>  				sizeof(vfinfo[vf].vf_mac_addresses));
>  		hw->mac.ops.rar_set(hw, new_mac, rar_entry);
> +		int rah = E1000_READ_REG(hw, E1000_RAH(rar_entry));
Looks a little weird to define rah here. Would you like to move it to the beginning? Thanks.

> +		rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));
> +		E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah);
>  		return 0;
>  	}
>  	return -1;
> --
> 2.7.4

[dpdk-dev] [PATCH v2] net/e1000: fix VF received problem

[Qiming Yang]

VF default MAC address be added in PF Mac address list
instead of VF MAC address list, makes VF can't receive
packets. This patch fixes this issue.

Fixes: be2d648a2dd3 ("igb: add PF support")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/e1000/igb_pf.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c
index 67da3c2..923c78a 100644
--- a/drivers/net/e1000/igb_pf.c
+++ b/drivers/net/e1000/igb_pf.c
@@ -332,12 +332,16 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
 		*(E1000_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private));
 	int rar_entry = hw->mac.rar_entry_count - (vf + 1);
 	uint8_t *new_mac = (uint8_t *)(&msgbuf[1]);
+	int rah;
 
 	if (is_unicast_ether_addr((struct ether_addr *)new_mac)) {
 		if (!is_zero_ether_addr((struct ether_addr *)new_mac))
 			rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,
 				sizeof(vfinfo[vf].vf_mac_addresses));
 		hw->mac.ops.rar_set(hw, new_mac, rar_entry);
+		rah = E1000_READ_REG(hw, E1000_RAH(rar_entry));
+		rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));
+		E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah);
 		return 0;
 	}
 	return -1;
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] net/e1000: fix VF received problem

[Lu, Wenzhuo]

Hi,

> -----Original Message-----
> From: Yang, Qiming
> Sent: Wednesday, May 3, 2017 1:52 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo; Yang, Qiming
> Subject: [PATCH v2] net/e1000: fix VF received problem
> 
> VF default MAC address be added in PF Mac address list instead of VF MAC
> address list, makes VF can't receive packets. This patch fixes this issue.
> 
> Fixes: be2d648a2dd3 ("igb: add PF support")
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/e1000: fix VF received problem

[Thomas Monjalon]

03/05/2017 09:12, Lu, Wenzhuo:
> Hi,
> 
> > VF default MAC address be added in PF Mac address list instead of VF MAC
> > address list, makes VF can't receive packets. This patch fixes this issue.
> > 
> > Fixes: be2d648a2dd3 ("igb: add PF support")
> > 
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied, thanks