From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C9802235
 for <dev@dpdk.org>; Tue, 24 Jul 2018 13:25:30 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 31B2E21AEF;
 Tue, 24 Jul 2018 07:25:30 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 24 Jul 2018 07:25:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=DBaSAxni6IuWrxz9+Dmh2Uz/y+
 kyqgEdcLQec3K1S2o=; b=WrLljmWhPnpYWjf6MS9CePwwdU0F7Ki8bwvHMusY4h
 7kB//+eRKo+7FdVihDMtkpaEotFwR5HNDQ+dBSZZ2NnchNd3E4IAhT6Uonu70LgY
 gJN8yU/LQ5zXOAjEdQfPZVzY/uq0aPyld88zxlzk+6HsukU2FjjzKAmI86YE2N1q
 o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=DBaSAx
 ni6IuWrxz9+Dmh2Uz/y+kyqgEdcLQec3K1S2o=; b=OFeGwvi0yiDsjiVbG/MSt4
 dMTutABSOZY3EdfKm8QQsugnAERCmOc8n6fEPPYHmIU7jRJonyHisM+sw5yZZJWd
 MjKvaug5pEeuhjk4MpJkw/MIzeCPSAuYDHkgf52CdqGZdxVk6z+/bbR8Oc1Lw6Pu
 EPpa7KCDWXBWhBGRbEAQYoZ+oAHqhe789sC8htQ2ykoZPf2pN0P5/QjyMXMuH4I5
 eSTCAIAuGjwqQkdKietT8wkCDueaabqNAtlRxyNJU1Qan4vCPCOXgvv6KqGfWno1
 yUUWerKnar3QRq3DZRGO8DP54/hNJH+m7Hjc3QjtDxtLHLJol/nS88oXlfDY4tQA
 ==
X-ME-Proxy: <xmx:qQxXW8D6pl0mq_x-HXPaz14UqkkFTE1b5D2ulerKxH5lU1eqDDvH6g>
 <xmx:qQxXWzuL4b6Z8wFIVRRdCSKYc1uRqgsR6hftHAtsNTFuqNO4nhdJHA>
 <xmx:qQxXWy_S7YwdWt8CPD7fqiIBTHnP8nyGn5FAFI8sh2ees86nqeVY0w>
 <xmx:qQxXWyT3is_jlYyzjRHe0Qf3t9uCdnX27wfonP8THn9TCLngrxwGLw>
 <xmx:qQxXW8Ul4Scso9OU3rDUvCNFkVltjLVcQsInVsFnUuz6R31N3jcPvw>
 <xmx:qgxXW4qMDw5tWrH4QIXA97LAlvpb5kN0SavWaq0z8-gN3tfJftTzxw>
X-ME-Sender: <xms:qQxXW065BHNzApnIr6FdJfnMWd9FQ92_hamcuyjMmCzhr9B7Ngj_5A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 97DF9E465E;
 Tue, 24 Jul 2018 07:25:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, bernard.iremonger@intel.com, reshma.pattan@intel.com,
 motih@mellanox.com, olivier.matz@6wind.com
Date: Tue, 24 Jul 2018 13:25:23 +0200
Message-ID: <1876510.4y0gDTZx5Q@xps>
In-Reply-To: <20180723104425.10090-1-jasvinder.singh@intel.com>
References: <20180723104425.10090-1-jasvinder.singh@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2018 11:25:31 -0000

23/07/2018 12:44, Jasvinder Singh:
> Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT)
> on the empty command line.

Please describe what is the issue and what is the cause.

> Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> 
> Reported-by: Mordechay Haimovsky <motih@mellanox.com>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  app/test-pmd/cmdline.c       | 10 ++++++----
>  lib/librte_cmdline/cmdline.c |  2 +-

It is very suspicious to change the cmdline library.
If there is a bug in this library, it deserves a separate fix.