From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CB676A49 for ; Mon, 29 Oct 2018 03:25:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6844421FB2; Sun, 28 Oct 2018 22:25:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 22:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BNVf35tFXZvE44NJLcgYrJN65FG6CPvBzyxrNT6Yd0Y=; b=RRO2KcW5RT3T 6UsuFR8Efr33EGXlYoTP2jAbFde9Y1Nalnpap7NzsT4cAKEKv4xe2XonC3SzqNaw t+8cZVhY5QzEBNEXmt6SGpCJ/Zma6gN0G5JZOKKHSXR3uqK0LZs69c49pRo4QKzd n1ef6/p3mOCei9BqLGVeUlW/y7trNhY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BNVf35tFXZvE44NJLcgYrJN65FG6CPvBzyxrNT6Yd 0Y=; b=Hirz6jCkRazcu5x8AuFGG2To20ib+v04vM/ZyCWclFnQyjxhQC0ZWTJ0f CDPgbQ0Kng2pIy3oxCHM15TXSqjUI6QuddHgZqP3yddUU6ulaACFzYG6+ZX/TzmM VK0tyBYh7iAFPJG1OeaqXQ3ffmdqBQKGSY6U7PsYRit5e/D9u8XFKh8X7LMuRooi 8O0SWRIk+K5n5VG2JfxjzfcmgEgPWP2QaImOJzSdXSjjC4Osd7QhmKJvnLlkmp4C Mctz/kivN5F/gD07WE7oH/lfwEMgnP/3PsuGmEMwU250CURi58WQRwqPuFkYMXc6 KJDkq6LBGG5PADxWucemsf17oxm8g== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1C8ACE4339; Sun, 28 Oct 2018 22:25:48 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, "Iremonger, Bernard" Date: Mon, 29 Oct 2018 03:25:54 +0100 Message-ID: <1877372.D2CSD47orr@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB712D@IRSMSX108.ger.corp.intel.com> References: <20180618213557.15209-1-stephen@networkplumber.org> <20180618213557.15209-2-stephen@networkplumber.org> <8CEF83825BEC744B83065625E567D7C260CB712D@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/3] testpmd: add ability to set tx IP and UDP parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 02:25:50 -0000 Hi Stephen, Please would you like to send a v4? 22/06/2018 11:12, Iremonger, Bernard: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Monday, June 18, 2018 10:36 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v3 1/3] testpmd: add ability to set tx IP and UDP > > parameters > > > > Use RFC standard values for Tx only test as defaults. > > But let the user override those values on command line. > > > > Signed-off-by: Stephen Hemminger > > --- > > > > > app/test-pmd/parameters.c | 49 +++++++++++++++++++++++++++ > > diff --git a/doc/guides/testpmd_app_ug/run_app.rst > > b/doc/guides/testpmd_app_ug/run_app.rst > > index f301c2b6f709..ae9eb712e209 100644 > > --- a/doc/guides/testpmd_app_ug/run_app.rst > > +++ b/doc/guides/testpmd_app_ug/run_app.rst > > @@ -249,6 +249,15 @@ The commandline options are: > > Set the MAC address ``XX:XX:XX:XX:XX:XX`` of the peer port N, > > where 0 <= N < ``CONFIG_RTE_MAX_ETHPORTS`` from the configuration file. > > > > + > > +* ``--tx-ip=SRC,DST`` > > A newline should be inserted after the above line to maintain the existing format of the output HTML file. > > > + Set the source and destination IP address used when doing transmit only test. > > + The defaults are source 192.18.0.1 and destination 192.18.0.2. > > + > > +* ``--tx-udp=SRC[,DST]`` > > A newline should be inserted after the above line to maintain the existing format of the output HTML file. > > > + Set the source and destination UDP port number for transmit test only test. > > + The default port is the 9 (discard). > > + > > * ``--pkt-filter-mode=mode`` > > > > Set Flow Director mode where mode is either ``none`` (the default), > > ``signature`` or ``perfect``. > > -- > > 2.17.1 > > dpdk/devtools/check-git-log.sh -1 > Wrong headline label: > testpmd: add ability to set tx IP and UDP parameters > Wrong headline lowercase: > testpmd: add ability to set tx IP and UDP parameters > > The headline label should be "app/testpmd:" > "tx" should "Tx" > > I commented on this previously. > > Regards, > > Bernard. > >