From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 117294318D; Tue, 17 Oct 2023 16:11:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97F6E40284; Tue, 17 Oct 2023 16:11:23 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 6DB7340273 for ; Tue, 17 Oct 2023 16:11:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1AC743200985; Tue, 17 Oct 2023 10:11:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 17 Oct 2023 10:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1697551880; x=1697638280; bh=oO70ZZpOkNMcCqSoSe+Qf3Ur9E83p4Zrvqo onqNwmXE=; b=wXa6sYQMs21dkb19EQcPiSjTdfDcPuAQf6VWRNpCqZ8pRHzk1f6 6zqeoaFEY5GdTxG12xcVlTVMfkY5E1WlJs8adPLb5cPGOOR1f5q5BEWXtQaD07dh zMV90/eErMWLwgvFbhvWNFU2lIV1g0uPcaRKtssfaNtGmSz2NUU2CZTuqyhh1ikz QoWcYGrr2EzLM/vDAUKVQqUyVVgSYGxic4oZU/sEZ4SaFBS3Y553FW1XmEf581l2 kTbp6YXAzCIs7qa0B4UxZaUGKO9vN2OuT+Nk7TkpmzWbK5y1Cxwcsl5SPQnVjtwB EGPr2SevgJmqy3WSOLJISNl5DIh1nvB6cDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697551880; x=1697638280; bh=oO70ZZpOkNMcCqSoSe+Qf3Ur9E83p4Zrvqo onqNwmXE=; b=hEHIDTT/JEu1Qext8w5mI/twgqKaeOogwk5/a/xvMNuG0UsI2mt 63eXNzSWiT9kwRICsjs7HNzhWg5E7W3QycC2lyBAgHMLQeObR8Jhz4uJmfNHqqR9 VzSh9vI5gtrdWv1MZbDMU/HQ4pwVwzGeTioIh6yejYWfyfvjva/teZIAY0CL3P6T kG7f+UoI71bhDxuFtWtWfO3gKV4XeF5ClwtVKF0tv2wX072sVfyTw6jQ13wXFYL9 kj8NeofmjJsY65IvI7pOUwLO/t+IObmQlJyBSzo/xdHn+1OmRHE4CODLRWuBH+Xe vFEmW7NF4JuecYUtKbMb/PLf4j/BhV4o8xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjedvgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleffteeh veduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Oct 2023 10:11:19 -0400 (EDT) From: Thomas Monjalon To: Jie Hai Cc: dev@dpdk.org, lihuisong@huawei.com, David Marchand , Ferruh Yigit Subject: Re: [PATCH 00/36] fix Rx and Tx queue state Date: Tue, 17 Oct 2023 16:11:18 +0200 Message-ID: <1877504.1xdlsreqCQ@thomas> In-Reply-To: <7aa92e38-6c57-4d33-982e-0eb151375616@amd.com> References: <20230908112901.1169869-1-haijie1@huawei.com> <7aa92e38-6c57-4d33-982e-0eb151375616@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/10/2023 13:51, Ferruh Yigit: > On 9/8/2023 12:28 PM, Jie Hai wrote: > > The DPDK framework reports the queue state, which is stored in > > dev->data->tx_queue_state and dev->data->rx_queue_state. The > > state is maintained by the driver. Users may determine whether > > a queue participates in packet forwarding based on the state, > > for example, > > > > [1] 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding" > > [2] 141a520b35f7 ("app/testpmd: fix primary process not polling all queues") > > > > Therefore, the drivers need to modify the queue state in time > > according to the actual situation, especially when dev_start > > and dev_stop are called. see [3] for more information. > > > > [3] https://inbox.dpdk.org/dev/20230721160422.3848154-1-ferruh.yigit@amd.com/ > > > > This patchset also resubmit the patch [2] and makes some fixes on the patch. > > > > Jie Hai (36): > > net/axgbe: fix Rx and Tx queue state > > net/af_packet: fix Rx and Tx queue state > > net/af_xdp: fix Rx and Tx queue state > > net/avp: fix Rx and Tx queue state > > net/bnx2x: fix Rx and Tx queue state > > net/bnxt: fix Rx and Tx queue state > > net/bonding: fix Rx and Tx queue state > > net/cxgbe: fix Rx and Tx queue state > > net/dpaa: fix Rx and Tx queue state > > net/dpaa2: fix Rx and Tx queue state > > net/e1000: fix Rx and Tx queue state > > net/ena: fix Rx and Tx queue state > > net/enetc: fix Rx and Tx queue state > > net/enic: fix Rx and Tx queue state > > net/hinic: fix Rx and Tx queue state > > net/ipn3ke: fix Rx and Tx queue state > > net/memif: fix Rx and Tx queue state > > net/mana: fix Rx and Tx queue state > > net/mlx4: fix Rx and Tx queue state > > net/mvneta: fix Rx and Tx queue state > > net/mvpp2: fix Rx and Tx queue state > > net/netvsc: fix Rx and Tx queue state > > net/nfp: fix Rx and Tx queue state > > net/ngbe: fix Rx and Tx queue state > > net/null: fix Rx and Tx queue state > > net/octeon_ep: fix Rx and Tx queue state > > net/octeontx: fix Rx and Tx queue state > > net/pfe: fix Rx and Tx queue state > > net/ring: fix Rx and Tx queue state > > net/sfc: fix Rx and Tx queue state > > net/softnic: fix Rx and Tx queue state > > net/txgbe: fix Rx and Tx queue state > > net/vhost: fix Rx and Tx queue state > > net/virtio: fix Rx and Tx queue state > > net/vmxnet3: fix Rx and Tx queue state > > app/testpmd: fix primary process not polling all queues > > > > For series, > Acked-by: Ferruh Yigit I see this series as a failure in having common code in ethdev. I hope we can revert it later to have a better ethdev code which update queue states taking deferred start into account. It may require to rework all drivers to have a common behaviour, but it would be a better improvement.