From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D383B2C15 for ; Tue, 5 Sep 2017 10:34:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4F12320BA8; Tue, 5 Sep 2017 04:34:40 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 05 Sep 2017 04:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qvk7TwbCPQwFDwx Qb6TfzSFLyBQeHeJ1Js8MwSVcRBg=; b=iU1cHoELZ/EmMWId+hOxQIwqVUQOKWh 2If03LllFFtuAQWYMiMfoy7P6+hElNlk8OBWIJcOc0q8gMxD4EqnyxDkF/487Kz1 LKmg9FAhN/Y1XMQbgNlip5yn5iWzF36C/XXRb3obOXOhZjTLpA4GKOKYtyjpyvbR RdOgrRDYni18= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qvk7TwbCPQwFDwxQb6TfzSFLyBQeHeJ1Js8MwSVcRBg=; b=DQR6X/bi 1KHQYmB/+3XWl6xuCDRr0kViJcvgJYXmL37CeUbW3NG0gwOHHtkRGeHsozMM/YRt 1WEq7xfD3KpZWsXhHL5Uj80yL/S75RBB8FpHcXtiwI31PrhjPTfuWIWYNUSRyCpK L17RdHuwZnw7l8rC1QjdpTX6OBeJIw4z7kshKH0HPbeseywVgpAza6eP2tdPZW4S NPQXGOSL5iwHzOKdA8hbdBhZHHqyfFKsDzTD165DsumvAhf3n6IjrHfMh5W+ADUS NZkKRqbMhKNNbBcGRTvtu/WJyQvaa1V05WhbBqS4NzJhbmd+q9itjqaVoDkKveL3 +d8z90mLZfT28w== X-ME-Sender: X-Sasl-enc: SQoxMrkkYGra1gNuv2Z3DY0GxifZOCb0Iy1zkkH4oKxY 1504600479 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D9E847F96C; Tue, 5 Sep 2017 04:34:39 -0400 (EDT) From: Thomas Monjalon To: "Tan, Jianfeng" Cc: "Richardson, Bruce" , dev@dpdk.org, "xen-devel@lists.xenproject.org" , "Mcnamara, John" , "joao.m.martins@oracle.com" , "jerin.jacob@caviumnetworks.com" , "shahafs@mellanox.com" Date: Tue, 05 Sep 2017 10:34:38 +0200 Message-ID: <1877951.5TUJrl4YNn@xps> In-Reply-To: References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com> <18154944.ikgZCrDS5M@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 08:34:41 -0000 05/09/2017 10:07, Tan, Jianfeng: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 05/09/2017 05:41, Tan, Jianfeng: > > > From: Richardson, Bruce > > > > > > > > Reading the contributors guide section on ABI, specifically > > > > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating- > > an- > > > > entire-abi-version > > > > it seems like we should collapse down the versions to a single one > > > > following the function removal, and also increment the whole library so > > > > version. > > > > > > So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change > > it in below way? > > > > > > DPDK_2.1 { > > > {APIs in DPDK_2.0 except xen APIs} > > > ... > > > }; > > > > > > DPDK_16.04 { > > > {APIs in DPDK_2.1 except xen APIs} > > > ... > > > } DPDK_2.1; > > > > No, you don't need to collapse. You can just remove Xen functions. > > Thanks. > > Besides, two more things: > 1. Shall we increase the so version? Yes > 2. This patch is about 8K lines long, do we need to split? I do not know how you can split a removal. If you have ideas, feel free.