From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 383415A43
 for <dev@dpdk.org>; Fri,  3 Jul 2015 17:48:06 +0200 (CEST)
Received: by wgqq4 with SMTP id q4so91615709wgq.1
 for <dev@dpdk.org>; Fri, 03 Jul 2015 08:48:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=trf0S1VidFPevyNFM/+gi0dMo5ZXp2bD4TwLjg+wF1g=;
 b=NkC6XS6cKuGmBEIloOGpdSeYMsaMe+d4K9AJZpncPU3CZmakmf5Z/5HGaVvmVgqAY/
 joq5Rt6HwJyRhR2LJ6151j0VkpRNlWr6qdPSVy9UikLb7Adeq+01x67xCF/zcTqmdreP
 DcGn3S/vrC/flQNoy7RMHm9I0bxf8F/PtZYDrxxp1Vk5v++KXrnvp2KNXAlt54ilurOy
 3aGbvXt8H+l8Hx7tZVnrIhkJCfZw9wvQ7WXH0xbxEWoXDW3C8856ZqAw1r8qrOdkEkEG
 ZU68qfN/TeNO1g29depDaCbM+WJ3flTam5eVqZcHGJudorX3fN2keWQQH+HZx4h12zFf
 R8ZQ==
X-Gm-Message-State: ALoCoQlv+UINwvFKDj9cHZLUfzkwTrpm/n/4yKFPcQonJiTNVT9cprZNSYFbTyTYYRWFg1diQDZa
X-Received: by 10.194.121.34 with SMTP id lh2mr46604568wjb.101.1435938486141; 
 Fri, 03 Jul 2015 08:48:06 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id v3sm13917119wja.31.2015.07.03.08.48.04
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 03 Jul 2015 08:48:05 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 03 Jul 2015 17:46:55 +0200
Message-ID: <1879755.kzD1mjHoUo@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1435938006-22254-3-git-send-email-bruce.richardson@intel.com>
References: <1435938006-22254-1-git-send-email-bruce.richardson@intel.com>
 <1435938006-22254-3-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: check mbuf refcnt when clearing
	RX/TX ring
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jul 2015 15:48:06 -0000

2015-07-03 16:40, Bruce Richardson:
> The function to clear the TX ring when a port was being closed, e.g. on
> exit in testpmd, was not checking the mbuf refcnt before freeing it.
> Since the function in the vector driver to clear the ring after TX does
> not set the pointer to NULL post-free, this caused crashes if mbuf
> debugging was turned on.

Please, could you add a Fixes: line to reference the origin of the bug?
Thanks