From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0056.outbound.protection.outlook.com [104.47.38.56]) by dpdk.org (Postfix) with ESMTP id C3E682BB3 for ; Thu, 10 Nov 2016 06:54:10 +0100 (CET) Received: from DM5PR03CA0006.namprd03.prod.outlook.com (10.175.104.16) by BN6PR03MB2883.namprd03.prod.outlook.com (10.175.125.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Thu, 10 Nov 2016 05:54:09 +0000 Received: from BN1BFFO11FD034.protection.gbl (2a01:111:f400:7c10::1:130) by DM5PR03CA0006.outlook.office365.com (2603:10b6:3:118::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6 via Frontend Transport; Thu, 10 Nov 2016 05:54:09 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD034.mail.protection.outlook.com (10.58.144.97) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.707.3 via Frontend Transport; Thu, 10 Nov 2016 05:54:08 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:1073; Count:13 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uAA5s4J5022819; Wed, 9 Nov 2016 22:54:05 -0700 To: Jianbo Liu References: <1477581467-12588-1-git-send-email-shreyansh.jain@nxp.com> <1477657598-826-1-git-send-email-shreyansh.jain@nxp.com> <1477657598-826-9-git-send-email-shreyansh.jain@nxp.com> CC: , Thomas Monjalon , Jan Viktorin From: Shreyansh Jain Message-ID: <187d6951-3360-151a-3b8a-64ac82a3025c@nxp.com> Date: Thu, 10 Nov 2016 11:26:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IncomingHeaderCount: 13 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131232308490179736; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(24454002)(377454003)(8676002)(92566002)(86362001)(85426001)(81166006)(81156014)(4326007)(2906002)(106466001)(626004)(105606002)(68736007)(104016004)(7846002)(31696002)(305945005)(77096005)(356003)(8936002)(229853002)(586003)(87936001)(5890100001)(83506001)(64126003)(50466002)(230700001)(93886004)(6916009)(36756003)(69596002)(189998001)(76176999)(54356999)(50986999)(4001350100001)(5660300001)(23676002)(65826007)(31686004)(2950100002)(6666003)(110136003)(33646002)(47776003)(65806001)(65956001)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2883; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD034; 1://Evk3/p/G8Zel0nw2POE3yLTOtb7kyisjQRXPnhXIxcZSaC8UmjlOX3HSp/K4tAcryHFPJQGTiRzEA4gg/fD2w/eAQmpgad/FW4SfP3YHP6GFiz6bto+jdknO8wvzEuajCJXky6aEjtDTmjl8547c0EntsuEk5SYfA6GH/dm0+4uRs9dlvxyHXAQUgDHmryxKFJ0qFKGvSk3srKSWbsV/1hrGXr/zSsdDDnqFPVkVC6ZHo8bASonGvfaC06mw6Zux1iNaV8YBj50cek+zJ6fv0Oxs7rvRlx9QHzYXhBYH1RHxlf510s9zBoD9OHuv/JTW645c/yQoHnQZ0RE7Y+cE3/6iNYqr0/A5KcWB1+OCyKsDk+fNi8VsRPd6oJGnjIMUKiIXQjbcbXUF8XFA9+diSxx44qmiVsniJg81P/Pk7bmG0KBJg0oq86SIvCFQYMeVbAc3brv/87Ii41Ty2pBk1DGpW9FAPgRQefEv41D2IlJCOrxnD26xfKFlqtRtJbnU6Oe/gM3MQnt+UdncsiDNfBgVyYupa1vKCDypP2q7BYH9B3AY5gNa7hb3WY34bVHvsx24uXyLzwbTAqqsEhvzf6S+3EMgJbk62jgi5daDc= X-MS-Office365-Filtering-Correlation-Id: 040ce5f4-af7e-4871-9498-08d4092dfd13 X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2883; 2:yb93u+sXtbAC0iIJ2kuNIqqdOSH9lsyadwArCiNXG1TvRBCaFoIDuRtPxB7ZxfKbu2PVcVuN1VPAhHphdT0+u2HDRKMjPWx8+MNydaFUn/vmjzuAzeXCxz2aJ3jXiTROH+mZBlO1z7haypBjAL2UaxWwn8UnsXvTUgPJ0QPaYi0R4euJ8VUzsM1PMA+e1tPZAERV+IoNfseXw4OeSy33mg==; 3:tr0Y7SIwVGspaDyRGwqtfrWfkUDU+C/h9CkwiRiaqok0qDhTJw7o+Iaa4YdUK0TzRk+RbSkKAJGUp/PJNmIV5aj6aaQpdy/vwENdXLhxKt66HQU9ExT/hYpss2HeRCKv/nR3c8UgxxtQSfT/GkewjU3CWDHTVFiDVhi5T1+j3sSqIRkyQNjc8y10p0qQf3+8HRxSjQQMdtzt8XHDqMrSCEXfcxMVq9IcLI2Ybj8nj1xza/3YOoe+y7xnyiGPSnGl X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR03MB2883; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2883; 25:K+7Og5Lze3HTNsjpGImPXXnBiHseYQedACCBVmm+UG+9MBdsIobJFwtuRIY2t5Fyj4eA4IIAoganHGLkWmb4myWba8C0yjoI6+uYuayahtqg743ec4kDFShiIKYf+DjOrOKnNLumYg86JLlGl131sduZW2oYN6UIJBDwMvi2Nb8he5Y4xLUUGttrIRu0ui5mt/bIqV14VRxNEFEpA7JA+ur2ES/GSSchwQUI4D2oAnQi74D02v+jN76TJDv5TaX4eA0jQgYbXEpQPrEwbiUCjFBMW027l37oEk6M1tM2qNEIs9/6Z5zMHR1NSrFVawEyKpLcR/MZoTu2M+jU5GpfcCekrMj49anGDW9t+pRlBnOTea7hAwqj0cuszHxPS5jhxb1CBQhG+KYl3U0Gy0Wl5s9iZS+FUv6lh1UDsiSlEA/YKpxiJssqHq3OPN39mz4yqx/f4eeUcuPcN+EnAvfNcA==; 31:eYhmJ+H+P5/WJ52BQ/IVD4GdhkFllRSlsb/NLjGxIgpR1ZN5sRz6k9S1v5xC+NvSFnv8ibLlZ/HA/R2UCx6FzknfMgUBerAutjWGFo2O0kaPZWK+ZfW8/5Sfpc4DIfoIdpxBEoBkPR4JN9hq42bR0W6No3s7zZBy4vm/ItTCMWyoF08ns1Mc2L8DxlqAcEJq0sQkwQt+8ioWSehJOJNC/bW4g8EN+ZkwDq6AaMaGr6nAxiZ1XLX8BIO/R7R0wCyZOoMEbUGD/mDroNRnB8mX+FoCxE7M1V6Vf72ZRLIv1Jg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(13018025)(13023025)(13024025)(13017025)(13015025)(3002001)(10201501046)(6055026); SRVR:BN6PR03MB2883; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2883; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2883; 4:GbRvZqiYBZGMEfPKvLJfgUM2/yO8VQhDW+JwiHtToo4OTPsYQAJKmqP2lgnCy9mcQQg1cLZG32U1B7vvQoBccF4pLCZlj/m1CWG82RCvm5K3BqiTUsDuFXs6ljEpkuvlpX264srX7OcpRLYs09bKR6f/mHLkMUjDYs+QJdEVSF/7HSRv5LtXtVZQ0XqL0OdDAtMD/TVYCdcHu8lUzWYkvKg1jx5hIGLKMt3HjfXjDCFtzFPQukXEwJPTIhWo33Eb2FCP/oHxIGXtTlJXO4pBHm08AjZQ75QN65tQU9lIH8kpDo385oWUhcNssP9EoG5CvviAaBCReCBf288Lcr1iHmNfHBUf2qi4Sv4waCSgKoU+eNlDI2dCzU+Su/a+lfHjzeEwmHvCj6CMKD96lqWZbAC7PrOZmiyIc/w0axho2/RvvKLoqbDsXbHLiA03xwoL755kUbgeijoCq9ZrjTzY0FTFXv536iE2VKSp/sEFFRA8aaaVg5NH65YRZPWpcawrsmeoZyncqHPriwJ15AAZpgK0w2kAFJmmlST/N7aABzKx90Vh04wjNyLCliQG9tzn X-Forefront-PRVS: 01221E3973 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyODgzOzIzOko3WlpXd0ZwamRBK050elVkNWE5RW51RStr?= =?utf-8?B?bTJ5RVh6L3dYeHo0d2RldEVGSmJ6NUpoNDhvREVUQ2xKRWFpdHh3Z282MDZr?= =?utf-8?B?WnhsWXE5eWszOU14bkxCSCthLzlHYVpFRFJnbGJqY1FuRUg4VGF0eC9RbTg5?= =?utf-8?B?bXFXcVQyM3RubkxUbG45Y0M0TXhsYVNTbnQ2WmtHNDVhaGkycHI5MjdCNk1v?= =?utf-8?B?S2NkUUFQcGRnY096cVJXVXJiSUNIVG1DSnpuNzdHZjEydnlPN2NvMlJ2Q3Fl?= =?utf-8?B?Q3IxbS8yb0NVV0RxT1E2aE5aMzZTd2o1dVQ3UFJGcWlmVGZmQXlKUlRGOFJk?= =?utf-8?B?TnkrZHN1bjNjMHJ3dVdrUzg3aGxtbFlQUW43aHo2TG1pMzBPTGRoV05oTDRp?= =?utf-8?B?R09ucEdFa1RtY0J3a0pTOWJxWXN4UFBvUmpveEM3RktoR3J3Ynk4OFhIOW9Y?= =?utf-8?B?bCs0NkVWbGhMQS93T0g0dFN3RnFKN0djL2RnWDcxWEQ3VTdXQW9oeWpUUDRw?= =?utf-8?B?SVNYajJjekpKZSt0WDNhVGhXMXhUQzlEOE9CdnNHdjdVaDlzK0xZR0wxUytP?= =?utf-8?B?cWJ2VlZ2eXRuZW80UkI2Ty9EWmVTejQ4WkNhRjhTb1VNZGNiODhQODc4S09J?= =?utf-8?B?MzRtMjlsY2tHUTZhMk1DRFJOVml5TFp3NHc3RE5reDZLTmJMcVp6eDk2cGpo?= =?utf-8?B?RmtzdzY4NTNGSGZtT3dmZzR3ek9HcVh6em1xWFJDMlFvQ3F1NFl6MWcrR0VW?= =?utf-8?B?UUQ2N2JNVU9VVXhuck13RUZpeFVaOFh6SFZRbEF0dnlSSUJDdUFodHQzYU05?= =?utf-8?B?cXZCeFNITlFYT3BkL0FIOTdsMDhaNDZ6Y1dLR1JvWHhyc0FCUGptS2RVbzI5?= =?utf-8?B?THNzVVVaMHIrVE9qZVdVVDBFdnV1NXRCZHNQZFVhNmxkWVBJa3NJbGF5Tk11?= =?utf-8?B?bTBzRVhzMDBhUnZRdGVwVjNHMm1uK3Q1cmdFTDhxbk1WNEJucDJZZGpBbFlj?= =?utf-8?B?VmhsanBUaU5qckxMRWRWblA1eE1tK0pGemhWTE44bUx5bzAzL1V2MkE1SDhu?= =?utf-8?B?MGx5T3d2THAwQWE3ZzVtT1BHV3BCY3dmOG1KeXFiQ1RaVkR6TVFjK25ybE9D?= =?utf-8?B?S2VnTitBL1RGUDd0YWRqNUxCbVV5WDg0dmhTSG9xbTVGYkJYdW5oM3EveFcy?= =?utf-8?B?dEFvUG80dW9yYTdRSENrSDdJZEkzZ1A5eHRTZkNYU2JRci9HVjVVMHNYWDl3?= =?utf-8?B?eWJwa0UwbHdQVnBmVkY2c2RTVUNJK3AyaDBIMlFOSy9YOVUvRDhwY25SVmNM?= =?utf-8?B?SW5NSytMRTFXdmdwTUpHVmFJUW00enpqcXJ4cHNLb0hDWUJFRU1QUHJaMmR1?= =?utf-8?B?bnB5di9JazhEK2tVd0R5QkJxaWVMVHNTNUdrL0x1QnRUSVh6OGI0K0pETEd6?= =?utf-8?B?VHBUVExJZHdTZU0wTXdOa3VDSzM3RmMvdkN2bWw3UE8xcGsvNjR3RklaVHBn?= =?utf-8?B?bjFZUUhuclMxdXFiR29COVJsVDhpNDVCR3d5Vko1QkJxcC9Sc3dZdnRpa0hU?= =?utf-8?B?S0R4RVVMdDBjUFhSb3F3TkZqYy94RktzeUVBbE9nUnBpZ2s5cUVRWTg3SlNT?= =?utf-8?B?QVhCeXg1R0t0cFd3a0UrbkxtMlhIQWF2SFR4Zm9KQ2VxTFA3NDNTUEYxUzJk?= =?utf-8?B?MGx6My9kd3UvZ1VrZG1lQjFCNXUrY2JBNklNcXlnc29Vd0VFNUg3VTBMQW56?= =?utf-8?B?NnBZalFYaGY3aUd4eWdxVUpISUIyNFdDQ2FhY1RFeEhGVWw2bXBYUllESmg2?= =?utf-8?B?cm8yMmlnSU1zWGxCcXlhZ2xhbXhBY2NQcjZJdHNIT0V0Q3c9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2883; 6:xOIOKmas4i3fnJMZrwBxYssNPLZyDstbwVjk3aH117FcrrMb+sfN5+TJvTS0ZulOBbJ5HVquRGrBQyOgwtmMKCxzyptQHsZOoRk+XeSjeUdNU+dckEolEtGn+TQJ9GcLKKPAnW7D1rgDsX8VR0i5//M3BML0uw6KNZCh37V2bfduvei/AheL1xGrR966LjbF6CkvT9mCj80VO7I5joPIkWF/M5CUNTff8Mxl6zL9qC1UTuBjm/cuyckZLn0rFCdT8lzkE/4Xypq6oVnZbQp4hwRP9/cPBE08qtzif6eYdKRg9lTT5ypY7aYArMPOQepz; 5:HkwU7EcZ7BL+jUSIKcd7g3RjdxYJMewrCnQgSU4DRdgWj4FlEOUDylk4ip5fun/edxE+MB7w2NJqbBYxWYyfav+SbHqkzCQuY3VqL7Vgqc2sUM3jCN+uKSq2zDLhgyggEtO3M8n8NqgxulfEjv62h0r4753A0uI60nrgbmG0R/5Z4k/HTTLrhAVhS3xxqyyz; 24:n/chqZ0ikpdvuOL9YloPN+ZGSW5+yMixGOMb1jfUIJnymonNvO+MFwXlhuefxIDV2Op4bqcbqaFmxqOfKi9e1PPQ/4oDAVhwZf7eHOSM7Ok= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2883; 7:RB7ZjFxiLL3fBgIOBjAGjJVcYSORgUw7Ki5DUEuTWedvOOsDwqP4NK49dMFPk9gGR1sY8gdW24iHpRcIovRTQqe+G+B2qXjI3IMuBKAIpbNKqndG8kZfEOjXG+ISgWwZDzaeCaXRC7yPf+Bv25qaGZw2MAkfStbR2cM7XWkIzP5r7izk63/jiJqrB79aYUEXROnA9RtMLuuUNfzBB/22udkPhn/F5rJJ7YMeUuAM7OooBqxTNNF2lZlwZ3mCQJKddS2XnH6a7fInd0Kls3d4NtUdQQ4lFPX4wqVsHg6GdF1zNkl4yVwoX6M8TQ1CXQK5XtgfIlbfLf+YyedHltPjvfI95iMdHWLflkZoimAcWmo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2016 05:54:08.7371 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2883 Subject: Re: [dpdk-dev] [PATCH v7 08/21] eal/soc: implement SoC device list and dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 05:54:11 -0000 On Thursday 10 November 2016 08:36 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> SoC devices would be linked in a separate list (from PCI). This is used for >> probe function. >> A helper for dumping the device list is added. >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> Signed-off-by: Hemant Agrawal >> --- >> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++ >> lib/librte_eal/common/eal_common_soc.c | 34 +++++++++++++++++++++++++ >> lib/librte_eal/common/include/rte_soc.h | 9 +++++++ >> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ >> 4 files changed, 47 insertions(+) >> >> diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map >> index cf6fb8e..86e3cfd 100644 >> --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map >> +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map >> @@ -171,11 +171,13 @@ DPDK_16.11 { >> rte_eal_dev_attach; >> rte_eal_dev_detach; >> rte_eal_map_resource; >> + rte_eal_soc_dump; >> rte_eal_soc_register; >> rte_eal_soc_unregister; >> rte_eal_unmap_resource; >> rte_eal_vdrv_register; >> rte_eal_vdrv_unregister; >> + soc_device_list; >> soc_driver_list; >> >> } DPDK_16.07; >> diff --git a/lib/librte_eal/common/eal_common_soc.c b/lib/librte_eal/common/eal_common_soc.c >> index 56135ed..5dcddc5 100644 >> --- a/lib/librte_eal/common/eal_common_soc.c >> +++ b/lib/librte_eal/common/eal_common_soc.c >> @@ -31,6 +31,8 @@ >> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> */ >> >> +#include >> +#include >> #include >> >> #include >> @@ -40,6 +42,38 @@ >> /* Global SoC driver list */ >> struct soc_driver_list soc_driver_list = >> TAILQ_HEAD_INITIALIZER(soc_driver_list); >> +struct soc_device_list soc_device_list = >> + TAILQ_HEAD_INITIALIZER(soc_device_list); >> + >> +/* dump one device */ >> +static int >> +soc_dump_one_device(FILE *f, struct rte_soc_device *dev) >> +{ >> + int i; >> + >> + fprintf(f, "%s", dev->addr.name); >> + fprintf(f, " - fdt_path: %s\n", >> + dev->addr.fdt_path ? dev->addr.fdt_path : "(none)"); >> + >> + for (i = 0; dev->id && dev->id[i].compatible; ++i) >> + fprintf(f, " %s\n", dev->id[i].compatible); >> + >> + return 0; >> +} >> + >> +/* dump devices on the bus to an output stream */ >> +void >> +rte_eal_soc_dump(FILE *f) >> +{ >> + struct rte_soc_device *dev = NULL; >> + >> + if (!f) >> + return; >> + >> + TAILQ_FOREACH(dev, &soc_device_list, next) { >> + soc_dump_one_device(f, dev); >> + } >> +} >> >> /* register a driver */ >> void >> diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib/librte_eal/common/include/rte_soc.h >> index 23b06a9..347e611 100644 >> --- a/lib/librte_eal/common/include/rte_soc.h >> +++ b/lib/librte_eal/common/include/rte_soc.h >> @@ -56,8 +56,12 @@ extern "C" { >> >> extern struct soc_driver_list soc_driver_list; >> /**< Global list of SoC Drivers */ >> +extern struct soc_device_list soc_device_list; >> +/**< Global list of SoC Devices */ >> >> TAILQ_HEAD(soc_driver_list, rte_soc_driver); /**< SoC drivers in D-linked Q. */ >> +TAILQ_HEAD(soc_device_list, rte_soc_device); /**< SoC devices in D-linked Q. */ >> + >> >> struct rte_soc_id { >> const char *compatible; /**< OF compatible specification */ >> @@ -142,6 +146,11 @@ rte_eal_compare_soc_addr(const struct rte_soc_addr *a0, >> } >> >> /** >> + * Dump discovered SoC devices. >> + */ >> +void rte_eal_soc_dump(FILE *f); > > If it is to dump device information (not driver), is it proper to > rename it rte_eal_soc_device_dump()? Well, 'SoC'=='device' in this context. Isn't it? In which case, 'soc_device' is just redundant/reuse of a descriptive word. Or, on a second thought, 'SoC' represents a bus type here. In which case, this name sounds better. This would also warrant rte_eal_soc_register->rte_eal_soc_device_register. But, if I need to keep it in sync with PCI (rte_eal_pci_register), I think original naming is apt. I prefer continuing with existing (rte_eal_soc_dump) for this reason. > >> + >> +/** >> * Register a SoC driver. >> */ >> void rte_eal_soc_register(struct rte_soc_driver *driver); >> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> index ab6b985..0155025 100644 >> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> @@ -175,11 +175,13 @@ DPDK_16.11 { >> rte_eal_dev_attach; >> rte_eal_dev_detach; >> rte_eal_map_resource; >> + rte_eal_soc_dump; >> rte_eal_soc_register; >> rte_eal_soc_unregister; >> rte_eal_unmap_resource; >> rte_eal_vdrv_register; >> rte_eal_vdrv_unregister; >> + soc_device_list; >> soc_driver_list; >> >> } DPDK_16.07; >> -- >> 2.7.4 >> > - Shreyansh