From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A113DA00C2;
Thu, 3 Feb 2022 12:11:53 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1939A4014F;
Thu, 3 Feb 2022 12:11:53 +0100 (CET)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id C771840143
for <dev@dpdk.org>; Thu, 3 Feb 2022 12:11:51 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id 741555C0164;
Thu, 3 Feb 2022 06:11:51 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Thu, 03 Feb 2022 06:11:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm3; bh=gE4NvNBM9n+vCA
RkYVavlcnOya2tC65nXl+qNtky/uQ=; b=RBWhOkKEbmM9EvIDKoadCGs73Xp8Id
0rjhMihhUMVBmPwwmM23pS/0ueHxCG3WUeCU0/0msr9q4PrEgw4ZyN/An6MALJre
uJU8fkL/r5VeypanCoKQr+t2Aj3OjIlMtbhOmeXJZecgTzqbZV8h+N8orCD2utzu
ph+luRDm2dnu44tQPawqnQaUEn1BtN14uGxw/hrjkAOFDY/bVa5fTcNWs5VlDjr+
SWqXWfljlsyGh/FEj1x8k7U/ke03/I+QuL0O1kuzeo+/NktWlrGZV1L66gApFBSp
f3/GBtCogquwlzxFRVrZouwpzUPtr+gIL5e5QPDLQHFiQQBgK6GGGc4Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:sender:subject
:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=gE4NvNBM9n+vCARkYVavlcnOya2tC65nXl+qNtky/
uQ=; b=IKGQpj4COeSETmE8M7Gbjo3l3x4tATN1nA6ZFG1K5KT4SkMq8jYkFg6wi
xiJ1VIIjIeyszQ9XAyaj/llP0CdAZnMsjAmKVg/qdkMt+jZufWa1inLjF8hHjbTe
9WrulZ0AO/3eSv67Ul5z7l/Zf1fVExlawsLkT7GSocIf15gVJ6lPrMmDb2jFvBzY
ToDuLluE4Xef9kb7GDwhv9zJXm/fkHPZxMC6/P0PBoUmga6tK+z/MseT28in++4L
pk7kk/J0IV7uf7rKwtSwvtRsXmHRskWjI6WbXgxUxZXjH2yzQMOsQbzL8Q0Wu39Q
RnTKJmJ9GwsXETDuDunNy0xM+amng==
X-ME-Sender: <xms:drj7YVnHf9_R5wzPs3EsPJ4eYLKldvgmenP1kyg11E9FmWfAnE1qkQ>
<xme:drj7YQ3zgzLmem8N6P0IMejxZyuoM4bmFI1pAocrwjE7esEFMnTkGtHLGU1e5M0iR
DLQP82bJWa9keTBAw>
X-ME-Received: <xmr:drj7YbqC6FvIKlOJOK04fKs3iDJS67Qag8YqMzwKV0AAME2lFuH9RsrWVV96Q6QhG89bO6CeJluru90_D3RSS_MrcA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeejgddvvdcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedutedvjeelheefgeeigeetjeehudehfeeftdeufeelgedufeehieej
fffgjeffteenucffohhmrghinhepnhgvgihtqdhnvghtrdhnvghtnecuvehluhhsthgvrh
fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
lhhonhdrnhgvth
X-ME-Proxy: <xmx:d7j7YVkxzhuPQT3LVtosrVnUaE1RggL3hJNmj2xS77C6Nat3AgPXNA>
<xmx:d7j7YT29cP98N0GD1LYCcoAbQOEZEhxDjwfb_A5SUw2W7gIh_maIHw>
<xmx:d7j7YUv9J-hJD5VR8tARnBezZ2T0qaEYI6dAbEWuI1XZ2x9qVOg4uA>
<xmx:d7j7YRBVrezUkWMbzI99GcMBiA9kMAZWe01rNgY1DKxLctFOHVxbJQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
3 Feb 2022 06:11:50 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, "John Daley (johndale)" <johndale@cisco.com>,
Weiguo Li <liwg06@foxmail.com>
Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order
Date: Thu, 03 Feb 2022 12:11:48 +0100
Message-ID: <1882543.fIoEIV5pvu@thomas>
In-Reply-To: <f68b0f21-d5aa-9815-2dd4-8c0651d057f7@intel.com>
References: <tencent_1C910791FD18399E80538A08419DAB6FBE07@qq.com>
<2530593.7s5MMGUR32@thomas> <f68b0f21-d5aa-9815-2dd4-8c0651d057f7@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
03/02/2022 11:57, Ferruh Yigit:
> On 2/2/2022 11:50 AM, Thomas Monjalon wrote:
> >>> Subject: [PATCH] net/enic: adjust memory check and use in proper order
> >>>
> >>> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
> >>>
> >>> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> >>>
> >>> Reviewed-by: John Daley <johndale@cisco.com>
> >>>
> >> Applied to dpdk-next-net/main, thanks.
> >
> > Please could we have a little of explanation in the commit log?
> > The title says "adjust [...] and use in proper order"
> > but I see only a move of the check.
> >
> >
>
> Is following good? If so I can update it in next-net.
>
> net/enic: fix dereference before null check
>
> Move memcpy to 'ah->key' after 'ah' null check
>
> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
> Cc: stable@dpdk.org
Looks better to me, thanks.