From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 049EB591F for ; Thu, 6 Oct 2016 16:56:37 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f193so295367034wmg.0 for ; Thu, 06 Oct 2016 07:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=wm43reDVYwhe8DRnhEuyspK4jse90FGa3PQ/+Ukhem8=; b=mu0osCo9dyhoHyMX5qdDj6nRXhWZAcpjRYk7ynFQCm3qqi9u4kg38PZsFQE13oBUJl Xaf7QCCFNxDn9PxHSawT127xUGk0cAfOdF7ggJcZWAUT5h/opgqXmMp8zBGUow8QYoaz TjLSlv5kJdnDDyJvCtaQUt/iFznTU/5Fx2DWiJhz03OlIYohsdjzSGpvQ4/UcuCy4rJ1 jHRXxsF+ZYMiXpu7A/OQX79115vhPghfGt+RE4St4h3/O0OCYNewm4c8nm8wvK0RV+OH 3mUyLGVRUrqoQduwaSM2hcFZGhu4vdRbs8UEQLACpT5wml8qGrcRuzxJ/C4+lqyw/s44 gOgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=wm43reDVYwhe8DRnhEuyspK4jse90FGa3PQ/+Ukhem8=; b=GoZifU3dyR9vvMFx0RdGVrEMxho+mjbVYBxaJmOJtJ4ZFJShX9kXU2LlRnTHos9LpA C4UdJ2D8TQyUFFMYlxlzuPa6bM/+jUZkDRYARW0+EknLbFWeZcjeCfjiw9RtxWdneU3o S7MUY46/2TkbjnDmBzRZKKplulSYTMVprjozYsLoYHuZkPYmEucEDfWOecFDyrkBY2Jc pmL85e2l+g7nQ4kS5lWN67TTYK+mrvDlj9qhKZALHC5+KD8UgH9lwGMz6P/dCB+ooqyc uQBYaMmJsOjAYafISq0bWs7qJ0UD3FjbdVUvTwKHNckuHv63eHko5ZWppFT53MFtwLEQ l2Eg== X-Gm-Message-State: AA6/9RmlY8zH0txlh0TsABqUwCB5VRIR0oWraAeRhxNj+GQpzZAYTSQvt7DKlmZXUfVF2ggM X-Received: by 10.194.126.133 with SMTP id my5mr15576469wjb.47.1475765796710; Thu, 06 Oct 2016 07:56:36 -0700 (PDT) Received: from xps13.localnet (102.202.154.77.rev.sfr.net. [77.154.202.102]) by smtp.gmail.com with ESMTPSA id vh6sm14986119wjb.0.2016.10.06.07.56.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 07:56:36 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "jerin.jacob@caviumnetworks.com" Date: Thu, 06 Oct 2016 16:56:33 +0200 Message-ID: <1884200.vdWHEKFaxn@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A08F83F@IRSMSX108.ger.corp.intel.com> References: <1475592734-22355-1-git-send-email-bernard.iremonger@intel.com> <8021250.9Wl94qBdaq@xps13> <8CEF83825BEC744B83065625E567D7C21A08F83F@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal callback function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 14:56:37 -0000 2016-10-06 14:33, Iremonger, Bernard: > Hi Thomas, > > > Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal > > callback function > > > > 2016-10-06 12:26, Bernard Iremonger: > > > void > > > _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > - enum rte_eth_event_type event) > > > + enum rte_eth_event_type event, void *param) > > > > You need to squash the patches updating the calls to this function. > > Otherwise, this patch does not compile. > > I will have to squash everything into one patch, separate patches will not compile. No you can keep a separate patch for the VF event in ixgbe. > > [...] > > > + if (param != NULL) > > > + dev_cb.cb_arg = (void *) param; > > > > You are overriding the user parameter. > > Yes, we want to update the user parameter for the RTE_ETH_EVENT_VF_MBOX > > > As it is only for a new event, it can be described in the register API that the > > user param won't be returned for this event. > > I will add a description in the rte_eth_dev_callback_register function. > > > But a better design would be to add a new parameter to the callback. > > However it will be an API breakage. > > I do not want to break the ABI at this point. Yes, but it can be considered for a later change. > > > + RTE_ETH_EVENT_VF_MBOX, /**< PF mailbox processing callback */ > > > > Sorry I do not parse well this line. > > The event name is VF_MBOX and the comment is about the callback > > processing this event on PF side? > > I would suggest this kind of comment: "message from VF received by PF" > > Ok. > > > > > [...] > > > * Pointer to struct rte_eth_dev. > > > * @param event > > > * Eth device interrupt event type. > > > + * @param param > > > + * Parameter to pass back to user application. > > > + * Allows the user application to decide if a particular function > > > + * is permitted. > > > > In a more generic case, the parameter gives some details about the event. Please consider a rewording here, thanks.