From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ECD1C2935
 for <dev@dpdk.org>; Tue,  4 Jul 2017 01:17:51 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 376F320702;
 Mon,  3 Jul 2017 19:17:51 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Mon, 03 Jul 2017 19:17:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ueFyexH/0eju4Ab
 jMHMQPciSoPIWJbJqRB6o0uX/Hls=; b=Pgr8NBS/AnibruFFDxDsvyacimM1GE/
 PMJhXUk/hn/TpmLZMgDiGwgcNTKCQLnkKMjmIcqLc/vq2ib3b4qPcVyW2y4cN00e
 8y4SxREG6ZJAdDtGFk2qZwZeJUSeQZxpnzOipum5fk/txB/Zd8fScGmxiqlCNvy0
 P3wAZ2cjV5Ec=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=ueFyexH/0eju4AbjMHMQPciSoPIWJbJqRB6o0uX/Hls=; b=gcv7RXTc
 eHwHI+dAwc/40eb2+gGb/fwyQFdsXmOXYzWFkasxxC/iTW4KluPkKsMDxX2JrL4S
 H2ClzXirRaJra10mbGLTfeFVrGsKQUANwn+I/KRx4OtDRup5wW8kGvXpPoM3J+t0
 gjoRmRW3Sa7sW+IgYqZKyRHMkTUohMgtho7wLLTYHJVvRvVHwsveuUSpA5SKVs81
 atN3Uae61cSm7uL9buDJ4G52+8bN0dVEtQux5cAyiBGCVd+Zd07+egduRcOyC8Zr
 Llqno95Lxm9Hx6Oad268kyMjLMGZLSrJteGbyt7SLjGdB6RMQsiZV+PmG0Cg7A+0
 S0y1sS47zN2uiA==
X-ME-Sender: <xms:n9BaWZPUaMBGcLn-uuU-rNuUXkFbl2vXxCtYfUyJYyyzsTuh61dfxA>
X-Sasl-enc: 61crZ0LW4eitq1uCzNTnPgyX5UyRm/6J1ScCUEqYSnfE 1499123870
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E0C112424D;
 Mon,  3 Jul 2017 19:17:50 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com
Date: Tue, 04 Jul 2017 01:17:49 +0200
Message-ID: <1885216.VTJsdQy0gT@xps>
In-Reply-To: <20170630181943.23929-14-jblunck@infradead.org>
References: <20170629182206.1072-1-jblunck@infradead.org>
 <20170630181943.23929-1-jblunck@infradead.org>
 <20170630181943.23929-14-jblunck@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v8 13/14] ethdev: Use embedded rte_device to
	detach driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jul 2017 23:17:52 -0000

30/06/2017 20:19, Jan Blunck:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -439,7 +439,8 @@ rte_eth_dev_detach(uint8_t port_id, char *name)
>  
>         snprintf(name, sizeof(rte_eth_devices[port_id].data->name),
>                  "%s", rte_eth_devices[port_id].data->name);
> -       ret = rte_eal_dev_detach(name);
> +
> +       ret = rte_eal_dev_detach(rte_eth_devices[0].device);

Obviously, I change rte_eth_devices[0] to rte_eth_devices[port_id].