From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config
Date: Thu, 04 Oct 2018 11:18:35 +0200 [thread overview]
Message-ID: <1885384.20xM5LhNRE@xps> (raw)
In-Reply-To: <d9eac379-b0d6-b220-2d27-38ec8ce2ee46@intel.com>
04/10/2018 11:17, Burakov, Anatoly:
> On 03-Oct-18 11:05 PM, Thomas Monjalon wrote:
> > 20/09/2018 17:41, Anatoly Burakov:
> >> Currently, command-line switches for legacy mem mode or single-file
> >> segments mode are only stored in internal config. This leads to a
> >> situation where these flags have to always match between primary
> >> and secondary, which is bad for usability.
> >>
> >> Fix this by storing these flags in the shared config as well, so
> >> that secondary process can know if the primary was launched in
> >> single-file segments or legacy mem mode.
> >>
> >> This bumps the EAL ABI, however there's an EAL deprecation notice
> >> already in place[1] for a different feature, so that's OK.
> >>
> >> [1] http://patches.dpdk.org/patch/43502/
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> ---
> >>
> >> Notes:
> >> v2:
> >> - Added documentation on ABI break
> >>
> >> doc/guides/rel_notes/rel_description.rst | 5 +++++
> >
> > Removed change in this file (dup of release note).
> >
> >> doc/guides/rel_notes/release_18_11.rst | 6 +++++-
> >> .../common/include/rte_eal_memconfig.h | 4 ++++
> >> lib/librte_eal/linuxapp/eal/Makefile | 2 +-
> >> lib/librte_eal/linuxapp/eal/eal.c | 20 +++++++++++++++++++
> >> lib/librte_eal/meson.build | 2 +-
> >> 6 files changed, 36 insertions(+), 3 deletions(-)
> >
> > Applied (without extra note), thanks.
> >
>
> This will probably break external mem patches due to conflict in release
> notes. Should i respin?
No, conflicts in release notes are usual. I manage such conflict myself.
next prev parent reply other threads:[~2018-10-04 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 12:24 [dpdk-dev] [PATCH] mem: share legacy and single file segments mode with secondaries Anatoly Burakov
2018-09-19 8:56 ` Thomas Monjalon
2018-09-20 15:41 ` [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config Anatoly Burakov
2018-10-03 22:05 ` Thomas Monjalon
2018-10-04 9:17 ` Burakov, Anatoly
2018-10-04 9:18 ` Thomas Monjalon [this message]
2018-10-04 10:46 ` Ferruh Yigit
2018-10-05 9:04 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1885384.20xM5LhNRE@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).