From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 786311B04D; Wed, 1 Aug 2018 17:55:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1E00E21AB4; Wed, 1 Aug 2018 11:55:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 01 Aug 2018 11:55:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=rX1RMS4p1eXiloBuff6yRQMZy9 eh6QFPzPnjkgWDYJY=; b=BoJFzKfNKJVKCd5H0Rw8kZGeX3e3h53IngEdXCnP2K 26dJrbvzTf/Nxo5txUzHHKdphqB3c+CgfL7wGV5P3YPKrITOOrrMxghCiHfavT17 IsKDTR7OyZMGQbnrcXocyAOH1C9xCQB8ikMiFefwjCrZ+EDvINqNyOPnXBxcjpPi 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rX1RMS 4p1eXiloBuff6yRQMZy9eh6QFPzPnjkgWDYJY=; b=cEr5d2Srpf0uxj4YCbmLuY kN40XNwB7mqPicn9TaJw96rjuAvbDWcWG1tslTxHcXRnNSDJ7t1ise6i5bgEHgNp 6N2L+dL5UxAxdbEPbg76Wh1E//WifW978TC6Mz7LksJ8FnsXJPDD4kUvvlzOmF5t TOCG/+6QHOy8a3AavxDPb65uJuB56CoMIYCh6lNWkuRVaAnXvj6Tw0F3EvhfFSde nOhEEEpWO4WqyEcYYD2+bHNxHSL7z+J5D3vUGuczbvuA4ZaoKaC1S3Oshwy/wNB+ 0NxRxkC1bbTW3fZcVsIP5sgSCT8LyZ80bZ9+Yt8r5avAm6zJ8X6N1c+nq1EolaKQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F2DEA10285; Wed, 1 Aug 2018 11:55:35 -0400 (EDT) From: Thomas Monjalon To: cristian.dumitrescu@intel.com Cc: stable@dpdk.org, Jerin Jacob , dev@dpdk.org Date: Wed, 01 Aug 2018 17:55:31 +0200 Message-ID: <1885451.eFXLNhJiRH@xps> In-Reply-To: <20180717171417.31425-1-jerin.jacob@caviumnetworks.com> References: <20180717171417.31425-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix bitmap documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 15:55:37 -0000 Cristian, review please? 17/07/2018 19:14, Jerin Jacob: > n_bits comes as first argument, align doxygen comment. > > n_bit need to not be multiple of 512 as n_bits > are rounding to RTE_BITMAP_CL_BIT_SIZE. > > Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API") > Fixes: de3cfa2c9823 ("sched: initial import") > > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/rte_bitmap.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h > index 7d4935fcc..d9facc642 100644 > --- a/lib/librte_eal/common/include/rte_bitmap.h > +++ b/lib/librte_eal/common/include/rte_bitmap.h > @@ -198,12 +198,12 @@ rte_bitmap_get_memory_footprint(uint32_t n_bits) { > /** > * Bitmap initialization > * > - * @param mem_size > - * Minimum expected size of bitmap. > + * @param n_bits > + * Number of pre-allocated bits in array2. > * @param mem > * Base address of array1 and array2. > - * @param n_bits > - * Number of pre-allocated bits in array2. Must be non-zero and multiple of 512. > + * @param mem_size > + * Minimum expected size of bitmap. > * @return > * Handle to bitmap instance. > */ >