After upgrading to python-3.8.0, a syntax mismatch is revealed: doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. Did you mean "!="? if value is not '': Replacing "is not" with "!=" seems the right thing to do. A patch may also be needed in the RTD theme package: https://github.com/readthedocs/sphinx_rtd_theme/commit/a49a812c.diff (not included in release 0.4.3) Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- doc/guides/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/conf.py b/doc/guides/conf.py index e2b52e2df9..4575253c7b 100644 --- a/doc/guides/conf.py +++ b/doc/guides/conf.py @@ -237,7 +237,7 @@ def generate_overview_table(output_filename, table_id, section, table_name, titl ini_filename)) continue - if value is not '': + if value != '': # Get the first letter only. ini_data[ini_filename][name] = value[0] -- 2.24.0
On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote:
> After upgrading to python-3.8.0, a syntax mismatch is revealed:
>
> doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal.
> Did you mean "!="?
> if value is not '':
>
> Replacing "is not" with "!=" seems the right thing to do.
>
Since this is basically just checking for an empty string is
"len(value) > 0" not more logical than either comparison against ''?
/Bruce
10/12/2019 13:00, Bruce Richardson:
> On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote:
> > After upgrading to python-3.8.0, a syntax mismatch is revealed:
> >
> > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal.
> > Did you mean "!="?
> > if value is not '':
> >
> > Replacing "is not" with "!=" seems the right thing to do.
> >
>
> Since this is basically just checking for an empty string is
> "len(value) > 0" not more logical than either comparison against ''?
Probably yes.
I don't know what is the best practice in Python. Robin, any clue?
2019-12-10, Thomas Monjalon: > 10/12/2019 13:00, Bruce Richardson: > > On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote: > > > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > > > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > > > Did you mean "!="? > > > if value is not '': > > > > > > Replacing "is not" with "!=" seems the right thing to do. > > > > > > > Since this is basically just checking for an empty string is > > "len(value) > 0" not more logical than either comparison against ''? > > Probably yes. > I don't know what is the best practice in Python. Robin, any clue? In most cases, it is shorter and cleaner to simply do: if value: which behind the scenes calls value.__bool__() (or value.__len__()). https://docs.python.org/3/reference/datamodel.html#object.__bool__ -- Robin
10/12/2019 14:33, Robin Jarry:
> 2019-12-10, Thomas Monjalon:
> > 10/12/2019 13:00, Bruce Richardson:
> > > On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote:
> > > > After upgrading to python-3.8.0, a syntax mismatch is revealed:
> > > >
> > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal.
> > > > Did you mean "!="?
> > > > if value is not '':
> > > >
> > > > Replacing "is not" with "!=" seems the right thing to do.
> > > >
> > >
> > > Since this is basically just checking for an empty string is
> > > "len(value) > 0" not more logical than either comparison against ''?
> >
> > Probably yes.
> > I don't know what is the best practice in Python. Robin, any clue?
>
> In most cases, it is shorter and cleaner to simply do:
>
> if value:
>
> which behind the scenes calls value.__bool__() (or value.__len__()).
>
> https://docs.python.org/3/reference/datamodel.html#object.__bool__
I guess it works also with python 2?
I am sending a v2 with this syntax, thanks.
After upgrading to python-3.8.0, a syntax mismatch is revealed: doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. Did you mean "!="? if value is not '': Removing "is not ''" seems the right thing to do. A patch may also be needed in the RTD theme package: https://github.com/readthedocs/sphinx_rtd_theme/commit/a49a812c.diff (not included in release 0.4.3) Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- v1: if value != '' v2: if value --- doc/guides/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/conf.py b/doc/guides/conf.py index e2b52e2df9..0892c06dec 100644 --- a/doc/guides/conf.py +++ b/doc/guides/conf.py @@ -237,7 +237,7 @@ def generate_overview_table(output_filename, table_id, section, table_name, titl ini_filename)) continue - if value is not '': + if value: # Get the first letter only. ini_data[ini_filename][name] = value[0] -- 2.24.0
On Wed, Dec 11, 2019 at 12:01:40PM +0100, Thomas Monjalon wrote:
> After upgrading to python-3.8.0, a syntax mismatch is revealed:
>
> doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal.
> Did you mean "!="?
> if value is not '':
>
> Removing "is not ''" seems the right thing to do.
>
> A patch may also be needed in the RTD theme package:
> https://github.com/readthedocs/sphinx_rtd_theme/commit/a49a812c.diff
> (not included in release 0.4.3)
>
> Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
11/12/2019 12:15, Bruce Richardson:
> On Wed, Dec 11, 2019 at 12:01:40PM +0100, Thomas Monjalon wrote:
> > After upgrading to python-3.8.0, a syntax mismatch is revealed:
> >
> > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal.
> > Did you mean "!="?
> > if value is not '':
> >
> > Removing "is not ''" seems the right thing to do.
> >
> > A patch may also be needed in the RTD theme package:
> > https://github.com/readthedocs/sphinx_rtd_theme/commit/a49a812c.diff
> > (not included in release 0.4.3)
> >
> > Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied