From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B62F3374F for ; Tue, 2 May 2017 03:59:14 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2017 18:59:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,402,1488873600"; d="scan'208";a="851844988" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 01 May 2017 18:59:13 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 1 May 2017 18:59:01 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 1 May 2017 18:59:01 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Tue, 2 May 2017 09:58:59 +0800 From: "Pei, Yulong" To: Thomas Monjalon CC: "dev@dpdk.org" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port info Thread-Index: AQHSvnkQUZEqGdF0lECBT3Nh82TRZKHfAloAgAFNwWA= Date: Tue, 2 May 2017 01:58:58 +0000 Message-ID: <188971FCDA171749BED5DA74ABF3E6F03B6C56DC@shsmsx102.ccr.corp.intel.com> References: <1493181099-14232-1-git-send-email-yulong.pei@intel.com> <2267864.xljogAfNJv@xps> In-Reply-To: <2267864.xljogAfNJv@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjFkYzdhMzMtODRmYy00YWE4LWIxNjYtMjIwYmJlZGM3NzNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InArR3I5cUlKdjJcL3JvWDJSR3VWaTdFTDAxYXNuOWUxekxCWTZZV3ZXMCtvPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 01:59:15 -0000 Hi Thomas, -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Monday, May 1, 2017 9:56 PM To: Pei, Yulong Cc: dev@dpdk.org; Wu, Jingjing Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port= info 26/04/2017 06:31, Yulong Pei: > Display pci device bus info when show port info. >=20 > Signed-off-by: Yulong Pei > --- > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -469,6 +469,14 @@ port_infos_display(portid_t port_id) > print_ethaddr("MAC address: ", &mac_addr); > printf("\nDriver name: %s", dev_info.driver_name); > printf("\nConnect to socket: %u", port->socket_id); > + if (dev_info.pci_dev) > + printf("\nBus-info: %04x:%02x:%02x:%x", > + dev_info.pci_dev->addr.domain, > + dev_info.pci_dev->addr.bus, > + dev_info.pci_dev->addr.devid, > + dev_info.pci_dev->addr.function); > + else > + printf("\nBus-info: N/A"); The bus information must be managed in a more generic way. The field pci_dev will probably be removed in a next release. Could you kind to tell me more information about what does "more generic wa= y" mean ? Best Regards Yulong Pei