From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BECA741EB2; Thu, 16 Mar 2023 19:01:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A2DA40DF6; Thu, 16 Mar 2023 19:01:57 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 4FA0540DDC for ; Thu, 16 Mar 2023 19:01:55 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 94BF03200955; Thu, 16 Mar 2023 14:01:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 16 Mar 2023 14:01:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678989713; x=1679076113; bh=oKJp3SwqnnzAk5mtFoK6Qou33t2veKdwG33 u6UbNodw=; b=MH2YODKD5N/KrVTWx77PxZ8Xp7TrIlSRr/MiZx/jFDKWdc81Ptr MXVc0DIefFe7ZeMmTB15aQYrN7lZQXVyEU77VBCSh3gfqkpo/MUtnMqoOer6Zp+R 3ICohuxeCKfxVeabIAE7UFbKkz2VmOLnxDR2YgGfD5ETR1nUS1WjKjv6kG4o6Lr0 bmH2Xx2FzBlQG/bCwolVKi8TOXV7ktO3nOf4C693iQLqA8BI7R7+mOk1ALTWKbhN XdVDzEGr/W2eCpLo11YmFyAgnMUkRShWfSASUbvOJHUJNL35M7afCEDVR4zwZVT4 YHznWbsDl6NdtIAF3YisByw1dKY4tLenZEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678989713; x=1679076113; bh=oKJp3SwqnnzAk5mtFoK6Qou33t2veKdwG33 u6UbNodw=; b=o5Ua8N4GbSbrehWDFys2F5Hi5XG9dPIQ5eVAeA66lhVxr/OzmTL 0FebnZ1N5PyST/ted49Y4RFeK+luR0TpVFLYIfsdA1zA5NFEwPZFcYgDu8nltTV5 NJiwR01hj9rWWodDJcr+b916tS7O3+nsh7/MFASX1/1evOk5xJ2MY7P/28gkYi+3 2JeOakAf1lc/gPx5q5WMNcCzROdbsQZ8FfRshw6Da8Mb6CJsitUVcFUU9zo/IH1n sI7dDuELZVe4+HrYlGHWpr4x64IrcYhKnOknqEmAYgtfJyMRWVt+7XCzFdGnOIIa Z/HKFWu5pYqH66FxeGHiGJ5ghn++ovQ6OIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 14:01:51 -0400 (EDT) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: "dev@dpdk.org" , Shivah Shankar Shankar Narayan Rao , Jerin Jacob Kollanukkaran , Anup Prabhu , Prince Takkar , Parijat Shukla Subject: Re: [EXT] Re: [PATCH v6 05/12] app/mldev: add ordered inference test case Date: Thu, 16 Mar 2023 19:01:50 +0100 Message-ID: <1890199.taCxCBeP46@thomas> In-Reply-To: References: <20221129070746.20396-1-syalavarthi@marvell.com> <23001417.6Emhk5qWAg@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/03/2023 18:47, Srikanth Yalavarthi: > From: Thomas Monjalon > > 11/03/2023 16:08, Srikanth Yalavarthi: > > > static struct option lgopts[] = { > > > - {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0}, > > {ML_MODELS, 1, 0, 0}, > > > - {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0}, {NULL, 0, 0, 0}}; > > > + {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, > > 0}, > > > + {ML_MODELS, 1, 0, 0}, {ML_FILELIST, 1, 0, 0}, {ML_REPETITIONS, 1, 0, > > 0}, > > > + {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0}, {NULL, 0, 0, 0}}; > > > > I don't understand the need to have multiple options per line. > > When doing a list, it is simpler to read on item per line. > > This is a result of running checkformat / clang-format tool. The tool is automatically arranging multiple options per line in the initial patches. The final patch would have one option per line. Please do one option per line in each patch.