From: Thomas Monjalon <thomas@monjalon.net>
To: Ting Xu <ting.xu@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, olivier.matz@6wind.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload
Date: Sat, 26 Oct 2019 00:49:21 +0200 [thread overview]
Message-ID: <1890292.h76DOOWmZ3@xps> (raw)
In-Reply-To: <20191022162636.84909-1-ting.xu@intel.com>
22/10/2019 18:26, Ting Xu:
> This patch enables testpmd to forward GTP packet in csum fwd mode.
> A GTP header structure (without optional fields and extension header)
> is defined in new rte_gtp.h. A parser function in testpmd is added.
> GTPU and GTPC packets are both supported, with respective UDP
> destination port and GTP message type.
>
> Signed-off-by: Ting Xu <ting.xu@intel.com>
>
> ---
> v6: complete doxygen documentation.
> v5: create rte_gtp.h and move GTP header definition
> to it.
> v4: move GTP header definition to rte_ether.h
> v3: correct coding style issue.
> v2: modify commit log
>
> depend on patch: lib/mbuf: add GTP tunnel type flag.
> ---
> app/test-pmd/csumonly.c | 97 +++++++++++++++++++++++++++++++++++----
> doc/api/doxy-api-index.md | 1 +
> lib/librte_net/Makefile | 2 +-
You missed meson.build in addition of Makefile.
> lib/librte_net/rte_gtp.h | 52 +++++++++++++++++++++
> 4 files changed, 141 insertions(+), 11 deletions(-)
> create mode 100644 lib/librte_net/rte_gtp.h
Does it deserve 2 separate patches? GTP header + testpmd use
[...]
> --- /dev/null
> +++ b/lib/librte_net/rte_gtp.h
[...]
> +
> +#endif /* RTE_GTP_H_ */
> +
Please remove this blank line at EOF. Such things are cleaned up sometimes:
http://git.dpdk.org/dpdk/commit/?id=6f3f0acd95
next prev parent reply other threads:[~2019-10-25 22:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 15:26 [dpdk-dev] [PATCH v1] " Ting Xu
2019-10-17 16:15 ` [dpdk-dev] [PATCH v2] " Ting Xu
2019-10-18 16:08 ` [dpdk-dev] [PATCH v3] " Ting Xu
2019-10-18 18:49 ` Ferruh Yigit
2019-10-21 2:28 ` Xu, Ting
2019-10-21 12:29 ` [dpdk-dev] [PATCH v4] " Ting Xu
2019-10-21 9:28 ` Ferruh Yigit
2019-10-21 10:52 ` Ferruh Yigit
2019-10-21 16:50 ` Olivier Matz
2019-10-22 5:34 ` Xu, Ting
2019-10-22 12:29 ` [dpdk-dev] [PATCH v5] " Ting Xu
2019-10-22 8:14 ` Ferruh Yigit
2019-10-22 16:26 ` [dpdk-dev] [PATCH v6] " Ting Xu
2019-10-22 15:45 ` Ferruh Yigit
2019-10-23 17:23 ` Ferruh Yigit
2019-10-25 22:43 ` Thomas Monjalon
2019-10-26 17:42 ` Thomas Monjalon
2019-10-25 22:49 ` Thomas Monjalon [this message]
2019-10-28 1:35 ` Xu, Ting
2019-10-28 8:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1890292.h76DOOWmZ3@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=ting.xu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).