From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2DC7A32A8 for ; Sat, 26 Oct 2019 00:49:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EED881C2DE; Sat, 26 Oct 2019 00:49:26 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id C915E1C2DA for ; Sat, 26 Oct 2019 00:49:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6A02A63A; Fri, 25 Oct 2019 18:49:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 25 Oct 2019 18:49:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qA3TOYwUsj+Zh4VK8sDo/NO+R+kAtPhSAjaHRqvHxKk=; b=eDy2lQPyhvXS /ADkerlAsPYIYtX6kzqsI/gcLDEwTU+/yZuzTNbDHDSMyHTfSDthbnY2Zkyr3qdQ Ct46yFFlphiVdUvgjcAK4/CdxpQcvsHm9rKBY/QslF8xWiSEpayPAGp2UovoOpcQ nmaDkAhyIcPBzx8xW06f/VU7B5gzc+I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=qA3TOYwUsj+Zh4VK8sDo/NO+R+kAtPhSAjaHRqvHx Kk=; b=ArQMFVQz0YYtCJzi1pRhvkzZEuy4I15SAvBV48ixK5zJAkLdwEZ5ZgcF+ Pjpkv8NHqEcDo+e3DSBhw1sxz6rubTokdJaFShCH796e98Ks7d3HSUckKaBmy7lb pd3yA6pymcxr8IvyILtDCAKkxdOEEdeZlKWX4v6eU5IWKu8UBNeFp5B5coegFk0z Koa0Fm1IxNr+1hVki8/Gm9sJBbdw8HZaDvHJBc/Lz4A9EQklsCd7ZsCOFEzTQ//o IduY1k1u/EgionVxgt0wHIzzktGYpCkR49F0bRU49GfkxDUnH5BqC46OFUcAU16+ 3zL6VXDZJ61I8TRO7XeX0f0dyGelg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleeggdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepfhhlrghgrddqqddqrghpphdpughpughkrdhorhhgnecukfhppeejjedrudef gedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmoh hnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A46478005C; Fri, 25 Oct 2019 18:49:22 -0400 (EDT) From: Thomas Monjalon To: Ting Xu Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, olivier.matz@6wind.com, ferruh.yigit@intel.com Date: Sat, 26 Oct 2019 00:49:21 +0200 Message-ID: <1890292.h76DOOWmZ3@xps> In-Reply-To: <20191022162636.84909-1-ting.xu@intel.com> References: <20191022122910.53743-1-ting.xu@intel.com> <20191022162636.84909-1-ting.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/10/2019 18:26, Ting Xu: > This patch enables testpmd to forward GTP packet in csum fwd mode. > A GTP header structure (without optional fields and extension header) > is defined in new rte_gtp.h. A parser function in testpmd is added. > GTPU and GTPC packets are both supported, with respective UDP > destination port and GTP message type. > > Signed-off-by: Ting Xu > > --- > v6: complete doxygen documentation. > v5: create rte_gtp.h and move GTP header definition > to it. > v4: move GTP header definition to rte_ether.h > v3: correct coding style issue. > v2: modify commit log > > depend on patch: lib/mbuf: add GTP tunnel type flag. > --- > app/test-pmd/csumonly.c | 97 +++++++++++++++++++++++++++++++++++---- > doc/api/doxy-api-index.md | 1 + > lib/librte_net/Makefile | 2 +- You missed meson.build in addition of Makefile. > lib/librte_net/rte_gtp.h | 52 +++++++++++++++++++++ > 4 files changed, 141 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_net/rte_gtp.h Does it deserve 2 separate patches? GTP header + testpmd use [...] > --- /dev/null > +++ b/lib/librte_net/rte_gtp.h [...] > + > +#endif /* RTE_GTP_H_ */ > + Please remove this blank line at EOF. Such things are cleaned up sometimes: http://git.dpdk.org/dpdk/commit/?id=6f3f0acd95