From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D828145AF2; Wed, 9 Oct 2024 14:25:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 303244065D; Wed, 9 Oct 2024 14:25:15 +0200 (CEST) Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) by mails.dpdk.org (Postfix) with ESMTP id 5A3A84060A for ; Wed, 9 Oct 2024 14:25:13 +0200 (CEST) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 80831254008B; Wed, 9 Oct 2024 08:25:12 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Wed, 09 Oct 2024 08:25:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1728476712; x=1728563112; bh=RuoyOcDuksZ5RzHM2/MxlJS99NOMQf4LYvHzn11CsY8=; b= J0uebVH/Ak15UYXmk0VN8E2b2sZgVgHsns9UxbB2psqevzIBGyHGkR+C4HV8sybh ZwAdhJOjbhgWOi7gJIK14aAegvOLUM400ZsWw/KI3bfCtnIWMolCFjDw+3tsDnet K0IDquMY8esNQvmN6F1G4Ui4I+cYyJLZGPazNIUb+7/y1NFT8YdvJ3lwIDFVBPS4 YnG4nS5Oo2z7ahx/v6A/BjZanLoMlyapfayCTi3Aump2rJrj7c2t4uA13NK+eTTu xeiX3oemkNG9I9dCFQR8C0g1yYYkeWYVM6oI2C+IG7XoV6NaEB+luu/nKcU7qRpj YdzulZHi1n+MIViqtuhnDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728476712; x= 1728563112; bh=RuoyOcDuksZ5RzHM2/MxlJS99NOMQf4LYvHzn11CsY8=; b=S RW+2Iom6XojG8QzY12NX1iB/J/jNjPPZLv7MfojHWXsFBzsyyInVnHcPR1CYUEvq TZEwxr4a/EHebWHmE/PD8Y5vSAwy00Zeoe1MMEo/mo0g7ssLrqjQzx6vy8tiF2OC Qh504mFLFcoKbc0we1a55twgFRV2/F518TUMBG0Xl6aTK4/TgNJGCe4L3uiinYNd J5GcE3tHid43VK5xNh7lEIbjvTKN2F5ezi9HqoRbyuGFpp5Ri1KfwYl/OX6/EBXH hPQOrFXcUicmdjMP1d8stsgu3wVbzhsvSLox5a6oS4FDDoCxZVfe48DRGelOo1nw YvFSq/U9HHy60uYpboa1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeffedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehshhgrih gsrhgrnhesrghmrgiiohhnrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhg pdhrtghpthhtohepvghvghgvnhihshesrghmrgiiohhnrdgtohhmpdhrtghpthhtoheprh gsvghiuggvrhesrghmrgiiohhnrdgtohhmpdhrtghpthhtoheprghmihhtsggvrhhnsegr mhgriihonhdrtghomhdprhgtphhtthhopegrthhrfigrjhgvvgesrghmrgiiohhnrdgtoh hm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Oct 2024 08:25:11 -0400 (EDT) From: Thomas Monjalon To: "Brandes, Shai" Cc: "dev@dpdk.org" , "Schmeilin, Evgeny" , "Beider, Ron" , "Bernstein, Amit" , "Atrash, Wajeeh" Subject: Re: [PATCH] net/ena: remove unused abort macro Date: Wed, 09 Oct 2024 14:25:09 +0200 Message-ID: <1890441.TLkxdtWsSY@thomas> In-Reply-To: References: <20241009114921.1231790-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/10/2024 14:08, Brandes, Shai: > From: Thomas Monjalon > > > > The function abort() should be forbidden for drivers and libs. > > It is not used in ENA, but the rule is enfocred by removing the macro. > > > > Signed-off-by: Thomas Monjalon > > --- > > drivers/net/ena/base/ena_plat_dpdk.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/net/ena/base/ena_plat_dpdk.h > > b/drivers/net/ena/base/ena_plat_dpdk.h > > index 21b96113c7..a41a4e4506 100644 > > --- a/drivers/net/ena/base/ena_plat_dpdk.h > > +++ b/drivers/net/ena/base/ena_plat_dpdk.h > > @@ -63,8 +63,6 @@ typedef uint64_t dma_addr_t; > > > > #define ENA_CDESC_RING_SIZE_ALIGNMENT (1 << 12) /* 4K */ > > > > -#define ENA_ABORT() abort() > > - > > #define ENA_MSLEEP(x) rte_delay_us_sleep(x * 1000) #define > > ENA_USLEEP(x) rte_delay_us_sleep(x) #define ENA_UDELAY(x) > > rte_delay_us_block(x) > > -- > > 2.46.0 > [Brandes, Shai] Thanks Thomas, we verified this in our CI. > Acked-by: Shai Brandes Thanks for the quick reply. Applied