[PATCH] net/ena: remove unused abort macro

[PATCH] net/ena: remove unused abort macro

[Thomas Monjalon]

The function abort() should be forbidden for drivers and libs.
It is not used in ENA, but the rule is enfocred by removing the macro.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/ena/base/ena_plat_dpdk.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h
index 21b96113c7..a41a4e4506 100644
--- a/drivers/net/ena/base/ena_plat_dpdk.h
+++ b/drivers/net/ena/base/ena_plat_dpdk.h
@@ -63,8 +63,6 @@ typedef uint64_t dma_addr_t;
 
 #define ENA_CDESC_RING_SIZE_ALIGNMENT  (1 << 12) /* 4K */
 
-#define ENA_ABORT() abort()
-
 #define ENA_MSLEEP(x) rte_delay_us_sleep(x * 1000)
 #define ENA_USLEEP(x) rte_delay_us_sleep(x)
 #define ENA_UDELAY(x) rte_delay_us_block(x)
-- 
2.46.0

RE: [PATCH] net/ena: remove unused abort macro

[Brandes, Shai]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 9, 2024 2:49 PM
> To: dev@dpdk.org
> Cc: Brandes, Shai <shaibran@amazon.com>; Schmeilin, Evgeny
> <evgenys@amazon.com>; Beider, Ron <rbeider@amazon.com>; Bernstein,
> Amit <amitbern@amazon.com>; Atrash, Wajeeh <atrwajee@amazon.com>
> Subject: [EXTERNAL] [PATCH] net/ena: remove unused abort macro
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> The function abort() should be forbidden for drivers and libs.
> It is not used in ENA, but the rule is enfocred by removing the macro.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/ena/base/ena_plat_dpdk.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ena/base/ena_plat_dpdk.h
> b/drivers/net/ena/base/ena_plat_dpdk.h
> index 21b96113c7..a41a4e4506 100644
> --- a/drivers/net/ena/base/ena_plat_dpdk.h
> +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> @@ -63,8 +63,6 @@ typedef uint64_t dma_addr_t;
> 
>  #define ENA_CDESC_RING_SIZE_ALIGNMENT  (1 << 12) /* 4K */
> 
> -#define ENA_ABORT() abort()
> -
>  #define ENA_MSLEEP(x) rte_delay_us_sleep(x * 1000)  #define
> ENA_USLEEP(x) rte_delay_us_sleep(x)  #define ENA_UDELAY(x)
> rte_delay_us_block(x)
> --
> 2.46.0
[Brandes, Shai] Thanks Thomas, we verified this in our CI.
Acked-by: Shai Brandes <shaibran@amazon.com>

Re: [PATCH] net/ena: remove unused abort macro

[Thomas Monjalon]

09/10/2024 14:08, Brandes, Shai:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 
> > The function abort() should be forbidden for drivers and libs.
> > It is not used in ENA, but the rule is enfocred by removing the macro.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  drivers/net/ena/base/ena_plat_dpdk.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/net/ena/base/ena_plat_dpdk.h
> > b/drivers/net/ena/base/ena_plat_dpdk.h
> > index 21b96113c7..a41a4e4506 100644
> > --- a/drivers/net/ena/base/ena_plat_dpdk.h
> > +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> > @@ -63,8 +63,6 @@ typedef uint64_t dma_addr_t;
> > 
> >  #define ENA_CDESC_RING_SIZE_ALIGNMENT  (1 << 12) /* 4K */
> > 
> > -#define ENA_ABORT() abort()
> > -
> >  #define ENA_MSLEEP(x) rte_delay_us_sleep(x * 1000)  #define
> > ENA_USLEEP(x) rte_delay_us_sleep(x)  #define ENA_UDELAY(x)
> > rte_delay_us_block(x)
> > --
> > 2.46.0
> [Brandes, Shai] Thanks Thomas, we verified this in our CI.
> Acked-by: Shai Brandes <shaibran@amazon.com>

Thanks for the quick reply.

Applied