Re: [PATCH v1] net/iavf: fix resource leak issue

[Thomas Monjalon <thomas@monjalon.net>]

12/05/2022 02:20, Zhang, Qi Z:
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Thursday, May 12, 2022 5:17 AM
> > To: Wu, Wenjun1 <wenjun1.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>
> > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue
> > 
> > 11/05/2022 17:31, Zhang, Qi Z:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 11/05/2022 13:46, Zhang, Qi Z:
> > > > > From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> > > > > >
> > > > > > This patch fixes resource leak issue reported by coverity.
> > > > > >
> > > > > > Coverity issue: 378017
> > > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration")
> > > > > >
> > > > > > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> > > > >
> > > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > > > >
> > > > > Applied to dpdk-next-net-intel.
> > > >
> > > > In the title, the word "issue" is useless.
> > > > It would be more interesting to precise where is the leak.
> > > >
> > >
> > > Added below into commit log in dpdk-next-net-intel.
> > >
> > > kvlist should be freed before return an error due to invalid quanta size.
> > 
> > It does not explain what is the scenario. What is the impacted feature?
> 
> I think the scenario has been explained as
> 
> "kvlist should be freed before return an error due to invalid quanta size"
> the impact has been mentioned as "resource leak" I guess this is how Coverity describe the issue

No, it does not say how to reproduce (the scenario).
We have no idea where it is in the code.