From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F2EDA0032; Thu, 12 May 2022 09:06:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 396FE42830; Thu, 12 May 2022 09:06:41 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B6CCF410F2 for ; Thu, 12 May 2022 09:06:38 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 326F55C00F4; Thu, 12 May 2022 03:06:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 12 May 2022 03:06:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652339198; x= 1652425598; bh=rY+lfYymZSEU0ZymhMxe+xnua3CusKEAG+/x52wUB4k=; b=u t5gpH/Wz+AKJqKdtuJjGhxk5aySWhdiHSHdUVOPeIjGla/eFfydb69cF7lHjgoln VTLyXQRVBhdAlw1FaFNExAEMOC7VKwXZPBjbmWHPna3NVkBMET3MJSSrgR0UoTal vLh63HRLWsTVBmV06ygOLOKl9jxHSfghCLhRp8+tLc8O/+8DuajJoXrb4oILW5Jf UTO3wb1tSu4NmALTV8Zjgjod/TX0TysJsqQvYl9hLi8sdIeMQFAPL4vgfOT6ont0 E19IKtc51/lRyzFHZcYeDzJeZ1a7HiKH+BBcuDSnmzAskOlBgJmGiTYdV5IFJiCG 3e5lW78IeHrQUppHXzkGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652339198; x=1652425598; bh=rY+lfYymZSEU0 ZymhMxe+xnua3CusKEAG+/x52wUB4k=; b=ZWhDAJjz53FiWfdipatCnIY+x1aCM 7f3b+GlDZxJQ01uANAwswyheglAys19QbAPeGdgufcR8q3DZvuooj4w9y1Yaqyhw xiwI7gPs5lJUnAp3AcZ8/bC++bOgTdyi3Zi+lPUnc3yRE8RdCgCVAN6nlK2ZwQKF z9E/s+boBFl3woP3y1yoxz1vP61JicqChp+rVxkG3DSM/visWGFwFRvyZIAPe+Dw RNmMdb4Lv2byF8PVGlX3e3gFyUkL6vPAeBVhOdrxQL2xH/jnibhwTvPq24JuBxi/ h//C25aZTanaf5l1jk/xxGdgaHG2irYVQIl+q+gAiBC8kD3h1B3CzX1Ug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeeigdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 May 2022 03:06:37 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: "Wu, Wenjun1" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: Re: [PATCH v1] net/iavf: fix resource leak issue Date: Thu, 12 May 2022 09:06:35 +0200 Message-ID: <1891945.fIoEIV5pvu@thomas> In-Reply-To: <2f3663f9e4bf4c4d9c3993cabe57bcc5@intel.com> References: <20220510005425.1648591-1-wenjun1.wu@intel.com> <4349564.Wku2Vz74k6@thomas> <2f3663f9e4bf4c4d9c3993cabe57bcc5@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/05/2022 02:20, Zhang, Qi Z: > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Thursday, May 12, 2022 5:17 AM > > To: Wu, Wenjun1 ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > > > 11/05/2022 17:31, Zhang, Qi Z: > > > From: Thomas Monjalon > > > > 11/05/2022 13:46, Zhang, Qi Z: > > > > > From: Wu, Wenjun1 > > > > > > > > > > > > This patch fixes resource leak issue reported by coverity. > > > > > > > > > > > > Coverity issue: 378017 > > > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration") > > > > > > > > > > > > Signed-off-by: Wenjun Wu > > > > > > > > > > Acked-by: Qi Zhang > > > > > > > > > > Applied to dpdk-next-net-intel. > > > > > > > > In the title, the word "issue" is useless. > > > > It would be more interesting to precise where is the leak. > > > > > > > > > > Added below into commit log in dpdk-next-net-intel. > > > > > > kvlist should be freed before return an error due to invalid quanta size. > > > > It does not explain what is the scenario. What is the impacted feature? > > I think the scenario has been explained as > > "kvlist should be freed before return an error due to invalid quanta size" > the impact has been mentioned as "resource leak" I guess this is how Coverity describe the issue No, it does not say how to reproduce (the scenario). We have no idea where it is in the code.