From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17DA9A0C45; Wed, 27 Oct 2021 10:29:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 098B740E0F; Wed, 27 Oct 2021 10:29:18 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 01B9040040 for ; Wed, 27 Oct 2021 10:29:16 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9A4615C00F0; Wed, 27 Oct 2021 04:29:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 27 Oct 2021 04:29:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= QQS+2WDMGFq9tLk7aRmir5Q4WkiUOpO0EUjDB8xyEUI=; b=cLegGz4npeH9M3hh p6YWeq+msKK8BviJtewp/wdojhR86iE8mYO7uLjUCXQH521dhUvW+cNobup+Nzg4 Hj+gYoReBNJQJwHPaTONsvmRQcOPQhvSCF0wikntSSdaM4KJfhKcK4Ke0srsH5qB t7Gr/aKPx4tcDFtASextprxp1eRSz2fI6jbhYXPyaQi5jbHiHykWTANeiI8Ojbnm +nYsFQCo8RS5WxSmvkR0mEJehreTf6HKHmTxLqXqdKf19y3WsnOLDr597lwfJTnY ORWt6C3Er+pEUfZekubKsWsr71Q6xSjrAi4l7s/VGElu/2VAbuDMeCnlZphtVVZP 26HvEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=QQS+2WDMGFq9tLk7aRmir5Q4WkiUOpO0EUjDB8xyE UI=; b=Oe7w2CYjkQq0efyKHSRkQ9sIl1nbx4c+SM1b8GU1lmJrpLTiVeASzSpdY qRad2zKdh7OV9OPz6Bgj+oTlLwjZQb1CSpXg7YCGRjf4SdCNGHZghixTfILIbEVx qhbdm0meP4PgRWsgnuMj826hNobQwS08G8aZ9Uz7qBwddQBVjatPCz2xtCMizuZc 1txtgBM9PHXS/PjoNSNMnUBWVu1zk1MbGb2g+Eav98YlXt1Y/AEweW/0DQjL8MZD xgpWjsEKf7ctVsRKJ+1k3n8VST9GRWBs77SK+VMwhsr7UAfqNDvhGCcHwNIGiLJ4 Ej92wiIiuQrMvz5x09NaM8qNphh+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 04:29:14 -0400 (EDT) From: Thomas Monjalon To: "Medvedkin, Vladimir" Cc: dev@dpdk.org, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, stephen@networkplumber.org Date: Wed, 27 Oct 2021 10:29:13 +0200 Message-ID: <1892628.myLnTpanUf@thomas> In-Reply-To: References: <1634842469-27119-1-git-send-email-vladimir.medvedkin@intel.com> <34793174.9LTJZ4FjZS@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/10/2021 22:29, Medvedkin, Vladimir: > Hi Thomas, > > Thanks for the review, I'll address your comments in v6. > Please find my comment below > > On 25/10/2021 19:02, Thomas Monjalon wrote: > > 21/10/2021 20:54, Vladimir Medvedkin: > >> This patch adds performance tests for different implementations > >> of the Toeplitz hash function. > > > > Please name them. > > > >> Signed-off-by: Vladimir Medvedkin > > > > There are some garbage, > > > >> @@ -320,6 +321,7 @@ perf_test_names = [ > >> 'hash_readwrite_lf_perf_autotest', > >> 'trace_perf_autotest', > >> 'ipsec_perf_autotest', > >> + 'thash_perf_autotest', > > > > here (tabs instead of space) > > > >> driver_test_names = [ > >> diff --git a/app/test/test_thash_perf.c b/app/test/test_thash_perf.c > >> new file mode 100644 > >> index 0000000..fb66e20 > >> --- /dev/null > >> +++ b/app/test/test_thash_perf.c > >> @@ -0,0 +1,120 @@ > >> +/* SPDX-License-Identifier: BSD-3-Clause > >> + * Copyright(c) 2021 Intel Corporation > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#include "test.h" > >> + > >> +#define ITERATIONS (1 << 15) > >> +#define BATCH_SZ (1 << 10) > >> + > >> +#define IPV4_2_TUPLE_LEN (8) > >> +#define IPV4_4_TUPLE_LEN (12) > >> +#define IPV6_2_TUPLE_LEN (32) > >> +#define IPV6_4_TUPLE_LEN (36) > >> + > >> + > >> +static uint8_t default_rss_key[] = { > >> + 0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2, > >> + 0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0, > >> + 0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4, > >> + 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c, > >> + 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa, > >> +}; > >> + > >> +static void > >> +run_thash_test(unsigned int tuple_len) > >> +{ > >> + uint32_t *tuples[BATCH_SZ]; > >> + unsigned int i, j; > >> + uint64_t start_tsc, end_tsc; > >> + uint32_t len = RTE_ALIGN_CEIL(tuple_len, sizeof(uint32_t)); > >> + volatile uint32_t hash = 0; > >> + uint32_t bulk_hash[BATCH_SZ] = { 0 }; > >> + > >> + for (i = 0; i < BATCH_SZ; i++) { > >> + tuples[i] = rte_zmalloc(NULL, len, 0); > >> + for (j = 0; j < len / sizeof(uint32_t); j++) > >> + tuples[i][j] = rte_rand(); > >> + } > >> + > >> + start_tsc = rte_rdtsc_precise(); > >> + for (i = 0; i < ITERATIONS; i++) { > >> + for (j = 0; j < BATCH_SZ; j++) { > >> + hash ^= rte_softrss(tuples[j], len / sizeof(uint32_t), > >> + default_rss_key); > >> + } > >> + } > >> + end_tsc = rte_rdtsc_precise(); > >> + > >> + printf("Average rte_softrss() takes \t\t%.1f cycles for key len %d\n", > >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS * > >> + BATCH_SZ), len); > >> + > >> + start_tsc = rte_rdtsc_precise(); > >> + for (i = 0; i < ITERATIONS; i++) { > >> + for (j = 0; j < BATCH_SZ; j++) { > >> + hash ^= rte_softrss_be(tuples[j], len / > >> + sizeof(uint32_t), default_rss_key); > >> + } > >> + } > >> + end_tsc = rte_rdtsc_precise(); > >> + > >> + printf("Average rte_softrss_be() takes \t\t%.1f cycles for key len %d\n", > >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS * > >> + BATCH_SZ), len); > > > > The function could stop here (one function per type of implementation). > > > > Could you please clarify what do you mean? > The function stops here if the machine do not support GFNI, and this is > done intentionally. On machine without GFNI it tests only scalar > implementations for every given length. No I mean you can split in smaller functions. > >> + > >> + if (!rte_thash_gfni_supported()) > >> + return; > >> + > >> + uint64_t rss_key_matrixes[RTE_DIM(default_rss_key)]; > >> + > >> + rte_thash_complete_matrix(rss_key_matrixes, default_rss_key, > >> + RTE_DIM(default_rss_key)); > >> + > >> + start_tsc = rte_rdtsc_precise(); > >> + for (i = 0; i < ITERATIONS; i++) { > >> + for (j = 0; j < BATCH_SZ; j++) > >> + hash ^= rte_thash_gfni(rss_key_matrixes, > >> + (uint8_t *)tuples[j], len); > >> + } > >> + end_tsc = rte_rdtsc_precise(); > >> + > >> + printf("Average rte_thash_gfni takes \t\t%.1f cycles for key len %d\n", > >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS * > >> + BATCH_SZ), len); > >> + > >> + start_tsc = rte_rdtsc_precise(); > >> + for (i = 0; i < ITERATIONS; i++) > >> + rte_thash_gfni_bulk(rss_key_matrixes, len, (uint8_t **)tuples, > >> + bulk_hash, BATCH_SZ); > >> + > >> + end_tsc = rte_rdtsc_precise(); > >> + > >> + printf("Average rte_thash_gfni_x2 takes \t%.1f cycles for key len %d\n", > > > > and here, the function name is not updated. > > > >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS * > >> + BATCH_SZ), len); > >> + > > > > useless blank line > > > >> +}