From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6D48A0524; Tue, 13 Apr 2021 08:41:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A371160B8F; Tue, 13 Apr 2021 08:41:03 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id F40D0160B8E for ; Tue, 13 Apr 2021 08:41:01 +0200 (CEST) IronPort-SDR: 3C18+v+SZ1K0IZ5wzrV1f/AO6GWRdPbU8q3LzVMQv8AvdxhVTbzlwddnf1Z2W8EDhSr49T16kJ Q7E2MNc4+f9g== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="191162840" X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="191162840" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 23:41:00 -0700 IronPort-SDR: 7CuYI0MlxA6wmnuVlIikQ8MShhnwYRVjQHsHV+OPMGYRCK5uXhu4wTX92+l5Tbyks+uCVI9+wI 2/MsDz0iikuA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="451824429" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 12 Apr 2021 23:40:59 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 23:40:59 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 13 Apr 2021 14:40:57 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 13 Apr 2021 14:40:57 +0800 From: "Zhang, Qi Z" To: "Peng, ZhihongX" , "Ma, WenwuX" , "Yang, Qiming" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter Thread-Index: AQHXJ2PDuwr9YEiG1ECZWbC5lrmdvaqxh/2AgACJAkA= Date: Tue, 13 Apr 2021 06:40:57 +0000 Message-ID: <18936a69f21f4d06be3194f312644665@intel.com> References: <20210402135247.20094-1-wenwux.ma@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Peng, ZhihongX > Sent: Tuesday, April 13, 2021 2:30 PM > To: Ma, WenwuX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when > removing mac filter >=20 > -----Original Message----- > From: dev On Behalf Of Wenwu Ma > Sent: Friday, April 2, 2021 9:53 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when remo= ving > mac filter >=20 > When removing the mac filter in ice_remove_all_mac_vlan_filters(), > TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, > it will result in a illegal pointer access. >=20 > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenwu Ma > Tested-by: Peng Zhihong Applied to dpdk-next-net-intel. Thanks Qi