From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9902C5942 for ; Mon, 1 May 2017 23:49:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 19AE6208D1; Mon, 1 May 2017 17:49:30 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 01 May 2017 17:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=2Zh45KxvN3fNLnr SVe3VGvAJQRzEujbugP8dmK9DqWY=; b=h+8/TtAQZ6NCBF1uEnRA2Su0uICV1Sr eDFSMNTGCqbo51/4IA8sQp+EVP5kBkwAPWUuP0+kIjaTExpQXVb4tEzghxWnR4pj nurXCXzhP+DI+rN5C/vS/b1rKxTYjJcM3SBKFACXJ23o9jW3PWCYODCv3hiiO1yM OdjI0r5nVb4I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=2Zh45KxvN3fNLnrSVe3VGvAJQRzEujbugP8dmK9DqWY=; b=CB6icmO4 locfR3n/0R18v1MnfjI3F6CWLKEK6wYCHC/cIp7rOiade3rn/MZADt8A8Q8JgWIO CrLDTx59/KGBn/mV4o5wpHTq41MqFI515V63jcsu6CNzVRDMPyPy5y1NrLWRs5bG PGk/lgZmLJHqUiNhxdfNZtHppSXkyY80cwveHRdMj95wl2/3AMrl2pBZD2V4QL9r B6VYiVCegEmNuBDvYnWa0BZxBRl0rcd5bwgcMxus9kujKPzzWPqYjHr9hdfKNevo xgWWZ0sEMB6fdxaytMBbzufDHxIGKsICvnWQ9t1bIgdG/4p11PyqII3Wxyv/GmPC iTfQDaTBT1fBRg== X-ME-Sender: X-Sasl-enc: rdSXUM5X8lSZV1G6NVpKdJGBnXRkNi9NgcGKdgnW0zll 1493675369 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ACD977E0A4; Mon, 1 May 2017 17:49:29 -0400 (EDT) From: Thomas Monjalon To: Michal Jastrzebski , Kuba Kozak Cc: dev@dpdk.org, harry.van.haaren@intel.com, deepak.k.jain@intel.com Date: Mon, 01 May 2017 23:49:28 +0200 Message-ID: <1896218.CXQQ0hTJZ0@xps> In-Reply-To: <29874180.MbnUNaIQCm@xps> References: <20170427144240.10188-1-michalx.k.jastrzebski@intel.com> <29874180.MbnUNaIQCm@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 0/6] Extended xstats API in ethdev library to allow grouping of stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2017 21:49:31 -0000 01/05/2017 23:34, Thomas Monjalon: > I am doing these small changes in your patches: More explanations below > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -395,7 +395,7 @@ static const struct eth_dev_ops eth_igb_ops = { > .link_update = eth_igb_link_update, > .stats_get = eth_igb_stats_get, > .xstats_get = eth_igb_xstats_get, > - .xstats_get_by_id = eth_igb_xstats_get_by_id, > + .xstats_get_by_id = eth_igb_xstats_get_by_id, > .xstats_get_names_by_id = eth_igb_xstats_get_names_by_id, > .xstats_get_names = eth_igb_xstats_get_names, > .stats_reset = eth_igb_stats_reset, > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -532,7 +532,7 @@ static const struct eth_dev_ops ixgbe_eth_dev_ops = { > .link_update = ixgbe_dev_link_update, > .stats_get = ixgbe_dev_stats_get, > .xstats_get = ixgbe_dev_xstats_get, > - .xstats_get_by_id = ixgbe_dev_xstats_get_by_id, > + .xstats_get_by_id = ixgbe_dev_xstats_get_by_id, > .stats_reset = ixgbe_dev_stats_reset, > .xstats_reset = ixgbe_dev_xstats_reset, > .xstats_get_names = ixgbe_dev_xstats_get_names, It is just for correct alignment. > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -188,7 +188,7 @@ rte_eth_dev_allocated(const char *name) > static uint8_t > rte_eth_dev_find_free_port(void) > { > - unsigned int i; > + unsigned i; > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > if (rte_eth_devices[i].state == RTE_ETH_DEV_UNUSED) It reverts a change you made in ixgbe patch. > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -185,7 +185,6 @@ extern "C" { > #include "rte_ether.h" > #include "rte_eth_ctrl.h" > #include "rte_dev_info.h" > -#include "rte_compat.h" > > struct rte_mbuf; > This include is not needed in this new version of xstats. I will remove also the changes to release notes (API section), as the API is not modified. They are just additional functions.