From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: piotrx.t.azarewicz@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix link with glibc < 2.17
Date: Mon, 25 Jul 2016 17:59:16 +0200 [thread overview]
Message-ID: <1896818.PTnbAv7U2t@xps13> (raw)
In-Reply-To: <1469444274-11595-1-git-send-email-thomas.monjalon@6wind.com>
2016-07-25 12:57, Thomas Monjalon:
> There is a dependency on librt with old glibc.
> The -lrt option was added everywhere it is needed but was also
> added in some applications makefiles as the first link option.
> The problem is this option is really useful only if added after
> the objects or libraries using it (except if using --whole-archive).
> And the -lrt options put after were removed to avoid duplicates.
>
> It was resulting in errors linking test application:
> eal_timer.c:(.text+0x128): undefined reference to `clock_gettime'
> eal_timer.c:(.text+0x166): undefined reference to `clock_gettime'
> eal_alarm.c:(.text+0xda): undefined reference to `clock_gettime'
> eal_alarm.c:(.text+0x211): undefined reference to `clock_gettime'
>
> It is fixed by removing superflous -lrt in app makefiles.
>
> Fixes: 281948b4753e ("mk: fix missing librt dependencies")
> Fixes: 2f6414f4baf1 ("mk: fix static link with glibc < 2.17")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Reported-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-07-25 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:57 Thomas Monjalon
2016-07-25 15:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1896818.PTnbAv7U2t@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=piotrx.t.azarewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).