[dpdk-dev] [PATCH v1] mk: fix external build failure

[dpdk-dev] [PATCH v1] mk: fix external build failure

[Marko Kovacevic]

Updated the make build to fix external build issues

Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
Cc: stable@dpdk.org

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 mk/internal/rte.extvars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 19594da..98c8606 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line")
 RTE_EXTMK := $(abspath $(M))
 endif
 endif
-RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
+RTE_EXTMK ?= $(RTE_SRCDIR)/$(notdir $(firstword $(MAKEFILE_LIST)))
 export RTE_EXTMK
 
 # RTE_SDK_BIN must point to .config, include/ and lib/.
-- 
2.9.5

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

[Thomas Monjalon]

05/02/2018 11:22, Marko Kovacevic:
> Updated the make build to fix external build issues

Please explain what is the issue.

> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> Cc: stable@dpdk.org

No need to Cc stable when fixing a bug which is not in a major release.

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

[Kovacevic, Marko]

> 05/02/2018 11:22, Marko Kovacevic:
> > Updated the make build to fix external build issues
> 
> Please explain what is the issue.
> 
> > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > Cc: stable@dpdk.org
> 
> No need to Cc stable when fixing a bug which is not in a major release.

Olivier reported an issue this morning, that my commit was breaking 
the build of one of our external module:

make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory                                                                                                                      
make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'.  Stop.                                                                                                            

The reason is that entries in $(MAKEFILE_LIST) can be absolute.

Marko.

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

[Thomas Monjalon]

05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> > 
> > Please explain what is the issue.
> > 
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> > 
> > No need to Cc stable when fixing a bug which is not in a major release.
> 
> Olivier reported an issue this morning, that my commit was breaking 
> the build of one of our external module:
> 
> make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory                                                                                                                      
> make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'.  Stop.                                                                                                            
> 
> The reason is that entries in $(MAKEFILE_LIST) can be absolute.

I know that :)
I was asking to update the commit message in a v2 actually.

[dpdk-dev] [PATCH v2] mk: fix external build failure

[Marko Kovacevic]

Code commit for 'make -f' support, breaks the build in cases where
entries in $(MAKEFILE_LIST) are absolute paths. This commit uses
notdir and firstword to ensure that only the local filename is used.

Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 mk/internal/rte.extvars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 19594da..98c8606 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line")
 RTE_EXTMK := $(abspath $(M))
 endif
 endif
-RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
+RTE_EXTMK ?= $(RTE_SRCDIR)/$(notdir $(firstword $(MAKEFILE_LIST)))
 export RTE_EXTMK
 
 # RTE_SDK_BIN must point to .config, include/ and lib/.
-- 
2.9.5

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] mk: fix external build failure

[Thomas Monjalon]

05/02/2018 11:22, Marko Kovacevic:
> Updated the make build to fix external build issues
> 
> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

[Thomas Monjalon]

05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> > 
> > Please explain what is the issue.
> > 
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> > 
> > No need to Cc stable when fixing a bug which is not in a major release.

Sorry for the confusion.
In this case, Cc stable is needed because it fixes a fix of a bug
seen with previous releases.

Re: [dpdk-dev] [PATCH v2] mk: fix external build failure

[Thomas Monjalon]

05/02/2018 16:45, Marko Kovacevic:
> Code commit for 'make -f' support, breaks the build in cases where
> entries in $(MAKEFILE_LIST) are absolute paths. This commit uses
> notdir and firstword to ensure that only the local filename is used.
> 
> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied, thanks

(please ignore previous reply to v1, the applied version is v2)