From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3543CA0A02; Tue, 4 May 2021 18:54:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11E614067E; Tue, 4 May 2021 18:54:58 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 08F1D4014E for ; Tue, 4 May 2021 18:54:57 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id BE5B9153D; Tue, 4 May 2021 12:54:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 04 May 2021 12:54:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 9NL85oQzCP9E7/rApvUrqHSveXHvn9u4cMAQr1APGwc=; b=fkFzzi31VYXa2Z4a KeW3PLhaNlO+1BAPePPIP/2RAExZynoNCua1z4ValCgODPZSGG5eJJgmtrYuswrD QBw3cO7pzdrSX65xPiSoC4RqSLX1TYSVAFHrfTeLkbBYCnbXcQzFWov9S0ZamnHV sQOt+47a3GNbXcalPe635GGKhBFr7YcwjNzQDo5ZnaC9bQEsQ9MzEjCJQB/1rjJy bWDCVP/e69W2QbudFEnZTzKhhmoVdTbej5DwPivscFIeQRHCl0nmfn9t7ZYrWRxW 8cRKBdGfecvIyJrPNZjILlo0lmiknJnXZrGcmzARSUMQUWvFzPVI2+U/cMYUgUPP QE93kQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9NL85oQzCP9E7/rApvUrqHSveXHvn9u4cMAQr1APG wc=; b=OwrvfftfhWwRlNkZjj7TtRM9kAjitdZ11sEzYsD53mlQPf22q89+4fY/f Z5gMdNaXIF8Vgq7Xg/p4Yz5FKekJ7EiRxLQbPLZuOKi9uu0uBcDjv1IKm+fbyYSR pxmq0h3f6VpUrCHch1l3ZvmsujRb4SOK3hgzOZdDsP8rpQW8/3Hn8TUaM5LFstng 05GlmZ0bbra2tnhLlbAtZymKZUGDp/y50WFLqX7Hny/TfiHFlxlBHFedKe/ECK8M SqMplIzwTWSaL5+G6VgMUejUxB4CluzrKkYy2wwRSl+NMAez6uJOzvUqkBh1XHvB J4mRtpMk8C5KvvZbt5AsjNMWGQw7Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 May 2021 12:54:53 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, jerinj@marvell.com, skori@marvell.com, stephen@networkplumber.org, anatoly.burakov@intel.com Date: Tue, 04 May 2021 18:54:53 +0200 Message-ID: <1898387.CditKv6shF@thomas> In-Reply-To: <1619663653-22771-2-git-send-email-humin29@huawei.com> References: <1618967837-2341-1-git-send-email-humin29@huawei.com> <1619663653-22771-1-git-send-email-humin29@huawei.com> <1619663653-22771-2-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" +Cc Anatoly 29/04/2021 04:34, Min Hu (Connor): > This patch adds checking for mp reply result in handle_sync(). > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > lib/eal/common/malloc_mp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c > index c7101b3..2e597a1 100644 > --- a/lib/eal/common/malloc_mp.c > +++ b/lib/eal/common/malloc_mp.c > @@ -171,9 +171,7 @@ handle_sync(const struct rte_mp_msg *msg, const void *peer) > resp->id = req->id; > resp->result = ret == 0 ? REQ_RESULT_SUCCESS : REQ_RESULT_FAIL; > > - rte_mp_reply(&reply, peer); > - > - return 0; > + return rte_mp_reply(&reply, peer); > }