From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F1B6A04F6; Wed, 11 Dec 2019 12:08:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7FD92C6A; Wed, 11 Dec 2019 12:08:28 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9E8711D9E for ; Wed, 11 Dec 2019 12:08:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 41B4B20A82; Wed, 11 Dec 2019 06:08:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 11 Dec 2019 06:08:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=oz4cQTF1S8ZeFM5OjYENHf57tfSuW0v1uVNL/Mhqp2Q=; b=gM8HGNr0U5sA cMigFfDatDTiavbCBSo6Video3Zr49ZdtQ50hx9bUeYPgbwSrAnM+Fc72MAm0gCA Lxsmz2xQAPLxZZc8+hlrSyDI6tfgYwEIcuQaIPeN2Km0nrtvTKhI+pcBZaxgp6RM FL6JEOOV1qIylSrvQAJ7QX0gz2VoujA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=oz4cQTF1S8ZeFM5OjYENHf57tfSuW0v1uVNL/Mhqp 2Q=; b=vZqDOcP+wN86hR8vVlHpxFWJg94iPkdnvkVM3yM3Fb1ebyj5eK3L/TX6K TbY7ZZnUazv7QbJLr1lDjbH4PYX6hObvMkQSyL7S+b40YDali1nYpJuhRsbaCJUv fJFdJn/33kEdw2s+9gyt21mSJpjQuJIAlrNz26pvvo8z13tRfjH2Lucd2ZfT/eMV 4hEl1aomAAusYCEPBBXVZedgofS4GWrRbtzUC+zymB/vLwFhIuO20u7tLnkuseWb dCG2Huai2Cr3ykxQLsqaVvyje5QF9Zz0WPl3qNTyuNk9myPLwbWBE+GTgZouxNqX /pN68Q8r5reDF6yCJENcZGiwjOGyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelhedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghdplhhisgdrmhhknecukfhppeejjedrudefgedrvddt fedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlh honhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 39F5530600D7; Wed, 11 Dec 2019 06:08:26 -0500 (EST) From: Thomas Monjalon To: Luca Boccassi Cc: Bruce Richardson , dev@dpdk.org, ray.kinsella@intel.com, ferruh.yigit@intel.com Date: Wed, 11 Dec 2019 12:08:25 +0100 Message-ID: <1899696.lD3V72zqS8@xps> In-Reply-To: References: <20191211102642.983579-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/12/2019 12:04, Luca Boccassi: > On Wed, 2019-12-11 at 10:26 +0000, Bruce Richardson wrote: > > The soname for each stable ABI version should be just the ABI version > > major > > number without the minor number. Unfortunately both major and minor > > were > > used causing version 20.1 to be incompatible with 20.0. > > > > This patch fixes the issue by switching from 2-part to 3-part ABI > > version > > numbers so that we can keep 20.0 as soname and using the final digits > > to > > identify the 20.x releases which are ABI compatible. This requires > > changes > > to both make and meson builds to handle the three-digit version and > > shrink > > it to 2-digit for soname. > > > > Fixes: cba806e07d6f ("build: change ABI versioning to global") > > > > Signed-off-by: Thomas Monjalon < > > thomas@monjalon.net > > > > > Signed-off-by: Bruce Richardson < > > bruce.richardson@intel.com > > > > > --- > > > > This patch contains an alternative fix to that implied by the > > previous patches: > > http://patches.dpdk.org/patch/63726/ > > > > http://patches.dpdk.org/patch/63728/ > > > > > > --- > > ABI_VERSION | 2 +- > > drivers/meson.build | 4 ++-- > > lib/meson.build | 4 ++-- > > mk/rte.lib.mk | 5 ++++- > > 4 files changed, 9 insertions(+), 6 deletions(-) > > Acked-by: Luca Boccassi > > Thank you! I've set a reminder in my calendar for September to revert > it :-) I don't think we need to revert it. The ABI version will have only 2 numbers (21.0). In makefile there is no change. What needs to be changed in meson?