From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB68DA32A2 for ; Thu, 24 Oct 2019 14:39:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95CD01EA31; Thu, 24 Oct 2019 14:39:47 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7D3651EA02 for ; Thu, 24 Oct 2019 14:39:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 05:39:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,224,1569308400"; d="scan'208";a="210152830" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.8.129]) ([10.252.8.129]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2019 05:39:43 -0700 To: David Marchand Cc: Li Han , Thomas Monjalon , dev References: <1571827361-30578-1-git-send-email-han.li1@zte.com.cn> <2500c9cd-3c06-bc3c-3826-cd8a20911da7@intel.com> From: "Burakov, Anatoly" Message-ID: <189cba1a-325b-63db-a14c-80c7029a9f91@intel.com> Date: Thu, 24 Oct 2019 13:39:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <2500c9cd-3c06-bc3c-3826-cd8a20911da7@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24-Oct-19 1:22 PM, Burakov, Anatoly wrote: > On 24-Oct-19 12:23 PM, David Marchand wrote: >> On Thu, Oct 24, 2019 at 1:14 PM Burakov, Anatoly >> wrote: >>> >>> On 24-Oct-19 8:37 AM, David Marchand wrote: >>>> On Wed, Oct 23, 2019 at 7:47 PM Burakov, Anatoly >>>> wrote: >>>>> >>>>> On 23-Oct-19 11:42 AM, Li Han wrote: >>>>>> In rte_eal_config_reattach(),the secondary mmap may fail >>>>>> due to the rte_mem_cfg_addr already be used by others.do >>>>>> the change just as the rte_fbarray_init() do.if no >>>>>> base_virtaddr,use the default 0x100000000. >>>>>> >>>>>> v2/v3: >>>>>> -fix code style issues >>>>>> >>>>>> Signed-off-by: Li Han >>>>>> --- >>>>> >>>>> Nack. There's a reason why we map it at the same address, and it's to >>>>> have all pointers working across processes. Remapping it at a >>>>> different >>>>> address has potential to break things. >>>> >>>> Marked as rejected. >>>> Thanks. >>>> >>> >>> Hi David, >>> >>> My apologies, I've misinterpreted the intent of the patch. I am >>> rescinding my NACK. >> >> Ok, I will put it back in my queue. >> No conflict with the work on >> http://patchwork.dpdk.org/project/dpdk/list/?series=5854 ? >> There was a comment by Stephen, btw. >> > > Oh, i forgot about that patchset... > > Yes, it seems to be doing the same thing, but in a more general way > (because i was actually fixing an issue on FreeBSD...). Let me get back > to you on this. > Yes, that patch is a superset of this one, so this can be discarded, i think. Apologies for the back and forth. -- Thanks, Anatoly