From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0066.outbound.protection.outlook.com [104.47.32.66]) by dpdk.org (Postfix) with ESMTP id 61919FA41 for ; Mon, 27 Mar 2017 10:38:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gh4fGlBvOBjiu+u82u2pW5UtZnkPgsr07+9XsM2WOfY=; b=BW/B0SRmLL4pa8lBlzfr0nwz0oXv5B7hpJpC2Q0pRG6ZVYzMRddrfPcS3IBQ8+AjhoewH3N+IbwXUYaRlu4b6CfuwgbmoLDrZ6DDgNVw766uFyX1R67JL622lKKIBkc3ViyZC+hcn6R3o8Y8FALdSnolDUAOMg6UIoTHq0W8/2E= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.0.75] (31.172.191.173) by BLUPR0701MB1027.namprd07.prod.outlook.com (10.160.35.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.17; Mon, 27 Mar 2017 08:38:22 +0000 To: "Yang, Qiming" , Thomas Monjalon References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1490356325-15434-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> Cc: "dev@dpdk.org" From: Andriy Berestovskyy Message-ID: <189fbba9-f97b-9bb6-e9fa-9669fd0ffa0a@caviumnetworks.com> Date: Mon, 27 Mar 2017 10:38:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: VI1PR09CA0068.eurprd09.prod.outlook.com (10.174.49.140) To BLUPR0701MB1027.namprd07.prod.outlook.com (10.160.35.19) X-MS-Office365-Filtering-Correlation-Id: 582ba68a-33ff-419e-4609-08d474eca123 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423042)(201703031133048); SRVR:BLUPR0701MB1027; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 3:/7PIK7zltirlrnOY8/Q7uVBr6AKsTG3MVbziAoBlYA0wAC+Vp6OSoNKG5Bo35lbQ3xCvamDwfP6elKT0pglOPabtTBouspC6wsaTBx66QV7pbW3Ux5VylRoI8cuginyY/aai7eMYNsSovQFqDt7cgUxFH319Tb/Gjxr7FOGChH3fjS1BuiA4/PCANFRVJKOUEUh9+ngGPRdT/uNFq9CkvwbiHjmWHm1/x2yAW0GlNi23sMf0D0KGt6/iKjUjspxctrYS5zVEHg2R5wpVVsPYDLEz5k8wYI03VFxDCdjiIBLb8Kt0lhHMI3WmmODMGwC9wQ6RJJfCKDRj1uj7Gq7KkA==; 25:qx/qtYbrIfPonzZaAt/wGeo3EQJd0sywpFG8UxCfCdCrcNthUsdVGeww62Tcyqqq4Wp2vRMIGLh9khBhYc+GTThYhyypKMzmmExjO8m3+mSctuXGeAkaQ82WcnHXxB1kc+fd4ED2g5QtlD8bP1cWLN6LYKP+P+AdVf5nAHcPoHKJ/6FCtXrOjz3pphhRkyLJCbooO57pD6sb5pJ+I92/n/POpL9XXDoSm07cipLmcF3q2H0obZZ82k0PsxHmdDnzmnKa8+bppoHAX3MT3hJAMmP496d+mR70KhyxeyrB7PyZwwmS7WJcjlgiYAVPM1FYedV/Uskn8dwvdpuLKT0TVUS5sYZwEl5hltPB5gYP5eSdLi+m2D5ATtl81AlyJ+ZWS0/AdUyQTUOgaP795VnTDT6YK8lZiZ5HQAcnocGKtv+tbwlG//Li+lTerLztpg+KXZ0tVamZDH1ahDByZgT0nw== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 31:3cPf+9FbmKxozh/tcgdqmwNmnOQk4vic3bQ/J9cZlHcF4KCkKdfXNL4obles3xu6zkg4qDhMTexdoG91ElpPTikcegQsFKVv71g1YpB4RxupiqlMM2xISzqjzL13QqU4xpco5aKOfYAvu/2+/EQOfrXAXxhNknykOp4IcpsYMynPc7imbM4U5bO5EzsVI8cX83GRD8lmoIACUYb9jwnE7UhmuHBLIaRMr5NNFpasdDsf09xxF33D8xMsc3hGrbE6vA2FJk3tdZmk6ZEejD+0kQ==; 20:nk6A5anG8JTJ4L5sDrvVrcdcHfoqEMw3dJ9N6YC1hzSCQ9E1v9xLjktQMp6JjqI9J6vfESfJ2analjHvNZYZ73fEtHWqP44GBU/rLPEBeVU9D53hAhtlldV2QLcuQnhsu2MAfCiK0AjxE1Dl4joDukANViLMbKOiNGZn2GUphXz9jt+sIOPnQrpGAKpMcsqJ5SlQociK/f6weWRskAuVw7aqUi3CAfMAHH8yNsl2C+FMOg/n0dPzynHrU93gACRDmD1ifKvXyBwGi3ydBBedupCmXQEhDyrtbHUMxs45RS9xPTbMC8uV/iKnyHW3uBQpTugSQO51rrNdv7Tpj3Ro7pNc7xu2PRejKCLQZmFL0e5IcDu3isGvMYuL6DBF21FZrN2ODBUzSSqeasmJwSthDV0SlgxKJBHZ49xBj5dZgSa2XTt4KvKqhWjWD3b2wqqsOSmBhaSijlOqftIg4Osd7yMUVJPW6omO15R0h/T9kYKabmxo2srAmVsv/yLACF3YOSj9y+RCwiiOLRLE+armjkNyj4aIC1muTGxUi9ynefJ2wIRkOGxlxyFoJG3I+PJ/Ycg9lJvQSw3sQsVgcBelTP3uE9dIWt3EhZiqfwfcCiU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040416)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123558025)(201703131423041)(201702281528041)(201703061421041)(201703061406041)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148); SRVR:BLUPR0701MB1027; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1027; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 4:/IGUOtbCKLm5ArN7FBZ8YrQtnG1KKMBPcKPkplRw1SoTU1G33kZJU7Y73nOihs52sLaamcxU1T6CzPT+dfSuEIe/rLWbTDZrEwzm+ME30PWrpT98gJrGmmI5AB9F+9/N4DklvhO9fEEM2BCg0u4fneEosEztChKfue63fZAUkJh9QQVY0MmDVFdg/ScNbDK2zo19ZcO3QfgLXb0DKwRc1Glzbs1LKdqa3th9yVXPhnkM1IUKxhLrED0XOZIDC5WUc5Ew6dRERzGxyJR/CnNGlGR0gw2aiPKZKACKqTwp+UiSjsBKas2MSfKxL469rmy8cdS5wX0g/Sy7ueBgnfuA7Vl4Znv/xEmoq+VaIFk9QU1EEKDUo6Dqohy9jCb8PUuBN4fGo0godsxDY54JS4XNOVuJP+Sw4pFGEgk7HxTe2htvqdlADrobEAXJ1j1ytawlVqLValaOKYysYErwy/TdVGRXu/ktNUkHGMS6eXd8y6FLyUvpZQyVbquAKlrjGb5WTW7Eizlmwksur6ah6Ot6woesTXKt1XegUWVIn/o3YYusaok/HsLQwS4smDNj30oc+6SIgLJhYC5l/5EBy7c29m/60i//npWQbwGQmcIVQJHjGK+2K5k5M/Pri8sETcUG7BiZBlAZM0HEMD5jJu/WrHxMCm2e2wnMHaJ5p4bmgOhiEmDfxvAb02DWeHWdYk4Qs0yhe9okj/XLkINgt/75Twe7251SD0iEZGFnUYEQZIWPq33AYH7NPIXHdYPBeQJU X-Forefront-PRVS: 02596AB7DA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39410400002)(39400400002)(39840400002)(39450400003)(24454002)(33646002)(81166006)(65826007)(36756003)(25786009)(2906002)(53936002)(47776003)(230700001)(8676002)(50986999)(66066001)(65956001)(54356999)(65806001)(76176999)(3846002)(6116002)(305945005)(38730400002)(6246003)(5660300001)(4001350100001)(23746002)(189998001)(31686004)(42186005)(42882006)(83506001)(4326008)(2950100002)(31696002)(53546009)(6486002)(50466002)(77096006)(7736002)(6666003)(90366009); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1027; H:[10.0.0.75]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0701MB1027; 23:5QOfJMHQwmP5SKs802Vd1Mryh5c2Yf13K9M?= =?Windows-1252?Q?bv0ki4V9pArv2kx6hBXtrD4nd/6hdyvPNOB616mx2z3C9zPMx/E0apU/?= =?Windows-1252?Q?Q24wlUl9WT8Ke1KjmxopyHoM/4aZUIyb/mV7RS7S90kSS1HO4SyhBNzJ?= =?Windows-1252?Q?t+Ckwmt/CYjJOEe3zNM9yUvvsQI/tMkQ/7qbBKqBxvJ7NWfDUYX1z57Q?= =?Windows-1252?Q?2mSM1VCnDDpyZnKaELgBuaia1OTrltNROWYJ9x/IeouCYwQBguja8eta?= =?Windows-1252?Q?5Hi1TUU2pMYu1PqGXSj+iPfmEEWAbRp7oZgHjf4JKZwwYEOMzL1ACICy?= =?Windows-1252?Q?xpdeXirXFwMn0wmJOzBHY/k1MLORvBUr7tuhd1YKf6kHmapKKSO7QySq?= =?Windows-1252?Q?aJsHQMlbBOuXbEFJCQ7IoAabBZ/liRbyRfX3aBHz6qReQThQ4DXurYnk?= =?Windows-1252?Q?RClJxCnZ2f5v+kcqItbVl2Mgb+2L/vhTTDxETHNBNCAL52FT8Vwnv4rT?= =?Windows-1252?Q?8Mfn3dvfBCVoGyt/Y927z7xYq2wddS9zSJxPbRKdPdrXNEemBYqUeZwQ?= =?Windows-1252?Q?NiMJ122WCkYNi5j4MAMR0+9lgpJJI0yEikX1GhZenw5tkxL61JaQeinZ?= =?Windows-1252?Q?ZiPIvPG1WVBwQRXOoVhfJ82pOkzzRZNN03NL2woVN3DyuQi8Ys76J28S?= =?Windows-1252?Q?eWQzeMfiXne1E+09tXQYvP0VdYt7KJemtaXHxXZe5jkw80SM54+Lzo52?= =?Windows-1252?Q?O7tr6IFMS4nOvtCUAzHdVsddxxtsZfWoFxLtW/FxgFouIwIt+DycQi+3?= =?Windows-1252?Q?5u/+03YrCLqojGvvLrwH9SfwpwrTlP+7ni1Sfw3FV/LCa6Xz1mwfgHIl?= =?Windows-1252?Q?pMEaf/15Nnjbn9fImxk6WzVddyPYIREA87eVQjMTCRQSL9iQ6RNL5w8W?= =?Windows-1252?Q?W74vViMlNf8sM3I3TaaOCKYbzugYb8VMK0pNUngUwi1A/2d1ZMubyUga?= =?Windows-1252?Q?LEp7cqoRBLDb8hxeMor6/OD8QTbjqvF4lNP7B+bTTcCfD9YLUqvciDX+?= =?Windows-1252?Q?TgtJUjK+wT0IfVHv0nGOJ9fqopTBHjUU1rnmnxWJfsSNd2M7NZVYMtnF?= =?Windows-1252?Q?0t8xUL7Q7eUtRcnw8oiE5CdwYKtLXmRwNEpu6MsDf8BnJR08P4Mvmfac?= =?Windows-1252?Q?TC1QUrXNpAcplStIfSrUKSKHom75irdhOKyb1LdnG144/MIfo26/UYDs?= =?Windows-1252?Q?v5N9pq4Q/jPw69evvxg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 6:LEpQvlDCy0joSw27clVWZoD2006Qc/vSxiGhqJXqYNt348vl4KT5+uUVNHFJojhLa3Yc1y+GfTUC8wlGvaMuDcLhHtMpcc/csVidJ7TBGvU8exCtlHqOsC7SDYALosu13/NRAnl7uesUwzg5uAmfAuPy/108YvmZ9Koa7wQUp0pmRCmZXmnTl5H7OPxJhB6wju//EA8tAU5+b5X5ttkA5yLfLFVZ5qAtP7MwdlBRaVhrpB1Bbf7GLQ4LsOJLEYVfXrGFfxmzjGpFFkWNiJRPMxxFSs76NDD+yiS50+w1dadFiEDTP/Yk7/yDidy2f0+6OAwu2OafiQ+F8pEqKN+S6PiXzvbHABfQn2e7tEhia1MOm+mZGdOcPeZQdnfBcrF4nurThsOhM/iP1/Ac2CXz9w==; 5:zn5N9w+1HLrrmOCVMYxpeZOUpWgws52tAlwLjk9dIG9+q2rd2wMSj0zAEUxNbZSjtJbHVI6kflQNr3FmclL+LYY9rteSHCVzZheWvmpU7fytf3ddm0WRa1tsQWjNpW0LTLFyx0cTmDvXLI/lGyrDww==; 24:zb+QxGVrgm5vMsDYbdNVTpajeghHyCfaukn9pKY7RfTruCgnxmZIQ4UFQpbKDSKhfrhTTZpLjuAm4DakkwYmbtdHLon74NyaIfDBbeisig8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 7:VgyGPMlGP1qm2Zi8z9gvo0DuIHI+OrDrdoy5N2ngBCtJKeedPWrDmTFZ6Vq0cFIVskUIVx5H1tY4cJ+lSAGAeqaC5QKADfnpxd2bNqWHeU2LsEuKFyYzyM0pfwZpao2ABIOr06MMaVpEfN4U7Wp3KkwxyjuuKT4qSC44KFUdVGh1DQUtrwOIdW72libXTD19kxh2gE5QZNKcANONoW+vaE17Mzi3eRqGMTNBUhbJd8TYAuTlqlHlyOxyH5rRA5pPEzI+ZtbQrXLUdd3Y/TFUzMshZPYgHDhBUURisFTkw2H1I++GZzO4ipV4c4cqs2RhJi2ODxCybDV0zDeOuOsbxw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2017 08:38:22.4223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1027 Subject: Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 08:38:25 -0000 Hey Qiming, On 27.03.2017 08:15, Yang, Qiming wrote: > I don't think this is a bug. Return errors when configure an invalid max_rx_pkt_len is suitable for this generic API. It is not a bug, it is an inconsistency. At the moment we can set max_rx_pkt_len for normal frames and if it is out of range a default value will be used instead. IMO we should expect the same behavior from the same function for the jumbo frames. So at the moment we have: jumbo == 0, max_rx_pkt_len == 0, result: max_rx_pkt_len = ETHER_MAX_LEN jumbo == 0, max_rx_pkt_len == 1200, result: max_rx_pkt_len = 1200 jumbo == 1, max_rx_pkt_len == 0, result: error jumbo == 1, max_rx_pkt_len == 9K, result: error or max_rx_pkt_len = 9K > It's not suitable to give a default value in this function. We use a default value for normal frames at the moment. The comment: uint32_t max_rx_pkt_len; /**< Only used if jumbo_frame enabled. */ is obsolete and in fact we use max_rx_pkt_len both for jumbo and normal frames. So the patch clarifies this as well. Regards, Andriy