From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 571B343900; Fri, 19 Jan 2024 16:25:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 401634029F; Fri, 19 Jan 2024 16:25:19 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2057.outbound.protection.outlook.com [40.107.93.57]) by mails.dpdk.org (Postfix) with ESMTP id 02C6740279 for ; Fri, 19 Jan 2024 16:25:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D/VUJE1qOMARBg1AGSGApTlwVEMp7zbKFg4dJtDx2x+RdWQqu5Vu+H9zYH1SM7zcp4RY57x0xywsR80gUTf1RZZv8dpkk6STnWOc0KbkieZXYRTPxfiRfj1ZNVAu+sqHoCcJJHanwn1iHq29QgsSxu69FEIbIiWupUPqlUBvp7o+SACUljmEpHlJ0WU06CfMcMM3FowJ56TIZDvJYMAsbxA6KEntcpvma9r2c4Zxzt17eKNy1Z+eL7MrNZkGpkYVsARAdYnqE58nJte8uI/IqXarfMZceL6sxEvlyuuWzOLES7SPvqh5Gxz27P+97MtXEEo8AafKCr9VQOA5Y2hklw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GM1jC1sBRgMdjhgGIpJi6lHD+JyVoOMkJ2Y0mzzQ/Kk=; b=PapKkcYpDlQuA1iTrwb7CsS8PEma0ZeDhKs3CBHBEharRvScB5ofDtHG8Jk2BSM01nJzXhH4fDgTmQD3udSHm2ssAh6SmROXknt0uFMfMDXHzrgcnsepeRV87u5rfyXUZ323nZHOnuXmhMaDJ/+I9YMwXSGgHkoZ7iv+9XKZRrIivlkjvJxGogX4L0UvH7oLY4c0GAiXWuZvfryzMR2A80XhM9qfrFOqF8GvU2Z2Xp/hbSCUCvko2EPQamFbI9K7tsoEZDGEoE/TovJJ8UTOETJiZ4UiM438Guc7C4X6yXtKPMFwwLuM5iFEJeae2klIvga50Gl5Y/TfyJHJmImMGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GM1jC1sBRgMdjhgGIpJi6lHD+JyVoOMkJ2Y0mzzQ/Kk=; b=dCOjKOwocFWgFrRh3HRP4ZN6XdyyplhquFvMv4EGLJ3P+kCCdKu1tKYndP0Uc+Zst0ZOh3jPAYfxNMx3woHSzX6tKHayACXbP3+oVVCMIq/hLGMOFQcZm5NmvFLLQe9B83GIo49ZUNtAfFjKg+4nH2Tv8Kof45A/+t3s9dsywvg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL3PR12MB6547.namprd12.prod.outlook.com (2603:10b6:208:38e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Fri, 19 Jan 2024 15:25:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7202.027; Fri, 19 Jan 2024 15:25:15 +0000 Message-ID: <18ba2c41-1288-41cc-8359-b93570701126@amd.com> Date: Fri, 19 Jan 2024 15:25:11 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [v3] net/gve: enable imissed stats for GQ format Content-Language: en-US To: Rushil Gupta , junfeng.guo@intel.com, jeroendb@google.com, joshwash@google.com Cc: dev@dpdk.org References: <20231222153953.1266615-1-rushilg@google.com> <20240119142650.3504824-1-rushilg@google.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240119142650.3504824-1-rushilg@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0238.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL3PR12MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 3fa302c4-5d3f-45eb-25ae-08dc1902d618 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wr2WeGjy0mSC6aVKuBX3x60ZwnuL0dTgM46anyF1U5pASa0KfmheOA1iBe01vHZ0sTz7H8MEk0KLWN2r+8aI4/ek2tacDZL0oykJHZZwgPuy3533n+KHaHzUhicHTb1ySolym9cosJj56qrdh7/p5DC9Bd+y31bjkaXMxmWwGv52K2IOSLo/eS/WxGMUtd/9giECzNWIfyQNI4fqmjZ38sPJG8Pvr21o6qypLUdp+QWBGctNwzPAzQtm2uZ/FZXMjMG9HpCn/u/lpFWUTb1t5YWU/I5v3l+FJdWr5X2TZ+mDM6v6IOPSZNPGPQ/RIH3PHE24x2Vjt/E9fUaSZhUXW5ieuQ22Sfn0axoZ9W3S4fZ8ZM6x3JK0e8WrV3qhSBM/oWiOX4mG1QopZ4095mcstfGjlTCltk9ChY/gkY7gpEJ7IL/gVk/uL6jC4GXDJqZzorH0iTNC0c6zZcCstd+YRPXk9supf8XzdL+Qb+/4RyxnQ1cfu3neuA7pKSIuGIxdTFGWcKF+4wzYVQwnQyXijwgciITIeuPvO/7SrKlF9oPhKTYwegAK/uzTpsHWklpcrrCKMQkll1OuDYR6bUT7spPsDmtp952dU1ZzsVlkYSWvUnDHBYnP2WdA3vPADoox/swA3FCY+XtwgUs/NdrK2Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(39860400002)(346002)(376002)(396003)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(66556008)(66946007)(66476007)(316002)(86362001)(2906002)(36756003)(31696002)(8676002)(4326008)(8936002)(5660300002)(41300700001)(38100700002)(44832011)(6486002)(26005)(478600001)(6506007)(53546011)(31686004)(6512007)(6666004)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTV1VHFpQ3lGSENMUTJlcGF3L1BsNlpoRUU4cGFDeHNVOXNUbkZpY1pHZitp?= =?utf-8?B?Nkd2Z1F1SXlaNXpCbWNNZ1ZzYStBMS9HVkt5RVlYSzhCaXZ0NGU4alZvRWxB?= =?utf-8?B?UjJqK2FXR29PZDI3MGwvVDZkOVhrdmVmU0R0S0RYVGQ0L1JreXA5M0hGZTlF?= =?utf-8?B?ZVpjelNUNnBnOG00OTF3T0ZpL2NISC9TczNDd0VqVTdwVit0aklxdC9KamN5?= =?utf-8?B?MW9GbjNsRmRnYlhwaUxVK1dzNjB3VkhOVDRTc09jSG5XekRVSzdMaHV0K2l6?= =?utf-8?B?RzZmcjArS2x2N2xwNVN1ZEdWSmwzYUNBaTF3WWRyb2dzTWxUU0RSYyt1Uk5P?= =?utf-8?B?Tnh5c3RQVktVL0xiaHBSdko5TEF0VDRLR0tJWmZLcXpiUU5GV1RGWFFsYnBw?= =?utf-8?B?SXkwZEh3NVF6RkpoVWpUTFJ2TTVsUnNKSUR1Zk9jaEVGY0NxU0xSNnVaK2RK?= =?utf-8?B?RDZvRnM1S2hUZFYyanJuZTZYemVGY2YzWVBlanNYWENCTkhlR3N6UndQbGY1?= =?utf-8?B?RzJCWWc1YWJ4dFN2Z1ZETEl2V2RlYUhpcURTbjNrbFN5RzhsUEtDYTExL0kz?= =?utf-8?B?Umk3V2s5VHUrYnQ2QVF3K0NMR21LTzRRTytYUVhyNW9EazVPNzFJWGRoWHhW?= =?utf-8?B?L0NMNytlUkphQzhjSExZREFrTXFYQ3duRFZJUUN2TXdFY01OMHhVWWRaRm1y?= =?utf-8?B?SzRzaHMya0VyL092UFIxTy9HK2hxdHpUclR5SktQRnh0ZEgxTXFwcEVlQk9o?= =?utf-8?B?QWlMSHFRR3A4dXhuS1J6cU5sUG1oOHJhZnNtNnBZNVJnNExYN1EzMUU2L0NQ?= =?utf-8?B?dDlFSHpBb1pUTlRESTVnU1pKMVQrN2YyT28rcHpFemFTZUVCWXpYQWJiQWhk?= =?utf-8?B?aFVHWUtTQi80UE5oYmVZa09QS3ozTkRTQVlub01DNmVMc0ZsTFdmREdIQ3dY?= =?utf-8?B?OW5iU2taQm9LM2srbnV1L09IbmlNd2NvRGJIVS9oeTh5dEYxRVF4Q2xNVVYy?= =?utf-8?B?Y1ZCWTJnOFg1WlFxQllNTkUvUVdjMVM3SCtXUE92N1dYTUFMYWQ0ZTVpRkl1?= =?utf-8?B?VkhUUm13RVM4SUpMWTFiM05xN0ZOWms1V2c3RlA2WlBSSVpKRTJxTGNyKzNs?= =?utf-8?B?ZmdNZGJyU2VyL3U1aGdLNnJaajJLTkM1dlloWWpybkFJUlhsRExFdE1nUVM3?= =?utf-8?B?NWs2d0k1LzFMSm5hTGMvTW1qc29tL3k4dEF0aktQL3VEc0pUN2VUSHZmUmRq?= =?utf-8?B?K3BPOEczR3NaTFp1L3d4QXVwNmN0UDcyY1dDeXdIWmtQMDM3S2VjTk5hdnpu?= =?utf-8?B?bnhuMEExek9kWm9oNnR0OG11Z2tFV3Zmd1BXejErd3ZJdkU4c0pkVmFaSEFW?= =?utf-8?B?dU41RTB5UDNGb2g5QUt2K0tENWtyN2lyMXdqYWZxTVAzbGVHcjMxYzBISW1M?= =?utf-8?B?OHBkQ3BmT0grSWNYRmNYTDh5c2huK3pYU2oyWFlJSjhvQ0E1MGhBSTFuRjcw?= =?utf-8?B?U0dvd1VKaHNiZVpzQ2M5Vk1sSXFPdmpHYmlZZTRWVkFDaVd2ZTRrTll0b1Vy?= =?utf-8?B?aVdHZXAzWkNvODIvNStvNmYrSlE0RkszT0ZMY2xIbmJkZnk0c2VLU0JaYUdt?= =?utf-8?B?b3g3ellFWDFYS3VRMS9yQVRsaWFaUllvdktMaHREbk83T0VVOFV6elBUM0x3?= =?utf-8?B?SU9qaDhZOENPTG5XNFQ5OGFpUTJPZTF0U0JEZDQwaDZOTnRnSzQwWVhDTjBS?= =?utf-8?B?bERmbHdIS3pseHpha3FCdFZJOU52VnUrRzIvQWVIUnpNNFdWQWllOUYrZDV0?= =?utf-8?B?dDJ2OTlza21zTjNGdnFQYTl6cXVIMHFKYXhGWUpKWEtRZEk4eHdyalY4OStW?= =?utf-8?B?ZWlHeU1jUlpYR21PM3ZCalFNQ0pERnVPMHVMRXk3aHJDTXpoazV1SEI1UVNl?= =?utf-8?B?Q0RtQ2p5OUpFeEpDeGd0Q2prYUxiOGFoemlDemNCV3VKVDJESnlpRCsxNGx6?= =?utf-8?B?a1dUWkFBQmtZUUdXcHlKR1MzWmErTXU3SjJ1L0dMbmxJYmU5WmZmZkIyUWls?= =?utf-8?B?ODRSWUgwK2hDaGtpVTc2U0ZtKzMyRU0wOGd0aDRMOXorRXJkK1o4ZGdmRlF2?= =?utf-8?Q?35T4yhdb/6G35ZoGNEFw5/qhI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fa302c4-5d3f-45eb-25ae-08dc1902d618 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 15:25:15.4269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GCugRORVgKuWIDTajNdogDEbrQnDjqPDO68ZNedtCTJpAe31FN3lXWH58y6e5ov+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6547 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/19/2024 2:26 PM, Rushil Gupta wrote: > Read from shared region to retrieve imissed statistics for GQ from device. > > Signed-off-by: Rushil Gupta > Reviewed-by: Joshua Washington > <...> > +static int > +gve_alloc_stats_report(struct gve_priv *priv, > + uint16_t nb_tx_queues, uint16_t nb_rx_queues) > +{ > + char z_name[RTE_MEMZONE_NAMESIZE]; > + int tx_stats_cnt; > + int rx_stats_cnt; > + > + tx_stats_cnt = (GVE_TX_STATS_REPORT_NUM + NIC_TX_STATS_REPORT_NUM) * > + nb_tx_queues; > + rx_stats_cnt = (GVE_RX_STATS_REPORT_NUM + NIC_RX_STATS_REPORT_NUM) * > + nb_rx_queues; > + priv->stats_report_len = sizeof(struct gve_stats_report) + > + sizeof(struct stats) * (tx_stats_cnt + rx_stats_cnt); > + > + snprintf(z_name, sizeof(z_name), "stats_report_%s", priv->pci_dev->device.name); > + priv->gve_stats_report_mem = rte_memzone_reserve_aligned(z_name, > + priv->stats_report_len, > + rte_socket_id(), > + RTE_MEMZONE_IOVA_CONTIG, PAGE_SIZE); > Adding 'gve_' prefix to memzone name comment seems missed.