From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F87243FC9; Tue, 7 May 2024 18:54:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CED3E402DF; Tue, 7 May 2024 18:54:27 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2068.outbound.protection.outlook.com [40.107.94.68]) by mails.dpdk.org (Postfix) with ESMTP id 3EEF4402A9 for ; Tue, 7 May 2024 18:54:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SE4GaqQ6RGePcftkHy/GZmYI4ga7kkMO9UucCGdM5ev1RyabiBqhi0v2YXghEPXkuxlvXNmV/WzA7ucjdrCJlAs/lzSRLNzPHpOzfI+gWo9qJkbhs3KOq8ljxJF06lLOrG3WaI4b6HmQKl1xu5/PeQ8t2KnCO7S0SkzsN4f062y3wPWSutqca6RNqEQE48irA5QGGJ2LHG8xBi8lMLyWOkvVPsuTlZTDXR81Kp32mb1iDWvfJ9Jq8ifw09MhnUuwe0VPEyv70aUElVPH14FKyRAiIRbQHch6QhD1cJKswGfl7RmIDI8+VMryAgsMhEhmQQl4jHUs2E+8/JYmfSInRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lQ68kGib03V1cVvvMVrCKzEFEHxqQDzgqwa1XeIZiQ4=; b=IYKU93Tq4DfsiWwgw44ZHYzd9wAcLa0kZYgN8JnyBw5vpJFWPg+g9J/UqS2w0EqFUrWBUwx/AlBStgfrWILi3SnJRcx3Svn59iee5mGBoXwrrAtyCs8HIsCUkVCf441znKF2XZODPJjhH5O7sYpUCah34ftii8DNNd65Ufjzv+rQzCHQXEJMiyAxpushPxrGV751dddyo8eoq4l7qTHYEgrG7wNMtVyZplFU+AsJAGNAneQCrck9w/6bHbLgg4Ik7i+5k62sZ8VQKFtjrMpBheP1xbEiRFnOVZoSG47vCAYx71bkM+DfACkyjsiDWXvzdbn//YVCQPt7zKjV5yVQyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lQ68kGib03V1cVvvMVrCKzEFEHxqQDzgqwa1XeIZiQ4=; b=jqEi7wL/AWwAH/FSTxgPQHwmSfTByfbeq5Z5cVA7AiZ7un82Dtqm0aXM7AZEmLwtGV4nLgq/43Qca5KYIgF49lYkJPmN+klW4AYjliAY5eBomGXxdal2ySJhrpH6AuMfbjnJxwe9YHxJ1vihULuFGwuI6K9mi7DLUg7Gb42dblU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB7643.namprd12.prod.outlook.com (2603:10b6:610:152::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 16:54:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 16:54:23 +0000 Message-ID: <18c1a9ae-4713-4a2e-9759-c6b240cbe926@amd.com> Date: Tue, 7 May 2024 17:54:18 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2] net/af_packet: make stats reset reliable To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Stephen Hemminger Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "John W. Linville" , Thomas Monjalon , dev@dpdk.org, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= References: <20240425174617.2126159-1-ferruh.yigit@amd.com> <20240426143848.2280689-1-ferruh.yigit@amd.com> <108e0c40-33e7-4eed-83de-eaedee454480@lysator.liu.se> <238675d1-b0bb-41df-8338-a1052c1a88c1@lysator.liu.se> <20240507075128.36484b4b@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F423@smartserver.smartshare.dk> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F423@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB7643:EE_ X-MS-Office365-Filtering-Correlation-Id: f9265a49-3859-42b8-0f43-08dc6eb658a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bjdOUEY2dHJ3aTJTUE1NTEJXblBta0VZRTNMTDlZSy9wNlpFSlNzM1c0MEpv?= =?utf-8?B?ek8zR0RuandRRWNQRHF0eWI1U25wWCtjWGh2US96b3R1SVRCR3NDNk41ZXg0?= =?utf-8?B?YVEyeGorbyt0QWtvNE1PSEFsb0UySk9MSkJ3VC8yajZ6MjVuM0dOUkdnTWpM?= =?utf-8?B?UkpBMEgxaEEwMzNkbExkR2ppT2p3TjlSQVh1QzdzazY5MFBLZnh3OFRTRlBa?= =?utf-8?B?VUpzVlNpMkdOYmdmci9iY2taMHhNOCs2LzdFeGF4eXZwWjIyV2RrU3BaT3Fy?= =?utf-8?B?SHkxRzdwMEREMHZvMkZETFBBY2RiZHE0WmpWSmU2M0VEbzhlU1I0ZkdPUDRw?= =?utf-8?B?Q2RINXdtWDNBL3Vwd3dpMlQvY2VOellVc2hhTlR1OXZieWoxVmovcjZyQldp?= =?utf-8?B?ZnRiMmR1Zk5IT0EzUlVzK2wxRHhRMytkU0dLc25CVE5TNmZmZlZsWnA1NGhO?= =?utf-8?B?Wm8wenJ2RnM5dFprVVAwMFJnUm9LVlZYcit1MlZzbXJHTW9mcFJzeHI3Yk94?= =?utf-8?B?Q3E1QjJMVGpPVUhXTXlTZndJNEtJT3VJT0ZnNThFbFlGbHNIRDdHdWJZL21w?= =?utf-8?B?ZWNJRTg1ZzRTWFh1VDlKamVkRDBJL2lLNnYvZkNCRkl3RzB6MlJydDcrTHo2?= =?utf-8?B?cGprMjZjZm1NNytLSXA1V2NqKzcralJQazZwVCtxY2pwWWxIT0o4WjY3bUZw?= =?utf-8?B?M3hwQ3hUVzQ1Vm5YN2dvTUZmZ0FUbklKZkozcHZYekFLWTlXYUdUVy9tVFJk?= =?utf-8?B?Y0FMd3FFTEdFcHdONXJpdEJYRVhMcTN5THJjVWViSnl6QnBNYjJncFI2MEJH?= =?utf-8?B?dEdKcEw3Y2FxSWNZa3ZHNUw5K2VKRWRGTjJSVVhGZFNabmZhWk5tZkNCeFZT?= =?utf-8?B?M21QVGYzaTlISkxPbi9ialpkZmV5VGZCYlJjTEtRbTdmTSszazhXWFlBTFli?= =?utf-8?B?OGg1a1UxM2YvQjczako5VEh2Y2tRd1dYaTRDR0Z3RjFINURlT01TOGxkOElX?= =?utf-8?B?V0d2N1ZKYU56VUlMdUhJZEFJM3FocHlOMEd0SmJaU0VXVnp3SFZ0QXFERkp5?= =?utf-8?B?TGprbVJlSWs3OVVzZU9XQm9hNmxvcVlHQTJmbXZuVWx1VjhpWXloRmczUUto?= =?utf-8?B?SzQrRVVNNzlBditWTjByOUEwSVEybnhVODYyWFJPZFdXTzY3bWprWWswdXVs?= =?utf-8?B?SHorUnBoRXgxMVRkREVneFY5M1JWNlR6ZWFWUTBkZ25GeC9KZHYwRE1YTWpt?= =?utf-8?B?ZU1FL1R5V2R0ZEw5Y1ZqL2xJKzN5MFhQMGFpSDVsTlBNQzd2azk5SzROdVl4?= =?utf-8?B?UmN0ZllpWXRka2ZmZ1VBLytSSjAwZHo1TGd1dTFFU0lJQ0lFS2RzQmQ0alBP?= =?utf-8?B?cnlVT0FOSE4zNTBLYVBOOHF3UlFoRE44d2xZaUoyTEdnSTdFZlZJSGxHZTRs?= =?utf-8?B?QjEydm4zeWlyVzJld05YbDd1aTJTOC8zQTN2bzV4YzVLdnZyeGtFOEtYR3Zu?= =?utf-8?B?Q21tNUZPZGRSdU15OFphRXd4ZCtycWhlU3IwSEU2RzFXWVB0dXNpd1lVZkFI?= =?utf-8?B?RFZTczZQSlI5Qzk3YUs1NVEwUVd6L2JwWloxdVIweVp3amJHaWpQa0phNUdB?= =?utf-8?B?R3lCTVNNOVlJYllvcGpDaFVPMDE3VnRIb1g4aC9kZ3pndmNWUE5qSVQ2cjVx?= =?utf-8?B?N2sremZHZHVSWFNMZ1dJZ1h6SlV5Q1pBazdvR0YzeXNQWGNFZVB1ejNBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmQ1bkpMOC9zVnpMOTRmU1VXa3NCVmtkbXhnYWZ1dHcwY2JyY3N5Q3MzUWhm?= =?utf-8?B?bmRXbGY3Ui9sZzhJWHROcWplclZSd0FrWWVSOWl0WGh6VHdYVkg5VzNKa0sw?= =?utf-8?B?eFh5V090NFlTaTJVbENCZmJydVZrM2RweUxtd084Z0doc2l3WllOQVpjUVE5?= =?utf-8?B?WlpIcjE0ZnpoOFExM014aTBjZGdkMjhqWVFXK3AxR0QrWEhTM2FiSHozeTRN?= =?utf-8?B?NWJndEt5Slp6T2V2bDhzWmtyRGRFY1ptV2EwKzNkUUwxWC9jY1FoRDdTZzBp?= =?utf-8?B?Y2Y0d1RHWmt1YVIyOVFBVmE0ZnFRZ1ZqWXM5TllVRytFbi90TW8zNmxPRmpa?= =?utf-8?B?SUJhcTdWMWNPWHRxTUhXVGJFVFZWdGovYnRsSDQ3dXpnT1NLSVB2Wml2L0ly?= =?utf-8?B?ZHd2ZTJ0Um9Sb243T2Y4dWxHWG02byt2V1Y2dVhDS1g2dE1Gdkc5NlNlV3hx?= =?utf-8?B?dDY2b1ZJRkNlNktrcnovaXJid0ppaStWZHFJMisyT0RsRGFCTmlpMW1ldlIz?= =?utf-8?B?Y0ZwaXoydWFTb0hNRU5qd3JhbDZwa3B0TEJLVHNWbW5MMFdUWTdSRnNvMkFG?= =?utf-8?B?L2dwUEJ0ZmZnKzJ3b0s2VU4rd2VNVW9raU5Gb2tlTnlvNXpQbTNUTVJPWnQx?= =?utf-8?B?aHBnR2l1L29mbUgzWkF2K3BFUVowREkxVVRPdjAzQk9mRDNFR0E4Z1h2Qmw2?= =?utf-8?B?YVN6SUhDeTZhRXVtayt0YVltT1I1T2hyNUZKZmtQWGdMS3VnWHdUK1hrOSth?= =?utf-8?B?Y09EWkozYVJLdTgrdGpxdEhWQVBSU09Bc2pndkQvTFErc05lSnh0enRTbEZ0?= =?utf-8?B?bFZLNU9KR29yUGxHNE9FU3NvcXBWbDg5QWcvaWhHTDB2d2xQdFcycDI1VlR2?= =?utf-8?B?Y3RkcmI4OHVSNjk1dm1aWmdXTlUrenRxdUpPVGE2V0FFOEtGa2RRYU5nV2Fo?= =?utf-8?B?SWtUd09YSHlJZStEUVZ3cmIrQWpBZkJNT3NSYW9DaGQzRi8zenJ1UFVkQWht?= =?utf-8?B?VVZOcTdoY0RTZ3dRWVpxTjRGT2F3VzgxQjBFNWkrRmkwYm1mZ0UzOFJNcE5q?= =?utf-8?B?SDA0U3dCdCtPSWFWWTdwWTFJa1JKbW5ZaW1BUUhrUUJ6RVluU1RrbmlaOVRq?= =?utf-8?B?R0toMmdBaXVvdmRxRkFlVzVvWWxMTGRSTTcrQ3gwWG9MZ3ZCT1ZRdnVCZmth?= =?utf-8?B?Qkx6aDhnSUNRRCsremMrYWQ0bzNQWXhaMGhCYVUrdTVtRUhlbkRuQjc5RVYr?= =?utf-8?B?OTZEQkpmbUprVnc3QjlyRjVPYVdGNmY5NnYxdVZoL0ZHWlpEUHZzNzQramVW?= =?utf-8?B?a0kreGszcHJUazNiSHd4bDEzelpmVTRJOU1BZCt0ZEJxZHFFM0hMK3JjUUk2?= =?utf-8?B?VEhxOGJGZDVadStBTXVxSTloaFJHYkNOK2dGVUpiRmlodGtKYkVJUktrcVRW?= =?utf-8?B?OEFSQjNjeXVpWi81VWpIamlTRGRIeDJ1dHMyeVZxY0lqalkvM01NQ1V2ZXpG?= =?utf-8?B?QWhZQ2g3OWwzVkh4SzBJaDZCUWZCOG1tUW1SOThmZ2V3aHF5SGZ5Z3BGdWNI?= =?utf-8?B?a0FaeEdMOG1tb3VmaVFEVFY2WHhDZEZTNm50S2ZnbkNxSjdDRDN2WGI4aTZj?= =?utf-8?B?TGFjdUhGenErTFpCeGNmT1BReDZaOWI1d1VIa3pKbTVxNmJRZVM5bXdLZ1pM?= =?utf-8?B?KzZtNlNrbGRiWTUxZ0dydlZrUlkzRS9jZW5TZ2M4MlZkUjBlbktBaURESDVt?= =?utf-8?B?bXRxTm42SWJwU25LMEorWU0xR1IrTEFUbWZjSzdlVytUZ1BvTVBqRWlxcTlJ?= =?utf-8?B?bHZjeWN4NWJsVlhsY0N2YkVqTFEvUk9yM1h0ckMvR0c2bW1ETndkdjVpdVFG?= =?utf-8?B?TllwSmM1eERsdTFBbzNWRjhZOTVjY0o1dFV6L25aejViSVozejl3alFpZUkx?= =?utf-8?B?MWJ5NGYrcmZONGplSVhabmxpNWo1S0ZBMnQ0bWQ1RElXcXl2bllrTXU5OXdI?= =?utf-8?B?b3BOMUVwTWt1dXJUQmFxYTJYd3VxWXJTMlJpSVliNmVSR0dvVlR3NTgyRVZW?= =?utf-8?B?Mm01Y3huL3NpenZpVWhITkZOYzlmRmszQXBTNGxNQit6Y1V1U215NXdKbzd6?= =?utf-8?Q?nzb7Ah+cX773m9DdHA9lUkz6a?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9265a49-3859-42b8-0f43-08dc6eb658a5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 16:54:23.2908 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /tO1OsDk6tcZUGtEQWoPMMIU8S8ohLzgQ71nGjecFI8vSM9bHh5PtIodO2fV1VVS X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7643 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/7/2024 5:00 PM, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >> Sent: Tuesday, 7 May 2024 16.51 > >> I would prefer that the SW statistics be handled generically by ethdev >> layers and used by all such drivers. > > I agree. > > Please note that maintaining counters in the ethdev layer might cause more cache misses than maintaining them in the hot parts of the individual drivers' data structures, so it's not all that simple. ;-) > > Until then, let's find a short term solution, viable to implement across all software NIC drivers without API/ABI breakage. > I am against ehtdev layer being aware of SW drivers and behave differently for them. This is dev_ops and can be managed per driver. We can add helper functions for drivers if there is a common pattern. >> >> The most complete version of SW stats now is in the virtio driver. > > It looks like the virtio PMD maintains the counters; they are not retrieved from the host. > > Considering a DPDK application running as a virtual machine (guest) on a host server... > > If the host is unable to put a packet onto the guest's virtio RX queue - like when a HW NIC is out of RX descriptors - is it counted somewhere visible to the guest? > > Similarly, if the guest is unable to put a packet onto its virtio TX queue, is it counted somewhere visible to the host? > >> If reset needs to be reliable (debatable), then it needs to be done without >> atomics. > > Let's modify that slightly: Without performance degradation in the fast path. > I'm not sure that all atomic operations are slow. > But you are right that it needs to be done without _Atomic counters; they seem to be slow. >