From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07FDE43C2C; Wed, 28 Feb 2024 17:53:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B9EB410D3; Wed, 28 Feb 2024 17:53:32 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 0445740EE2 for ; Wed, 28 Feb 2024 17:53:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=med6tDtOFmmpZqDB4elIVat4XAK6e91vTNX0g+qvJIkKbsv52hYa7FQ6PsLaKkzPAq+LGyXFTaWwz5tXgupiPlj9dS+bvigyd795P4kN/+0x8f46YXqdiWjAGSuJVScsLlIQEioJ4HWvx8EjCT02WBVJmBfe9tHBq+e+pAyyF2cwsQUM8593k8Zqx61tD5Hd93cdg8MWL804xNVXoNcZHSB0NavtlwWcD0X7C+CGnLKL+LXRiN5jkr5ESTLXvpzE8dblqmeehqGumCLkR6SqFLP4GnU582nybk5LYH9k4hZnNXlZ9i3bus+t5j9zdlFowRyUaYY/9rSKZGdcflVlXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qpmJjmbqnPdKqx2Yux/gfPRyPxbLrA+MBOyCQw+qbkc=; b=Ih7zwE0gC1LZAdIt9Tml5sFW41Bkrn7g8pZKHpu+tU3biXBLSF16fC1FU6sotdcIpJq3Rre4KAAbWcNWuTeDACkfAfh+5HbmiW5wixReEL7sFL/zKf856oeBuYxtgF9B6OIXJTXDelhSfgy2rUaTsr+7nAh9upQe5+81wGdx+b1laDmqBkxYW3vloPlfGfdydRk5dGCT/8uh8YX9RvKExWN2n+kKRXUrb2QKE1KnySCUD1+xlOfq2LVyIkVZ81hbDUcB1qX2+9P8Lrc/TlzBSaGYbJBpmIL/ZP/ASFa33Eeh/CU+iCJfTd1hz/30KkFCXJA/dsrjG35sW3aQ11mgaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qpmJjmbqnPdKqx2Yux/gfPRyPxbLrA+MBOyCQw+qbkc=; b=EbJUghO7TI9m1/KmGwGRGFUE/MW4/mg1aSt9/r8vuLAG0bqioH0Qw/ASmqU7Jukms1nbw6rLI0oXO2NDN7GZrMV4ETvHo7GYqILvTJn/C5JwZINUkkxkbCTM8p9xzBKE9LB0sDOm+0Whta9KhO/pfGVr2VQz8v8tkpjkue9NKYk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB5981.namprd12.prod.outlook.com (2603:10b6:8:7c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Wed, 28 Feb 2024 16:53:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.039; Wed, 28 Feb 2024 16:53:28 +0000 Message-ID: <18e73137-63aa-4760-84cc-3e3b16601ba3@amd.com> Date: Wed, 28 Feb 2024 16:53:24 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] net/nfp: add force reload firmware option Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang References: <20240227111551.3773862-1-chaoyong.he@corigine.com> <20240227111551.3773862-4-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240227111551.3773862-4-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0295.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB5981:EE_ X-MS-Office365-Filtering-Correlation-Id: f4069188-c7f5-4d19-5208-08dc387dc9bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lLEQMx4YvAw5b7pNyljSlk6BKLl4qNdlK8lfFoTY+wxWK+W28Z1w1Jm2iiVd3A+7gVgyvQXmTncUXp7WUb3VCMsgp1BqbMHAqrm8wzTL5FZjTERQ4euu4jqEIqr9hjUFxzw528EIabpKeg5PO8wPze106jawn+ouX7Ru5oNbOIEHsudU+ybJweVRXxEPDxmIoGT6eGR1hblFGEQJmr8LjBn0SIzaRWpKlDDchgpNsnO9g0rDA4twoW+jMuOrI/t/eeoLu3RmT+t0KLTdW1vuGcc2MrWADkcqZndTTJMKaBGpPUj/hvd47SkrJVurWOrbXMMYUo7Y6s4CyIkN8mxPXLpjvtgybQ3Hsp8+mFU6+4YjmAqgO4Oh8AdB34mjuwlQWlqlatTd61NBQwxVpWavRADAqHCktfF4uH+BO43eYiBlCN8cGa/XKL4scMoOdMCuTln4WSF8oUTJdLrmfULVnV3W4K3yKZeqx8GloxEUECaGKW3ml2tQ7ezm5vecYy/bipQXJqprDrTaIWgGYsu8wM7TuS02YI7HuYSaJe7BJrFKHTxeMrrtjzEhNXPAjs6sEcT0jCwBtcQS0hhwsboCE0xPOix0Fejtq7UrphLa3vk5ITRdoTeviuvo1iV/FqDC6WNicThFbfdSUjsNRKY25g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHorbkFxZWRoc25xM1dUcGVtM0lHSnJwSTUzcHZFUkcwNEtPOS9xbHUzaWZB?= =?utf-8?B?WHRacWE2c051UG9oaCtRSlhDcTZCQ1gzV2ZlbkV3YUt4RlFGdUN0eGpTckxl?= =?utf-8?B?V2orTTk1NTYzbEdqejE2c3ExZklVbEVKZmRsemh5ZFZrSVhHNUpCSkZiWDlK?= =?utf-8?B?UldGN1JoL3hwTnpLTCtaZDBNbmN2VlhOOUczeVVvUnM5UEY4b1lvdDVsMS9Q?= =?utf-8?B?N09RMmFEczNkK3gwbGxUQXlxZnZ1SnR4cEtVOGRoMlczWFdFWnkvWE9TN291?= =?utf-8?B?ZGEzMXlUVlJycS9aNjYxL0dkSHBwNFBYZFZoRFZSOTdpSzh1MnBtaUdTbUFh?= =?utf-8?B?STRMclBhMWdzZnlWbEpTSkRPUWRhdXJBSm9KZVlkRjdnQ2hBY21NOXBxeTBu?= =?utf-8?B?QnhVQUhsZnVYb0xYVjZKenMrcTF2NXBQb0Y4dTBsdGlJc2tQdzU5SWd3T3dT?= =?utf-8?B?S09iYlFEaWVFV1dJK0VzQlFNUjMyc3FNWTFkQVJUbXM4NjdUT3JqY0R0aDZ5?= =?utf-8?B?c1VHL1VSOVExZDIrdXFPUnVab0p4MjlOYnR4TnRQdW5uOXV2amVqbFJLWG5i?= =?utf-8?B?L21WWW5ML2RIV3FsVlhHQmt0U0JMd25ZTlh4Mmt0SUgxR1NkUm1iZ0VzZnVr?= =?utf-8?B?YVlBZm1xRzAxdlcxRnFhSHBUMklqNFFWVy9ldXA1WThoMXFSS2ZyM29DZVNP?= =?utf-8?B?NWFmT3Y4NEFlZDNqSE9Jb0hMZFN6bzZmM0luNEMzdXdUNTBEMEQzVkNibXI4?= =?utf-8?B?Q0VHN0owV2FLa0s2UVRkM0FHNEt0amRxU3Vva2dQUFlzRWc2VWNGR2dYcWNQ?= =?utf-8?B?T0dzMEgzQUJNZGVReDU4bkVRT0ZkcGljT29kSGpPZ0hmeWNuTlZzb1RZY25N?= =?utf-8?B?ekQvR2ZEU2JGS0hMcU9YRWZPODBMK045OUpnOFl6UTRwWVB1L0RrOXNTVTM4?= =?utf-8?B?dXdiNThIUGYrcGxtcm9iUitlS2VxQUkreTFabEUxRlRqbDk2RW5RaUExb041?= =?utf-8?B?NThFZVJuU05IbWlOclpKc01pRnRYeGRvVTJmNTRibXFzVWFsak1RVys1a0w4?= =?utf-8?B?YWNCUUpsZ0YyT1ZzaVY0QTV0NEJKdWNlQmtHZ3diRjdjSzNSUXJGMnRVRVpE?= =?utf-8?B?Nnlybi91RXJxWGVLZHcyYmJ5aGM0UUYrTjl2YlBMWTdQSXZIQW1FcjYyWUNz?= =?utf-8?B?VFBiK3Bpc2FzKys1ZTFEdlhMNDNOSmZkendDSklaYUc5Y3hIY2tEK1VnK3Fh?= =?utf-8?B?eEkzaDV5cmJlOXVLRWtIUkFwRlNLSjBWMkUyWGRVcUVTR295aS9GWlNaVldZ?= =?utf-8?B?d1p3ZkFXTjl5b1dTa0gvQTdlRnpqWHdRUFRnOWNTMFA2VlVhOS9venJ5TThH?= =?utf-8?B?NnEwbSt6MjNKaDdLQnR2MjNGaDZBSVNDS1BMZld4V2ltZEZPTzlpcDJWUVgv?= =?utf-8?B?a3lvY0xRcFRVZTMzRlhKSUw5WVFtNGZCbG1LTWRDTGFJUkpJeTZpN3laTVZi?= =?utf-8?B?cGt0TC91ZC9JL0hzUU4zRElOVUZZQWQvSUpObTVmQ2dqTnU0bDBRd1BYaDVQ?= =?utf-8?B?ZE9vSUpnVlJ6a3U0ZnhvMHFjcnd4aHJMTHBzcC9ydUZkVWJPRWxldGJiTC9X?= =?utf-8?B?ejFrTlBTNUhOc2h0Mk9IZDIydmxDWFF1VnFVWFdKQ3J2VkdFN1BGMEZzYVpH?= =?utf-8?B?R0Q3QXhqTUtMaUpJZVBBZ1lUaWJGdy9ONUk4RThpWTA4SGtlaDFxb3kvMGpJ?= =?utf-8?B?Rk9nbkpNakFNRkdxNjJqMHBTNk9BdzM0WXJyTUpFdmV3ZkluVlFQbFJHeExI?= =?utf-8?B?UWNTajRyV1d5VUNJN1JBSFZIc2l4citXTVIrNmlBRHhmM0tkL1owdzVkbGw3?= =?utf-8?B?RHNPL1NyaFZxZlVoU1FBamxha3gycTZxQ29FN0RUTGRZN3VmUnF2V0ZTWE41?= =?utf-8?B?dXdVdkxmN2VVejdLQlBWMHZBMzNvNFc4SlYvSzQ5bU4wMUZieGkrY2xubXFR?= =?utf-8?B?MnRoc3U3VW9FUjE3RXpXN2c0aHFkeUU4MGxjTGVSUUZzUyt3UWpaaWFSYlFW?= =?utf-8?B?T2RFQ2RFRjg5bXZOcnA3aHBMUndZUXc4MkMzMGpOS1V1bHZJQXdwWjN4U1cx?= =?utf-8?Q?dx8u9losNG5dk2AFEBwntx/0W?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4069188-c7f5-4d19-5208-08dc387dc9bb X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 16:53:28.8252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A520bjDmpUf0bw/TqxAhHaHBjz+7NZjFjiKEfNUoSbNmPDICFOe2TNcmAFPI8TAa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5981 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/27/2024 11:15 AM, Chaoyong He wrote: > From: Peng Zhang > > Add an option to force reload the firmware. > > This option can be ignored in some case, for example: > When using a 2 port NFP card and both with this reload firmware option, > only the first one will cause the firmware reload and the second one > will be ignored. > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > --- > drivers/net/nfp/nfp_ethdev.c | 104 +++++++++++++++++++++++++++---- > drivers/net/nfp/nfp_net_common.h | 8 +++ > 2 files changed, 100 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c > index 902a62a86b..8c38b4e134 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > > #include "flower/nfp_flower.h" > #include "nfd3/nfp_nfd3.h" > @@ -31,6 +32,71 @@ > #define NFP_NET_APP_CAP_SP_INDIFF RTE_BIT64(0) /* Indifferent to port speed */ > > #define NFP_PF_DRIVER_NAME net_nfp_pf > +#define NFP_PF_FORCE_RELOAD_FW "force_reload_fw" > + > Can you please document the new devarg in the driver documentation, 'doc/guides/nics/nfp.rst'? Also you may want to document FW upgrade process, as it checks FW version by default and this can be overridden by devarg etc..