From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC97843C27; Fri, 8 Mar 2024 18:23:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5849540291; Fri, 8 Mar 2024 18:23:14 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id 6A27E42EF3 for ; Fri, 8 Mar 2024 18:23:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jJT0hDaPK0VmnNCGfviLjEBCMyjRezQwnm0tNVRfr1K4vh0Y0A1OgWb/pgmT+g5Jwt7jC6itt1QkeHpKqb06TWGlrD5Mdbq5kU8lsFT0WEea4ebwF5VYhw6oLgI4PvX/RazlEGQgtqaQHRwgDBWsXHJAZNletvO+x9+aQ8OKbJE9Y4FygPAR996Ski0mtG32zt0mrOU6lEl4ZFEOPJ4cTrEHntVMi8x5xs6w4mO9H8bIgYljDY6FoKKToH1O2beJ2eg7D3DSf6FH1rXRiJWI/UemUq8nC5zhd4fRBnz3F5L8RD+8Oy0t6SfKb7x1Of0I3DRqar7NU2PKO7Zwv/ye0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/tHDxsIs9zDRLaKe+MwtfJY4u0bKNDJXMxm8+RO2ulc=; b=S0ar7ZlcbM22hwXYJN3tEUuSwdlZSaiS6Pum7tkkLHos9DPOdCUu7Viv5yEq95T3W8PFIQDzfSCBA0zPrbw1yHi2BN0x3IQv7hOrV0B6TMLaJQ0uSogNBIHqGOCudp6MG05neT1g9sUw57nF4AC8jeoWLcvECEXJ1l72G3w8YMzFq4Isu7ESm0be+unnWfGXmUM0EzFRu4/Va7tHRUyaG4L2Q0PKeRyAKGsZo3+XU0Lbv8EsGn8rS3hyyqWPH+qg3W7+klH1fmnh4OFY/wW/oOecLhu6dh2oVcS5DLFNNgpNSZQXSzYblpyfAIKvlH2kdUZQkZmYH/jDhatEhGrKwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/tHDxsIs9zDRLaKe+MwtfJY4u0bKNDJXMxm8+RO2ulc=; b=k+Tp72UfFCVbJEzbiTRSDizBicIgWSJqBFPmlU8ylgXGXU2awIxSmPebZxZXfAhaft7rAV2tNY+EQAeQLqvQlMPKazFTDB5/EchpGqQGbvni96TYbVhYDV6SVBu8yH6DHmcAzO3PaxjX7a7V+0/JaPfsdcAYzMrlmwKZ7kRmWWw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB7829.namprd12.prod.outlook.com (2603:10b6:806:316::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 17:23:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.028; Fri, 8 Mar 2024 17:23:09 +0000 Message-ID: <18ee7e3d-ffe9-4cbf-a065-297be214ffa9@amd.com> Date: Fri, 8 Mar 2024 17:23:05 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/33] net/ena: sub-optimal configuration notifications support Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-5-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240306122445.4350-5-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0217.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB7829:EE_ X-MS-Office365-Filtering-Correlation-Id: 44e84f11-9ad1-461a-4c4c-08dc3f946c85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hjd+clCbrhIwC9ehg0EStQuQbfQIM5sySi7D0KSgozLzpRyy6HR8XHgcsAoU6s5ze5Y5umV2IQxSV6PC8r+4EVS59rWVSqFt9z65eXj+xGHwLrGPqfUsFRNsCW5gVv5sDc4dz6TX6uEwTCNqryvTIchUXl4o3teNSeVQtSFin/L/VgceOcshdp8hpRgqderexv/DNf4pyRvvhSmfh4rlN9Sb/ve/WLktMsWu79MuE5SHcJ6tO9KSL6fh6e7KvtkBhIpb+2E7j8ouVU4TLkBfGxNrDyI7KQ8QlgiW8zp1q4vBuZQG4mtRJiSOwXUgRe9hmeety4kJ3FRoTOpIJvKlQCzN+2hHD4E0b4ePILWhu6HRQxFJ6DL6Y0AWLPdf2/TT5IyOJx8N8009D0S4yzhIO+8F1Gr9R2338+FMU10DkRo1n5O2+Kmv7Y5DjGDlHHs5uaekz3H9XfEuGgH3/8Zmw2ErNueSQVnda9BxjKRrBr2IxK4UlNlX9cCn1E+Jyf1bo5jWeq6TT0oO6VZ+2Y/LmEqTN/mrzIwyPPJfcdM+ZBat2rPCJ2sUAnhU5Tv/R7dQIT3TOvYO2nKrZsO5uzkodBwu+2TIBvwOZvDFYyErNvaDjNphe3IaEJfzCj76X0UXrJ5C58DmmhFEjvQX+7zFbV8AWeNie0jNz+b5lPZqoCQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L05qczlJSy83cW84WXd6WkFwUGo4TTdFT1Z0UXIwYkJ3UDdpbFNRMHRLTHo5?= =?utf-8?B?NHRjZnJITEthWk1wOWRCOGI0RFYwZzduNzN6bko2Z2JWNXdRZkpqSlp0RWlS?= =?utf-8?B?bml1MXVvNlZub2J5NnhMNDVGbU1BYXNnRjdhUkNvMjFjODRmSDJrSk5aNEtq?= =?utf-8?B?dEFFQ0NGdDF3djNCU3J1T0N5ZVVWZG95SWNzOWhVNUVTVTl1VTJtbGZSc0hW?= =?utf-8?B?a3BYY2lRSmR2VGU1NkY0OXFwVzNyUENyell4ODJ5d3B2MlVrTTdTeFMvVWI1?= =?utf-8?B?cGdENTBNd3QrU1pCRDVCWU4yTUlRWnJoZmVFT2hnUlYzSWZFYXVCYzRST1o2?= =?utf-8?B?ZHQwZ2dJcTN0OHpERXBzRHpOMjN1VzNsbWFDYVhpdVA4eUVyRzdHY3pPVFA0?= =?utf-8?B?TjQzaGd3VXpVM1kvQTdpWUZHL0VJV0tZdk4wR2E5b1hmeURPRDVZTnVIVzBQ?= =?utf-8?B?akRKd3dIa0lLZTJENGJ1V3ZoVEpEWjlVOTNLdmFCeUxZOTkrb0JpQ2ZKWFUz?= =?utf-8?B?ZXpJcVpLZGJxZENFNmxyYkJZVXU2bjc1V1p0c3pYOXdKUVQxRzFiUVZDRXNZ?= =?utf-8?B?Rno1UnZvaEZad3hoemY2R3pWUm8zSDA2MEdOWTJpbis1SVR0WFB0TDVISDN1?= =?utf-8?B?VWpySmFST2V6a2VTMzM3bm8zenptY2xuMlU1NUs5SFdOUkd4elhyNVZYUXNy?= =?utf-8?B?bnczVk1pUFp1Sjk3VE9oWHc3K283dzlEQ2hkZzFBNjZleFg2emova2dJN0pY?= =?utf-8?B?YTFhSzVQaklPMkRHSVJHTk5SRkdXdk5UOHpkMndiTUhkMit1Z0ptdnNaeVUr?= =?utf-8?B?eENwQ0F1dlJFYkJDajA5dEROQU5GOW9qQkQvUFJhZHlUMHpncUhhWllRNlFZ?= =?utf-8?B?WUZISWl4enZjdE5KNUlMMlNNNzR2QkNYOUVMUlpnb0wybnIrcmhsaWJRSDh1?= =?utf-8?B?cFlFOEY0enJsQ0dTZG9xZms5UkRDU3BVcHpoNTFyeDBrWktySHdKbmNFbnRW?= =?utf-8?B?RGgvenNsOEJ6NDNXT3Y5NUVrNmhKcmNPWkVrSHpyWHBsczhYRmNkeTF4V2ZO?= =?utf-8?B?NDVKbXhsdnF3aVdVZk8zdy9DbGhmSmxaSzVpY0o4S21mRU5oVUdIblRPMnhy?= =?utf-8?B?QWc3SVlnVERsb085dk95R1BUcW1PWVRNSytiK2ZhcWlsWlNyRk15MjBRZ3B1?= =?utf-8?B?ZHcvYUt3eGgxM2tTOXNmY2p4bFdqMlVOREZ6bjVrOE5RRDZoWTJiaFpEbE1C?= =?utf-8?B?SU4xS2w3SWN6RHY0SUVrR1V0R1l3aThoNUlRZ0I1eHVqTnNyUjY0YWM1NlBD?= =?utf-8?B?enVOYUVGQ3paL3lEdVlUSGdkWU9BeTBwTUV0QmllVllIZXNPZ2dJeWhNd2pY?= =?utf-8?B?eTdPaEdseWZuSE1KNDhDTVpRSW9XUmxlUWhtaVJwNi9iSFVyM3JmWURkNXhX?= =?utf-8?B?Ullva0pQSlppcm1FYjdHSjkxZnRlcExZSlZtVE04L1E5TG1WZXNlcTBPd05Y?= =?utf-8?B?S3NESkg2dVV2ejN0Y2lWeVhlbmVNMzgrYTVOSkJWejdZN3Bsc1JpSzdwaVNN?= =?utf-8?B?R2xxTzF1Y2E4d3NMM1VxY3loUWxvRmJqd2dUQkEvMUdtT3d4UUNoUXFPaTgz?= =?utf-8?B?VFY0b2FyQUMwb052T3lMeFVJM1ZtQVVJNGJ3em5jWmJiRENyVFRiUXV2VEU2?= =?utf-8?B?UG9JRHBzN1k4L2NwMFdxd2dZb2s1Rmx2OWtBR2ZjTGdOYU1seXNCOEdRTkww?= =?utf-8?B?NDgwTVVHd1Y4R2xaWUtmS2pqY3VJU2pOcWhmVldJMFc4OWN2NlpYaXQwUXpi?= =?utf-8?B?SXFTLzIwWTRsZFBWVXdiNFNUbDdJTzk1Sk9KWTFONFhYSmhUYTZ4c21nSjRF?= =?utf-8?B?ckpNTHhQdlRTS3E0WnpRZ0NzYTN1S2VBS3BwT2dITVlEbWF3RXVXRUFzNHVY?= =?utf-8?B?V3Qwa3NaSHNxQm9QeFFCSzFsQVBwQXNxMEhBUndlT0RMUGw0YjAxWHBLcTFV?= =?utf-8?B?cjQvRXAzbFJwV3hKR2ZySlJGUWdWNnpaRVh2c0FRbHlTc0k2NmVFUGllYUEy?= =?utf-8?B?dTZTTWdiZTllYmhnczRTL2ZHc0FxcFBkYURWaDc0dUhPa0ZVMHQ0cVhGNW5s?= =?utf-8?Q?ZFRNxmiaKITL6gk/A04dXRudF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44e84f11-9ad1-461a-4c4c-08dc3f946c85 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 17:23:09.1646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vPguxpPXpgdjpYK3N+TEF4CffscCsgTL32UqjqXnFwZeMMGB78hCVjMKowC4EJH5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7829 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > ENA device will send asynchronous notifications to the > driver in order to notify users about sub-optimal configurations > and refer them to public AWS documentation for further action. > Hi Shai, This is an interesting feature, I am curious, is there more public detail provided by AWS on how it detects sub-optimal configuration and what are the possible types of the notifications? > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > --- > doc/guides/rel_notes/release_24_03.rst | 1 + > .../net/ena/base/ena_defs/ena_admin_defs.h | 11 +++++++- > drivers/net/ena/ena_ethdev.c | 26 +++++++++++++++++-- > 3 files changed, 35 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst > index fb66d67d32..f47073c7dc 100644 > --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -104,6 +104,7 @@ New Features > * **Updated Amazon ena (Elastic Network Adapter) net driver.** > > * Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value. > + * Added support for sub-optimal configuration notifications from the device. > > * **Updated Atomic Rules' Arkville driver.** > > diff --git a/drivers/net/ena/base/ena_defs/ena_admin_defs.h b/drivers/net/ena/base/ena_defs/ena_admin_defs.h > index fa43e22918..4172916551 100644 > --- a/drivers/net/ena/base/ena_defs/ena_admin_defs.h > +++ b/drivers/net/ena/base/ena_defs/ena_admin_defs.h > @@ -1214,7 +1214,8 @@ enum ena_admin_aenq_group { > ENA_ADMIN_NOTIFICATION = 3, > ENA_ADMIN_KEEP_ALIVE = 4, > ENA_ADMIN_REFRESH_CAPABILITIES = 5, > - ENA_ADMIN_AENQ_GROUPS_NUM = 6, > + ENA_ADMIN_CONF_NOTIFICATIONS = 6, > + ENA_ADMIN_AENQ_GROUPS_NUM = 7, > }; > > enum ena_admin_aenq_notification_syndrome { > @@ -1251,6 +1252,14 @@ struct ena_admin_aenq_keep_alive_desc { > uint32_t rx_overruns_high; > }; > > +struct ena_admin_aenq_conf_notifications_desc { > + struct ena_admin_aenq_common_desc aenq_common_desc; > + > + uint64_t notifications_bitmap; > + > + uint64_t reserved; > +}; > + > struct ena_admin_ena_mmio_req_read_less_resp { > uint16_t req_id; > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index d3f395a832..3157237c0d 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -36,6 +36,10 @@ > > #define ENA_MIN_RING_DESC 128 > > +#define BITS_PER_BYTE 8 > + > +#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) > + > 'CHAR_BIT' macro can be used here, but I can see there are multiple drivers defining similar macros.So no need to update this patch, but to record that this is something to address DPDK wide. If ena team volunteers to tackle this update, it is welcomed ;)