DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ivan Malov <ivan.malov@arknetworks.am>, dev@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	stable@dpdk.org, Andy Moreton <amoreton@xilinx.com>,
	Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
Subject: Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs
Date: Thu, 18 May 2023 17:25:40 +0100	[thread overview]
Message-ID: <18f3e3aa-1fc1-24a8-50c5-90e45e9cd688@amd.com> (raw)
In-Reply-To: <20230424143046.6487-1-ivan.malov@arknetworks.am>

On 4/24/2023 3:30 PM, Ivan Malov wrote:
> When the client driver (the DPDK one, for instance) parses user flow
> actions, it ends up with an action set specification. Next, in case
> there are any FW resource-backed actions, like COUNT or SET_DST_MAC,
> the driver allocates these resources and indicates their IDs in the
> action set specification. The API used to set these IDs checks that
> the current value of the target ID is INVALID, prior to the call.
> 
> The latter check, however, prevents the driver from updating the
> IDs on port restart. When the port goes down, the driver frees
> the resources. When the port goes up, the driver reallocates
> them, tries to set the IDs in the specification and fails.
> 
> In order to address the problem, add an API to drop the
> current resource IDs in the actions set specification.
> 
> Fixes: 3907defa5bf0 ("common/sfc_efx/base: support adding encap action to a set")
> Cc: stable@dpdk.org>

Hi Ivan,

As far as I understand this patch extracts some code into a function, so
I expect no functional change in this patch. So not clear what this
patch is fixing?

And I can see this new API is used in next patch and it fixes an issue.
But while backporting this fix to LTS we want both patch to backport
because there is a dependency.

If there is no functional change in this patch, what about merging these
two patches, and explain what is fixed? This also helps backporting.

  parent reply	other threads:[~2023-05-18 16:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 14:30 Ivan Malov
2023-04-24 14:30 ` [PATCH 2/2] net/sfc: invalidate dangling MAE flow action FW " Ivan Malov
2023-05-18 16:25 ` Ferruh Yigit [this message]
2023-05-18 17:21   ` [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action " Ivan Malov
2023-05-19  8:47     ` Ferruh Yigit
2023-05-19  9:01       ` Ivan Malov
2023-05-22 10:21         ` Ferruh Yigit
2023-05-21  8:36 ` [PATCH v2] drivers: invalidate dangling MAE flow action FW " Ivan Malov
2023-05-22  6:48   ` Andrew Rybchenko
2023-05-22 10:20     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18f3e3aa-1fc1-24a8-50c5-90e45e9cd688@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=amoreton@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=denis.pryazhennikov@arknetworks.am \
    --cc=dev@dpdk.org \
    --cc=ivan.malov@arknetworks.am \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).