DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luka Jankovic <luka.jankovic@ericsson.com>
To: "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [EXTERNAL] [RFC v5 1/2] eventdev: add atomic queue to test-eventdev app
Date: Wed, 22 Jan 2025 15:10:44 +0000	[thread overview]
Message-ID: <18fe516245709b8d7fee725ce9e1e65f15503b86.camel@ericsson.com> (raw)
In-Reply-To: <PH0PR18MB408655D9933BD25537FE2061DEE12@PH0PR18MB4086.namprd18.prod.outlook.com>

On Wed, 2025-01-22 at 10:20 +0000, Pavan Nikhilesh Bhagavatula wrote:
> > Add an atomic queue test based on the order queue test that exclusively uses
> > atomic queues.
> > This makes it compatible with event devices such as the distributed software
> > eventdev.
> >
> > The test detects if port maintenance is required.
> >
> > To verify atomicity, a spinlock is set up for each combination of queue and
> > flow.
> > It is taken whenever an event is dequeued for processing and released when
> > processing is finished.
> > The test will fail if a port attempts to take a lock which is already taken.
> >
> > Signed-off-by: Luka Jankovic <luka.jankovic@ericsson.com>
> > ---
> > v5:
> >  * Updated documentation for dpdk-test-eventdev
> > v4:
> >  * Fix code style issues.
> >  * Remove unused imports.
> > v3:
> >  * Use struct to avoid bit operations when accessing event u64.
> >  * Changed __rte_always_inline to inline for processing stages.
> >  * Introduce idle timeout constant.
> >  * Formatting and cleanup.
> > v2:
> >  * Changed to only check queue, flow combination, not port, queue, flow.
> >  * Lock is only held when a packet is processed.
> >  * Utilize event u64 instead of mbuf.
>
> Hi Luka,
>
> This test fails on Marvell CNXK platform because HW assumes that value of
> event.u64
> will be 8byte aligned and upper bits as per[1], for optimizations purposes.
> Could you go back to using mbuf similar to ordered_atq/queue
>
> Thanks,
> Pavan.

Thanks for bringing it up, I wasn't aware. I will revert back to the mbuf
implementation.

>
> >  * General cleanup.
>
> [1]
> https://docs.kernel.org/arch/arm64/memory.html


  reply	other threads:[~2025-01-22 15:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 14:48 [RFC v2 1/1] " Luka Jankovic
2024-12-23 11:16 ` Mattias Rönnblom
2025-01-09 10:22   ` Luka Jankovic
2025-01-13  9:04 ` [RFC v3 " ejnulak
2025-01-13 12:17 ` [RFC v4 " Luka Jankovic
2025-01-13 12:27   ` [EXTERNAL] " Jerin Jacob
2025-01-15 13:38   ` [RFC v5 1/2] " Luka Jankovic
2025-01-22 10:20     ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-01-22 15:10       ` Luka Jankovic [this message]
2025-01-15 13:38   ` [RFC v5 2/2] eventdev: documentation for atomic queue test Luka Jankovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18fe516245709b8d7fee725ce9e1e65f15503b86.camel@ericsson.com \
    --to=luka.jankovic@ericsson.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).