From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 761EEA0524; Tue, 13 Apr 2021 18:25:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64D5C161186; Tue, 13 Apr 2021 18:25:37 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5FDE2161189 for ; Tue, 13 Apr 2021 18:25:35 +0200 (CEST) IronPort-SDR: HdmFtq/cfYUsxRN0d8/3DVFgNrlHUXW+30+nwwU4LmWTGM/3A1tyAQXGgMAAFO7eOelzt40GQG qVD55bX5Pcww== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="174549514" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="174549514" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 09:18:44 -0700 IronPort-SDR: m/a0axUj2F1Tr6nrQI/QEiI8TJwKzZ23kXXIi3aUhtZtaZF6WWFsFpJDpJfamvHNr6N+S4a6Mu EsVSd1OmDmTQ== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="424319037" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.251]) ([10.213.204.251]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 09:18:43 -0700 From: Ferruh Yigit To: Ori Kam Cc: dpdk-dev , Bing Zhao , Ajit Khaparde References: <20210308223434.48768-1-ajit.khaparde@broadcom.com> <14c80ab0-217e-95b0-7997-2c4297f9ad1a@intel.com> X-User: ferruhy Message-ID: <19021fca-b4bb-1b09-a1a5-24c4716ec12c@intel.com> Date: Tue, 13 Apr 2021 17:18:38 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: fix formatting in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/26/2021 10:00 AM, Ferruh Yigit wrote: > On 3/9/2021 10:00 PM, Ajit Khaparde wrote: >> On Tue, Mar 9, 2021 at 4:52 AM Ferruh Yigit wrote: >>> >>> On 3/8/2021 10:34 PM, Ajit Khaparde wrote: >>>> Fix formatting in testpmd user guide for hairpin operation. >>>> >>>> Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") >>>> Cc:stable@dpdk.org >>>> >>>> Signed-off-by: Ajit Khaparde >>>> Cc: Bing Zhao >>>> Cc: Ori Kam >>>> --- >>>>    doc/guides/testpmd_app_ug/run_app.rst | 12 +++++++----- >>>>    1 file changed, 7 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/doc/guides/testpmd_app_ug/run_app.rst >>>> b/doc/guides/testpmd_app_ug/run_app.rst >>>> index 3035118cdc..8ec2300ee5 100644 >>>> --- a/doc/guides/testpmd_app_ug/run_app.rst >>>> +++ b/doc/guides/testpmd_app_ug/run_app.rst >>>> @@ -531,11 +531,13 @@ The command line options are: >>>> >>>>    *   ``--hairpin-mode=0xXX`` >>>> >>>> -    Set the hairpin port mode with bitmask, only valid when hairpin queues >>>> number is set. >>>> -    bit 4 - explicit Tx flow rule >>>> -    bit 1 - two hairpin ports paired >>>> -    bit 0 - two hairpin ports loop >>>> -    The default value is 0. Hairpin will use single port mode and implicit >>>> Tx flow mode. >>>> +    Set the hairpin port mode with bitmask, only valid when hairpin queues >>>> number is set:: >>>> + >>>> +     bit 4 - explicit Tx flow rule >>>> +     bit 1 - two hairpin ports paired >>>> +     bit 0 - two hairpin ports loop >>>> +     The default value is 0. >>>> +     Hairpin will use single port mode and implicit Tx flow mode. >>>> >>> >>> Not sure if the last line intended to be part of the list, what do you think >>> only keep bit descriptions in the box but left the last sentences as regular >>> paragraph. >>> Ori please correct me if I am wrong with the original intention. >> Ori, >> Not just indentation. How about this modified text as well? >> >> -       bit 0 - two hairpin ports loop >> -       The default value is 0. >> -       Hairpin will use single port mode and implicit Tx flow mode. >> +       bit 0 - two hairpin ports loop (default) >> + >> +.. Note:: >> + >> +   When hairpin is used in single port mode, Tx flow rule will be implicit. >> Does this statement look right? >> > > Ping Hi Ori, can you please check the question, let's close this patch out of way.